diff mbox

[ARM/AArch64,02/11] We can remove useless #ifdefs from these tests: vmul, vshl and vtst.

Message ID 1462973041-7911-3-git-send-email-christophe.lyon@linaro.org
State New
Headers show

Commit Message

Christophe Lyon May 11, 2016, 1:23 p.m. UTC
2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>

	* gcc.target/aarch64/advsimd-intrinsics/vmul.c: Remove useless #ifdef.
	* gcc.target/aarch64/advsimd-intrinsics/vshl.c: Likewise.
	* gcc.target/aarch64/advsimd-intrinsics/vtst.c: Likewise.

Change-Id: I1b00b8edc4db6e6457be5bc1f92e8b6e218da644

Comments

James Greenhalgh May 13, 2016, 1:54 p.m. UTC | #1
On Wed, May 11, 2016 at 03:23:52PM +0200, Christophe Lyon wrote:
> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	* gcc.target/aarch64/advsimd-intrinsics/vmul.c: Remove useless #ifdef.
> 	* gcc.target/aarch64/advsimd-intrinsics/vshl.c: Likewise.
> 	* gcc.target/aarch64/advsimd-intrinsics/vtst.c: Likewise.

OK.

Thanks,
James
Kyrill Tkachov May 16, 2016, 1:25 p.m. UTC | #2
On 11/05/16 14:23, Christophe Lyon wrote:
> 2016-05-02  Christophe Lyon  <christophe.lyon@linaro.org>
>
> 	* gcc.target/aarch64/advsimd-intrinsics/vmul.c: Remove useless #ifdef.
> 	* gcc.target/aarch64/advsimd-intrinsics/vshl.c: Likewise.
> 	* gcc.target/aarch64/advsimd-intrinsics/vtst.c: Likewise.

Ok.
Thanks,
Kyrill

> Change-Id: I1b00b8edc4db6e6457be5bc1f92e8b6e218da644
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
> index 0cbb656..63f0d8d 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
> @@ -37,10 +37,8 @@ VECT_VAR_DECL(expected,poly,8,16) [] = { 0x60, 0xca, 0x34, 0x9e,
>   VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0xc4c73333, 0xc4bac000,
>   					   0xc4ae4ccd, 0xc4a1d999 };
>   
> -#ifndef INSN_NAME
>   #define INSN_NAME vmul
>   #define TEST_MSG "VMUL"
> -#endif
>   
>   #define FNNAME1(NAME) exec_ ## NAME
>   #define FNNAME(NAME) FNNAME1(NAME)
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
> index 821c11e..e8a57a4 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
> @@ -101,10 +101,8 @@ VECT_VAR_DECL(expected_negative_shift,uint,64,2) [] = { 0x7ffffffffffffff,
>   							0x7ffffffffffffff };
>   
>   
> -#ifndef INSN_NAME
>   #define INSN_NAME vshl
>   #define TEST_MSG "VSHL/VSHLQ"
> -#endif
>   
>   #define FNNAME1(NAME) exec_ ## NAME
>   #define FNNAME(NAME) FNNAME1(NAME)
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
> index 7f96540..9e74ffb 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
> @@ -32,10 +32,8 @@ VECT_VAR_DECL(expected_unsigned,uint,16,8) [] = { 0x0, 0xffff,
>   VECT_VAR_DECL(expected_unsigned,uint,32,4) [] = { 0x0, 0xffffffff,
>   						  0x0, 0xffffffff };
>   
> -#ifndef INSN_NAME
>   #define INSN_NAME vtst
>   #define TEST_MSG "VTST/VTSTQ"
> -#endif
>   
>   /* We can't use the standard ref_v_binary_op.c template because vtst
>      has no 64 bits variant, and outputs are always of uint type.  */
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
index 0cbb656..63f0d8d 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vmul.c
@@ -37,10 +37,8 @@  VECT_VAR_DECL(expected,poly,8,16) [] = { 0x60, 0xca, 0x34, 0x9e,
 VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0xc4c73333, 0xc4bac000,
 					   0xc4ae4ccd, 0xc4a1d999 };
 
-#ifndef INSN_NAME
 #define INSN_NAME vmul
 #define TEST_MSG "VMUL"
-#endif
 
 #define FNNAME1(NAME) exec_ ## NAME
 #define FNNAME(NAME) FNNAME1(NAME)
diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
index 821c11e..e8a57a4 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vshl.c
@@ -101,10 +101,8 @@  VECT_VAR_DECL(expected_negative_shift,uint,64,2) [] = { 0x7ffffffffffffff,
 							0x7ffffffffffffff };
 
 
-#ifndef INSN_NAME
 #define INSN_NAME vshl
 #define TEST_MSG "VSHL/VSHLQ"
-#endif
 
 #define FNNAME1(NAME) exec_ ## NAME
 #define FNNAME(NAME) FNNAME1(NAME)
diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
index 7f96540..9e74ffb 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c
@@ -32,10 +32,8 @@  VECT_VAR_DECL(expected_unsigned,uint,16,8) [] = { 0x0, 0xffff,
 VECT_VAR_DECL(expected_unsigned,uint,32,4) [] = { 0x0, 0xffffffff,
 						  0x0, 0xffffffff };
 
-#ifndef INSN_NAME
 #define INSN_NAME vtst
 #define TEST_MSG "VTST/VTSTQ"
-#endif
 
 /* We can't use the standard ref_v_binary_op.c template because vtst
    has no 64 bits variant, and outputs are always of uint type.  */