Message ID | 1461622282-30463-1-git-send-email-colin.king@canonical.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Hi Colin, Colin King <colin.king@canonical.com> writes: > From: Colin Ian King <colin.king@canonical.com> > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Even though that cannot happen, the fix doesn't hurt. Adding Geert in the loop who submitted an RFC for this first: https://lkml.org/lkml/2016/4/25/95 Thanks, Vivien
From: Colin King <colin.king@canonical.com> Date: Mon, 25 Apr 2016 23:11:22 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The error return err is not initialized and there is a possibility > that err is not assigned causing mv88e6xxx_port_bridge_join to > return a garbage error return status. Fix this by initializing err > to 0. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 028f92f..98d3cfb 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -2207,7 +2207,7 @@ int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port, struct net_device *bridge) { struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); - int i, err; + int i, err = 0; mutex_lock(&ps->smi_mutex);