| Message ID | 1453111448-12445-1-git-send-email-wni@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, Jan 18, 2016 at 06:04:08PM +0800, Wei Ni wrote: > Add hw-trips sub-node for soctherm, which is > used to describe the hardware trip points for > each soctherm sensors. Please make use of the full 78 characters in each line. Otherwise looks good to me. Oh, also make sure to Cc: devicetree@vger.kernel.org on device tree binding patches. Doing that now, hence quoting verbatim. Thierry > > Signed-off-by: Wei Ni <wni@nvidia.com> > --- > .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt > index 6b68cd150405..75dc9dbe7e1a 100644 > --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt > +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt > @@ -26,6 +26,15 @@ Required properties : > of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a > list of valid values when referring to thermal sensors. > > +Optional properties: > +- hw-trip-points : A sub-node which is a container of hardware trip points > + for each sensors. > + * sensors: Sub-nodes which are used to describe the HW trip points info, > + must be named as "cpu", "gpu", "mem", "pll". > + Properties: > + - thermtrip-temperature : Shutdown or reset temperature in millicelsius, > + once the temperature of this sensor is higher than the > + thermtrip-temperature, the system will be shutdown or reset. > > Example : > > @@ -40,6 +49,21 @@ Example : > reset-names = "soctherm"; > > #thermal-sensor-cells = <1>; > + > + hw-trip-points { > + cpu { > + thermtrip-temperature = <103000>; > + }; > + gpu { > + thermtrip-temperature = <103500>; > + }; > + mem { > + thermtrip-temperature = <103500>; > + }; > + pll { > + thermtrip-temperature = <105000>; > + }; > + }; > }; > > Example: referring to thermal sensors : > -- > 1.9.1 >
On Mon, Jan 18, 2016 at 06:04:08PM +0800, Wei Ni wrote: > Add hw-trips sub-node for soctherm, which is > used to describe the hardware trip points for > each soctherm sensors. Also the subject and commit message should be updated to reflect the new sub-node name. Thierry
On 2016年01月21日 22:52, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Jan 18, 2016 at 06:04:08PM +0800, Wei Ni wrote: >> Add hw-trips sub-node for soctherm, which is >> used to describe the hardware trip points for >> each soctherm sensors. > > Please make use of the full 78 characters in each line. Otherwise looks > good to me. Ok, I will check it again. > > Oh, also make sure to Cc: devicetree@vger.kernel.org on device tree > binding patches. Doing that now, hence quoting verbatim. Sure, will do it. > > Thierry > >> >> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> index 6b68cd150405..75dc9dbe7e1a 100644 >> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> @@ -26,6 +26,15 @@ Required properties : >> of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a >> list of valid values when referring to thermal sensors. >> >> +Optional properties: >> +- hw-trip-points : A sub-node which is a container of hardware trip points >> + for each sensors. >> + * sensors: Sub-nodes which are used to describe the HW trip points info, >> + must be named as "cpu", "gpu", "mem", "pll". >> + Properties: >> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius, >> + once the temperature of this sensor is higher than the >> + thermtrip-temperature, the system will be shutdown or reset. >> >> Example : >> >> @@ -40,6 +49,21 @@ Example : >> reset-names = "soctherm"; >> >> #thermal-sensor-cells = <1>; >> + >> + hw-trip-points { >> + cpu { >> + thermtrip-temperature = <103000>; >> + }; >> + gpu { >> + thermtrip-temperature = <103500>; >> + }; >> + mem { >> + thermtrip-temperature = <103500>; >> + }; >> + pll { >> + thermtrip-temperature = <105000>; >> + }; >> + }; >> }; >> >> Example: referring to thermal sensors : >> -- >> 1.9.1 >> > > * Unknown Key > * 0x7F3EB3A1 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016年01月21日 22:53, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Jan 18, 2016 at 06:04:08PM +0800, Wei Ni wrote: >> Add hw-trips sub-node for soctherm, which is >> used to describe the hardware trip points for >> each soctherm sensors. > > Also the subject and commit message should be updated to reflect the new > sub-node name. Yes, will fix it. > > Thierry > > * Unknown Key > * 0x7F3EB3A1 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt index 6b68cd150405..75dc9dbe7e1a 100644 --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt @@ -26,6 +26,15 @@ Required properties : of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a list of valid values when referring to thermal sensors. +Optional properties: +- hw-trip-points : A sub-node which is a container of hardware trip points + for each sensors. + * sensors: Sub-nodes which are used to describe the HW trip points info, + must be named as "cpu", "gpu", "mem", "pll". + Properties: + - thermtrip-temperature : Shutdown or reset temperature in millicelsius, + once the temperature of this sensor is higher than the + thermtrip-temperature, the system will be shutdown or reset. Example : @@ -40,6 +49,21 @@ Example : reset-names = "soctherm"; #thermal-sensor-cells = <1>; + + hw-trip-points { + cpu { + thermtrip-temperature = <103000>; + }; + gpu { + thermtrip-temperature = <103500>; + }; + mem { + thermtrip-temperature = <103500>; + }; + pll { + thermtrip-temperature = <105000>; + }; + }; }; Example: referring to thermal sensors :
Add hw-trips sub-node for soctherm, which is used to describe the hardware trip points for each soctherm sensors. Signed-off-by: Wei Ni <wni@nvidia.com> --- .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+)