| Message ID | 5649A770.8090909@endocode.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Mon, Nov 16, 2015 at 10:52:48AM CET, dragos@endocode.com wrote: >rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, >but when CONFIG_NET_SWITCHDEV is off, it returns an error. > >Fix that by returning the given unmodified idx. > >A similar fix was 0890cf6cb6ab ("switchdev: fix return value of >switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y >case. > >Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") >Signed-off-by: Dragos Tatulea <dragos@endocode.com> Acked-by: Jiri Pirko <jiri@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Dragos Tatulea <dragos@endocode.com> Date: Mon, 16 Nov 2015 10:52:48 +0100 > rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, > but when CONFIG_NET_SWITCHDEV is off, it returns an error. > > Fix that by returning the given unmodified idx. > > A similar fix was 0890cf6cb6ab ("switchdev: fix return value of > switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y > case. > > Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") > Signed-off-by: Dragos Tatulea <dragos@endocode.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/switchdev.h b/include/net/switchdev.h index bc865e2..bc5765a 100644 --- a/include/net/switchdev.h +++ b/include/net/switchdev.h @@ -323,7 +323,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb, struct net_device *filter_dev, int idx) { - return -EOPNOTSUPP; + return idx; } static inline void switchdev_port_fwd_mark_set(struct net_device *dev,
rtnl_fdb_dump always expects an index to be returned by the ndo_fdb_dump op, but when CONFIG_NET_SWITCHDEV is off, it returns an error. Fix that by returning the given unmodified idx. A similar fix was 0890cf6cb6ab ("switchdev: fix return value of switchdev_port_fdb_dump in case of error") but for the CONFIG_NET_SWITCHDEV=y case. Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.") Signed-off-by: Dragos Tatulea <dragos@endocode.com> --- include/net/switchdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html