| Message ID | 1270488982.31062.28.camel@Joe-Laptop.home |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Joe, On Mon, Apr 05, 2010 at 10:36:22AM -0700, Joe Perches wrote: > On Mon, 2010-04-05 at 19:13 +0200, Adrian Glaubitz wrote: > > Hi guys, > > > > I installed Debian unstable on an old digital workstation "DEC Digital > > Personal Workstation 433au" (Miata) which has an on-board tulip > > network controller. I'm not really using that network controller but > > an off-board intel e1000 controller. However, I found that the tulip > > driver produces a lot of noise in the message log, the following > > message is repated periodically and spams the whole message log: > > > > 0000:00:03.0: tulip_stop_rxtx() failed (CSR5 0xf0260000 CSR6 0xb3862002) > > > > Do you think this is related to the fact that no cable is connected to > > the network controller? > > Probably something is trying periodically to open the device. > Maybe this helps reduce the message log noise: Thanks for the patch. I will apply it to a current rc of 2.6.34 and build a new kernel, probably not before tomorrow as I cannot reboot the Alpha remotely as the "aboot" boot loader does not boot automatically. Thanks, Adrian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, Apr 05, 2010 at 10:36:22AM -0700, Joe Perches wrote: > On Mon, 2010-04-05 at 19:13 +0200, Adrian Glaubitz wrote: > > Hi guys, > > > > I installed Debian unstable on an old digital workstation "DEC Digital > > Personal Workstation 433au" (Miata) which has an on-board tulip > > network controller. I'm not really using that network controller but > > an off-board intel e1000 controller. However, I found that the tulip > > driver produces a lot of noise in the message log, the following > > message is repated periodically and spams the whole message log: > > > > 0000:00:03.0: tulip_stop_rxtx() failed (CSR5 0xf0260000 CSR6 0xb3862002) > > > > Do you think this is related to the fact that no cable is connected to > > the network controller? > > Probably something is trying periodically to open the device. > Maybe this helps reduce the message log noise: > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Patch works perfectly. Now the message log looks pretty normal. Thanks, Adrian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Date: Wed, 7 Apr 2010 15:42:28 +0200 > Hi, > > On Mon, Apr 05, 2010 at 10:36:22AM -0700, Joe Perches wrote: >> On Mon, 2010-04-05 at 19:13 +0200, Adrian Glaubitz wrote: >> > Hi guys, >> > >> > I installed Debian unstable on an old digital workstation "DEC Digital >> > Personal Workstation 433au" (Miata) which has an on-board tulip >> > network controller. I'm not really using that network controller but >> > an off-board intel e1000 controller. However, I found that the tulip >> > driver produces a lot of noise in the message log, the following >> > message is repated periodically and spams the whole message log: >> > >> > 0000:00:03.0: tulip_stop_rxtx() failed (CSR5 0xf0260000 CSR6 0xb3862002) >> > >> > Do you think this is related to the fact that no cable is connected to >> > the network controller? >> >> Probably something is trying periodically to open the device. >> Maybe this helps reduce the message log noise: >> >> Signed-off-by: Joe Perches <joe@perches.com> > > Acked-by: Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > Patch works perfectly. Now the message log looks pretty normal. This doesn't fix the problem, it just makes the message get emitted in a rate limited manner. I'm not going to apply this, we need to figure out what's causing this problem instead of merely papering over it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/tulip/tulip.h b/drivers/net/tulip/tulip.h index 0afa2d4..8c675aa 100644 --- a/drivers/net/tulip/tulip.h +++ b/drivers/net/tulip/tulip.h @@ -515,12 +515,11 @@ static inline void tulip_stop_rxtx(struct tulip_private *tp) while (--i && (ioread32(ioaddr + CSR5) & (CSR5_TS|CSR5_RS))) udelay(10); - if (!i) - printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed" - " (CSR5 0x%x CSR6 0x%x)\n", - pci_name(tp->pdev), - ioread32(ioaddr + CSR5), - ioread32(ioaddr + CSR6)); + if (!i && tulip_debug > 1) + printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed (CSR5 0x%x CSR6 0x%x)\n", + pci_name(tp->pdev), + ioread32(ioaddr + CSR5), + ioread32(ioaddr + CSR6)); } }