| Message ID | 1442956410-1291-1-git-send-email-azhou@nicira.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Sep 22, 2015 at 2:13 PM, Andy Zhou <azhou@nicira.com> wrote: > Those changes prevent compiler warnings. > > Signed-off-by: Andy Zhou <azhou@nicira.com> > --- > lib/netdev-dpdk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index e4e3d2c..e7eb526 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -1785,13 +1785,13 @@ new_device(struct virtio_net *dev) > ovs_mutex_unlock(&dpdk_mutex); > > if (!exists) { > - VLOG_INFO("vHost Device '%s' (%ld) can't be added - name not found", > + VLOG_INFO("vHost Device '%s' (%lld) can't be added - name not found", > dev->ifname, dev->device_fh); > > return -1; > } > > - VLOG_INFO("vHost Device '%s' (%ld) has been added", > + VLOG_INFO("vHost Device '%s' (%lld) has been added", > dev->ifname, dev->device_fh); > return 0; > } > @@ -1830,7 +1830,7 @@ destroy_device(volatile struct virtio_net *dev) > } > ovs_mutex_unlock(&dpdk_mutex); > > - VLOG_INFO("vHost Device '%s' (%ld) has been removed", > + VLOG_INFO("vHost Device '%s' (%lld) has been removed", > dev->ifname, dev->device_fh); > } > device_fh is defined as uint64_t. So printing format macro PRIu64 can be used. Otherwise looks good. Acked-by: Pravin B Shelar <pshelar@nicira.com>
> device_fh is defined as uint64_t. So printing format macro PRIu64 can be used. > Otherwise looks good. PRIu64 is better. Thanks. > > Acked-by: Pravin B Shelar <pshelar@nicira.com> Thanks, will push to master with this change.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e4e3d2c..e7eb526 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1785,13 +1785,13 @@ new_device(struct virtio_net *dev) ovs_mutex_unlock(&dpdk_mutex); if (!exists) { - VLOG_INFO("vHost Device '%s' (%ld) can't be added - name not found", + VLOG_INFO("vHost Device '%s' (%lld) can't be added - name not found", dev->ifname, dev->device_fh); return -1; } - VLOG_INFO("vHost Device '%s' (%ld) has been added", + VLOG_INFO("vHost Device '%s' (%lld) has been added", dev->ifname, dev->device_fh); return 0; } @@ -1830,7 +1830,7 @@ destroy_device(volatile struct virtio_net *dev) } ovs_mutex_unlock(&dpdk_mutex); - VLOG_INFO("vHost Device '%s' (%ld) has been removed", + VLOG_INFO("vHost Device '%s' (%lld) has been removed", dev->ifname, dev->device_fh); }
Those changes prevent compiler warnings. Signed-off-by: Andy Zhou <azhou@nicira.com> --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)