diff mbox

libgo patch committed: Kill sleep processes in testsuite

Message ID CAOyqgcXqxDHjW4xQO8qRr_Va_yXtf_0VuAodABfv--twzM4xNg@mail.gmail.com
State New
Headers show

Commit Message

Ian Lance Taylor Aug. 3, 2015, 6:23 p.m. UTC 
This patch from Andrew Wilkins kills off extra sleep processes when
running the libgo testsuite.  Otherwise, the sleep process would
continue after the test completes.  This doesn't affect the testsuite
but the extra sleep processes are not desirable.  Committed to
mainline.

Ian

Comments

Andreas Schwab Aug. 5, 2015, 8:58 a.m. UTC | #1 
PASS
kill: not enough arguments
FAIL: net
Makefile:4696: recipe for target 'net/check' failed
make[4]: *** [net/check] Error 1

$ cat net/check-testlog
PASS
kill: not enough arguments
FAIL: net
../../../libgo/testsuite/gotest: line 514: gotest-timeout: No such file or directory

Andreas.
Ian Lance Taylor Aug. 5, 2015, 1:47 p.m. UTC | #2 
[ + Andrew Wilkins ]

On Wed, Aug 5, 2015 at 1:58 AM, Andreas Schwab <schwab@suse.de> wrote:
> PASS
> kill: not enough arguments
> FAIL: net
> Makefile:4696: recipe for target 'net/check' failed
> make[4]: *** [net/check] Error 1
>
> $ cat net/check-testlog
> PASS
> kill: not enough arguments
> FAIL: net
> ../../../libgo/testsuite/gotest: line 514: gotest-timeout: No such file or directory
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>
> --
> You received this message because you are subscribed to the Google Groups "gofrontend-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to gofrontend-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
diff mbox

Patch

Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 226525)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@ 
-d5aad2f400a0f21724e33e4ae48e1583ed8b1a87
+33d59eff1bd5de29f1fbde3b7625db28595835fd
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/testsuite/gotest
===================================================================
--- libgo/testsuite/gotest	(revision 226510)
+++ libgo/testsuite/gotest	(working copy)
@@ -518,7 +518,7 @@  xno)
 		wait $pid
 		status=$?
 		if ! test -f gotest-timeout; then
-		    kill $alarmpid
+		    ps -o pid,ppid | grep " $alarmpid" | cut -f1 -d" " | xargs kill -9
 		fi
 	else
 		if test "$trace" = "true"; then