Message ID | 4B62ABC8.7080607@gmail.com |
---|---|
State | Accepted |
Commit | 0040476b0efa99ad0d4ffb81d8e882095420d288 |
Headers | show |
On Fri, 2010-01-29 at 10:35 +0100, Roel Kluin wrote: > The error return should be negative > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > drivers/mtd/mtdchar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Pushed to l2-mtd-2.6.git/master
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c index 5b081cb..01d5837 100644 --- a/drivers/mtd/mtdchar.c +++ b/drivers/mtd/mtdchar.c @@ -373,7 +373,7 @@ static int mtd_do_writeoob(struct file *file, struct mtd_info *mtd, if (!mtd->write_oob) ret = -EOPNOTSUPP; else - ret = access_ok(VERIFY_READ, ptr, length) ? 0 : EFAULT; + ret = access_ok(VERIFY_READ, ptr, length) ? 0 : -EFAULT; if (ret) return ret;
The error return should be negative Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- drivers/mtd/mtdchar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)