Message ID | 1433302122-27397-3-git-send-email-bsd@redhat.com |
---|---|
State | New |
Headers | show |
Patch is fine, but the commit message shouldn't be just one long line. Suggest: monitor: Point to "help" command on syntax error When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP. Signed-off-by: Bandan Das <bsd@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Missed that in my original review, sorry.
diff --git a/monitor.c b/monitor.c index a89cbbb..6777cbe 100644 --- a/monitor.c +++ b/monitor.c @@ -4134,6 +4134,8 @@ static void handle_user_command(Monitor *mon, const char *cmdline) qdict = monitor_parse_arguments(mon, &cmdline, cmd); if (!qdict) { + monitor_printf(mon, "Try \"help %s\" for more information\n", + cmd->name); return; }