| Message ID | 20100112134153.27117.59960.stgit@firesoul.comx.local |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jesper Dangaard Brouer <hawk@comx.dk> Date: Tue, 12 Jan 2010 14:41:53 +0100 > Network driver igb: Improve the accuracy of stats in /proc/net/dev, by > updating the adapter stats when reading /proc/net/dev. Currently the > stats are updated by the watchdog timer every 2 sec, or when getting > stats via ethtool -S. > > A number of userspace apps read these /proc/net/dev stats every second, > e.g. ifstat, which then gives a perceived very bursty traffic pattern, > which is actually false. > > Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> Intel folks, I assume you guys are going to integrate this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 13, 2010 at 17:30, David Miller <davem@davemloft.net> wrote: > From: Jesper Dangaard Brouer <hawk@comx.dk> > Date: Tue, 12 Jan 2010 14:41:53 +0100 > >> Network driver igb: Improve the accuracy of stats in /proc/net/dev, by >> updating the adapter stats when reading /proc/net/dev. Currently the >> stats are updated by the watchdog timer every 2 sec, or when getting >> stats via ethtool -S. >> >> A number of userspace apps read these /proc/net/dev stats every second, >> e.g. ifstat, which then gives a perceived very bursty traffic pattern, >> which is actually false. >> >> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> > > Intel folks, I assume you guys are going to integrate this. > > Thanks. > -- Correct, I have sucked this into my queue of patches.
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index d967949..7207dd3 100644 --- a/drivers/net/igb/igb_main.c +++ b/drivers/net/igb/igb_main.c @@ -3862,11 +3862,17 @@ static void igb_reset_task(struct work_struct *work) * @netdev: network interface device structure * * Returns the address of the device statistics structure. - * The statistics are actually updated from the timer callback. + * The statistics are also updated from the timer callback + * igb_watchdog_task(). **/ static struct net_device_stats *igb_get_stats(struct net_device *netdev) { - /* only return the current stats */ + struct igb_adapter *adapter = netdev_priv(netdev); + + /* update stats */ + igb_update_stats(adapter); + + /* return the current stats */ return &netdev->stats; } @@ -3940,7 +3946,7 @@ static int igb_change_mtu(struct net_device *netdev, int new_mtu) void igb_update_stats(struct igb_adapter *adapter) { - struct net_device_stats *net_stats = igb_get_stats(adapter->netdev); + struct net_device_stats *net_stats = &adapter->netdev->stats; struct e1000_hw *hw = &adapter->hw; struct pci_dev *pdev = adapter->pdev; u32 rnbc;
Network driver igb: Improve the accuracy of stats in /proc/net/dev, by updating the adapter stats when reading /proc/net/dev. Currently the stats are updated by the watchdog timer every 2 sec, or when getting stats via ethtool -S. A number of userspace apps read these /proc/net/dev stats every second, e.g. ifstat, which then gives a perceived very bursty traffic pattern, which is actually false. Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> --- drivers/net/igb/igb_main.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html