Message ID | 201001070301.58260.PeterHuewe@gmx.de |
---|---|
State | Accepted |
Commit | 2d6bfc261a02662ec7a3a78df3e05e453e8b168d |
Headers | show |
On Wednesday, January 06, 2010 7:02 PM, Peter Hüwe wrote: > From: Peter Huewe <peterhuewe@gmx.de> > Date: Thu, 7 Jan 2010 02:51:13 +0100 > > This patch fixes a build failure[1] introduced by the patch > mtd: orion_nand.c: add error handling and use resource_size() > by H Hartley Sweeten [2] > The patch assigns something to a undeclared variable 'err', whereas the > rest of the code uses 'ret' for this task. > > This patch fixes this typo and thus removes the build failure. > > References: > [1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/ > [2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984 > > Patch against linux-next of Do 7. Jan 02:58:41 CET 2010 > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > --- > drivers/mtd/nand/orion_nand.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c > index 9903460..f16050c 100644 > --- a/drivers/mtd/nand/orion_nand.c > +++ b/drivers/mtd/nand/orion_nand.c > @@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) { > - err = -ENODEV; > + ret = -ENODEV; > goto no_res; > } Sorry about that. Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Hello, > > This patch fixes a build failure[1] introduced by the patch > > mtd: orion_nand.c: add error handling and use resource_size() > > by H Hartley Sweeten [2] > > The patch assigns something to a undeclared variable 'err', whereas the > > rest of the code uses 'ret' for this task. > > > > This patch fixes this typo and thus removes the build failure. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c index 9903460..f16050c 100644 --- a/drivers/mtd/nand/orion_nand.c +++ b/drivers/mtd/nand/orion_nand.c @@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) { - err = -ENODEV; + ret = -ENODEV; goto no_res; }