Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/993203/?format=api
{ "id": 993203, "url": "http://patchwork.ozlabs.org/api/patches/993203/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1541290645-25033-1-git-send-email-bobbyeshleman@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1541290645-25033-1-git-send-email-bobbyeshleman@gmail.com>", "list_archive_url": null, "date": "2018-11-04T00:17:19", "name": "e1000e: Change watchdog task to be delayed work", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "27dba9999acd8a1f545f8f6f7361483e746204f4", "submitter": { "id": 75256, "url": "http://patchwork.ozlabs.org/api/people/75256/?format=api", "name": "Robert Eshleman", "email": "bobbyeshleman@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1541290645-25033-1-git-send-email-bobbyeshleman@gmail.com/mbox/", "series": [ { "id": 74124, "url": "http://patchwork.ozlabs.org/api/series/74124/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=74124", "date": "2018-11-04T00:17:19", "name": "e1000e: Change watchdog task to be delayed work", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/74124/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/993203/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/993203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Q0Iawrr6\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42pcxg5ZRtz9sDJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 6 Nov 2018 03:06:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AA1AA86841;\n\tMon, 5 Nov 2018 16:06:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bT9T+qHFdcXE; Mon, 5 Nov 2018 16:06:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B4F05859D6;\n\tMon, 5 Nov 2018 16:06:44 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id AF9801C16D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 4 Nov 2018 00:17:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AC5BF85E24\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 4 Nov 2018 00:17:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TvQ0sUTJ_LLG for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 4 Nov 2018 00:17:46 +0000 (UTC)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8561685A96\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 4 Nov 2018 00:17:46 +0000 (UTC)", "by mail-pl1-f195.google.com with SMTP id b5-v6so2682648pla.6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 03 Nov 2018 17:17:46 -0700 (PDT)", "from emca-Inspiron-3558 ([2603:3004:c:2200:79c7:ed8e:b2dc:2f5d])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10-v6sm79716933pfg.180.2018.11.03.17.17.45\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 03 Nov 2018 17:17:45 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=lyTd4RClOG1ERM4t9WNz5RF4niw9++b2uh1j47Xf6xQ=;\n\tb=Q0Iawrr6uBFldI8Jw0jUBA5OKzqOlbBPcLvH5bYEUKCGThs5CKwN+bQAwYaZxdDQkl\n\tQf1vmyFNJg2YI5PMPb0yuJIg6M5ZRFubAICyfSGWgSIc90EqTS7O3v6Ksa6zmN6Hanr6\n\tzt74qKo61RzP+ElUiLhX7HhDloc0e7963vRRcG1U0HWSM+vcEAOvu4+YqnObQW2jjesm\n\to73UYrF987roZPlSm41Qt3K94noVChunm1B7msp3aluBKC4Zd0vbSkFD8gxR+GPhJKDY\n\tfh5lddcTRA5rOXzvid9/k4R9r2+bUtM5asg6F1ckyKKigSxH0kx3zfKlwcyU65Toc8Vr\n\tJbmA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=lyTd4RClOG1ERM4t9WNz5RF4niw9++b2uh1j47Xf6xQ=;\n\tb=G2D0QoH+DhBAk0AHUSWtd4DlJ+JmcW54cQP8akNogdMy//Bry1yV2uEnEa7588bAUp\n\tsxk8lykrYho/2u2SETJ4aokZIVczC9RmlOut2LjQfUtO38jfmlu+74qgJNY5sBwlgvz1\n\t0RfMUKuAuiv9TDn8KOAjDCPLwHx/h45RvYFnwhMkiFfQsxrf0dKHBpceWF+fQt0Nt/Gd\n\tUFjjbFOVTpapp2gtkAkhLosDpiCKxbCiyRSIt/OS64ixm77XgpzeMTvuSsM+z70QBjpi\n\tmbExIuiL1NnDF10oPKebfoqpg3AGfChs0nemQCYmYP5sYGqBWy2oVV/A6LegLxP5t4R9\n\tpOZw==", "X-Gm-Message-State": "AGRZ1gKZmE/upm8E1LJckgI3fxvoc8l9/pmxuNo999ctVG/QaLC20e9o\n\tTmNlmwTIC6FS0taAoDSH9s0=", "X-Google-Smtp-Source": "AJdET5fZlDtPTDWJ6OnTAIE8SETuOuntwuThcTEr0UPhb3CNMrHsWaivTFG5/GuoR3J4qzgdOPCR7w==", "X-Received": "by 2002:a17:902:4827:: with SMTP id\n\ts36-v6mr6989910pld.226.1541290665763; \n\tSat, 03 Nov 2018 17:17:45 -0700 (PDT)", "From": "Robert Eshleman <bobbyeshleman@gmail.com>", "To": "", "Date": "Sat, 3 Nov 2018 17:17:19 -0700", "Message-Id": "<1541290645-25033-1-git-send-email-bobbyeshleman@gmail.com>", "X-Mailer": "git-send-email 2.7.4", "X-Mailman-Approved-At": "Mon, 05 Nov 2018 16:06:13 +0000", "Subject": "[Intel-wired-lan] [PATCH] e1000e: Change watchdog task to be\n\tdelayed work", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Robert Eshleman <bobbyeshleman@gmail.com>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\t\"David S. Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This completes a pending TODO to use queue_delayed_work() instead of\nschedule_work().\n\nSigned-off-by: Robert Eshleman <bobbyeshleman@gmail.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 16a73bd..a387b21 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -39,6 +39,8 @@ static int debug = -1;\n module_param(debug, int, 0);\n MODULE_PARM_DESC(debug, \"Debug level (0=none,...,16=all)\");\n \n+struct workqueue_struct *e1000e_workqueue;\n+\n static const struct e1000_info *e1000_info_tbl[] = {\n \t[board_82571]\t\t= &e1000_82571_info,\n \t[board_82572]\t\t= &e1000_82572_info,\n@@ -5137,9 +5139,9 @@ static void e1000_watchdog(struct timer_list *t)\n \tstruct e1000_adapter *adapter = from_timer(adapter, t, watchdog_timer);\n \n \t/* Do the rest outside of interrupt context */\n-\tschedule_work(&adapter->watchdog_task);\n+\tstruct delayed_work *dwork = to_delayed_work(&adapter->watchdog_task);\n \n-\t/* TODO: make this use queue_delayed_work() */\n+\tqueue_delayed_work(e1000e_workqueue, dwork, 1);\n }\n \n static void e1000_watchdog_task(struct work_struct *work)\n@@ -7572,6 +7574,13 @@ static int __init e1000_init_module(void)\n \t\te1000e_driver_version);\n \tpr_info(\"Copyright(c) 1999 - 2015 Intel Corporation.\\n\");\n \n+\te1000e_workqueue = alloc_workqueue(\"%s\", WQ_MEM_RECLAIM, 0,\n+\t\t\t\t\t e1000e_driver_name);\n+\tif (!e1000e_workqueue) {\n+\t\tpr_err(\"%s: Failed to create workqueue\\n\", e1000e_driver_name);\n+\t\treturn -ENOMEM;\n+\t}\n+\n \treturn pci_register_driver(&e1000_driver);\n }\n module_init(e1000_init_module);\n@@ -7585,6 +7594,7 @@ module_init(e1000_init_module);\n static void __exit e1000_exit_module(void)\n {\n \tpci_unregister_driver(&e1000_driver);\n+\tdestroy_workqueue(e1000e_workqueue);\n }\n module_exit(e1000_exit_module);\n \n", "prefixes": [] }