Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/990131/?format=api
{ "id": 990131, "url": "http://patchwork.ozlabs.org/api/patches/990131/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20181029165418.6326-1-pankaj.bansal@nxp.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181029165418.6326-1-pankaj.bansal@nxp.com>", "list_archive_url": null, "date": "2018-10-29T11:28:26", "name": "[U-Boot,v2] armv8: fsl-layerscape: reorder rgmii dpmacs' enablement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bdf6db211a487972d66dfb0db64fac03c0bd2b09", "submitter": { "id": 72787, "url": "http://patchwork.ozlabs.org/api/people/72787/?format=api", "name": "Pankaj Bansal", "email": "pankaj.bansal@nxp.com" }, "delegate": { "id": 2467, "url": "http://patchwork.ozlabs.org/api/users/2467/?format=api", "username": "prabhu_kush", "first_name": "Prabhakar", "last_name": "Kushwaha", "email": "prabhakar@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20181029165418.6326-1-pankaj.bansal@nxp.com/mbox/", "series": [ { "id": 72990, "url": "http://patchwork.ozlabs.org/api/series/72990/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=72990", "date": "2018-10-29T11:28:26", "name": "[U-Boot,v2] armv8: fsl-layerscape: reorder rgmii dpmacs' enablement", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/72990/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/990131/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/990131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"T4kCCKAx\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=pankaj.bansal@nxp.com; " ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 42kC6D1qXRz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 29 Oct 2018 22:28:47 +1100 (AEDT)", "by lists.denx.de (Postfix, from userid 105)\n\tid 2EF06C21FC1; Mon, 29 Oct 2018 11:28:39 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 61CEDC21F6A;\n\tMon, 29 Oct 2018 11:28:37 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid DCAE1C21F6A; Mon, 29 Oct 2018 11:28:35 +0000 (UTC)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10053.outbound.protection.outlook.com [40.107.1.53])\n\tby lists.denx.de (Postfix) with ESMTPS id 4F120C21E2B\n\tfor <u-boot@lists.denx.de>; Mon, 29 Oct 2018 11:28:35 +0000 (UTC)", "from HE1PR0402MB3323.eurprd04.prod.outlook.com (10.167.125.20) by\n\tHE1PR0402MB3420.eurprd04.prod.outlook.com (10.167.125.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1273.21; Mon, 29 Oct 2018 11:28:27 +0000", "from HE1PR0402MB3323.eurprd04.prod.outlook.com\n\t([fe80::7d5f:a551:3509:2414]) by\n\tHE1PR0402MB3323.eurprd04.prod.outlook.com\n\t([fe80::7d5f:a551:3509:2414%4]) with mapi id 15.20.1273.021;\n\tMon, 29 Oct 2018 11:28:26 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=n7vP1MJj47adVrFwNPppkVvk0+DxjQtVz4SsuWlZbsk=;\n\tb=T4kCCKAxnBD5QQYezsbfefQXi8mfjf0UxveUJb8QqLkQ86NOCbcdiuqF3R9+HboBDVaCHLzq2Pp6InDJb7OO3b9GkNrExY7Myer4ZUhZa9qMYQgGQh/NatFjshcWeU4KDgodeKwDo3IgXgxGzFEsvLkMu+4icsacdcu7xISWjgE=", "From": "Pankaj Bansal <pankaj.bansal@nxp.com>", "To": "York Sun <york.sun@nxp.com>", "Thread-Topic": "[PATCH v2] armv8: fsl-layerscape: reorder rgmii dpmacs'\n\tenablement", "Thread-Index": "AQHUb3qCaVQ14zAvEkysMH8OZ0pFFA==", "Date": "Mon, 29 Oct 2018 11:28:26 +0000", "Message-ID": "<20181029165418.6326-1-pankaj.bansal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "SG2PR02CA0095.apcprd02.prod.outlook.com\n\t(2603:1096:4:90::35) To HE1PR0402MB3323.eurprd04.prod.outlook.com\n\t(2603:10a6:7:81::20)", "authentication-results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=nxp.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"T4kCCKAx\";\n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=pankaj.bansal@nxp.com; " ], "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[14.143.30.134]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; HE1PR0402MB3420;\n\t6:CGPPUFAX8Qj+b/cTF4dAXcQR3HBr0uTwnvAFsT1XPA/F+zePtxap2ybDZIDuq7MsvEgqq+yhbguw5jW4b/dIucuSMqTKBlA6chblX/yJnvUaVzB7Vx7LUel8TR2EWB4GYQBPNGMkj4t+RrehJs+Ar8XzEVLyRsXfgzFLpS5iGJzPr6xphD9EOnotS0kUl8Q9MpnDAoJA3l1BMZbFjuEzWbADW/Mfo8Md1AprTt6HGxUtfiydxe6BUGu2oJi6SAqlO38j08PSMWCo0LkHvfdrInAog56JCyjfF795e74UwUP8u74Fkji7Fg9MttTrwAUNszeukP457rzGCOpUY+A92oTLb57DBQzZF9+aFcWeVOWLAI5okwCTgPzf6TZE9hNZ+pocHQc8zYAPEXYt6TLNqDBmGbsPTzGlhWidVeRppwfXLvzgjywrjgYwTRRJMd5/H+uto2UBN0UP+ZN+gsCLHg==;\n\t5:F/UGWuX3X3liLZHJ3QCkBrXG9M/m0r1dHCCgbyJomDQUar7lUntsuX+kIMbdkcPZ5rj17/vphIMPgs0F4qTDqFbnK3RwWqyvxmAFPg4nfgrAdrMBFRoNtq9uwojEQcZRWu1qnn3/FeDu2xd4IvVDxwk6DMcxhg//rSRohskomUo=;\n\t7:PcpSOEfyPRrK1eiDvKGaisMLrSGPWiYdCa7R2t+1ULnllah6hRLzscT/cTYa/rokNLKsueYZuJrW1JNwcC1IUZtJDAeTxHbXet+4g2L/rCsi0aNacGaRx3Y/WQnXqd1fLqN6KywFSuUnJNfx4ySuGg==", "x-ms-office365-filtering-correlation-id": "5b4510e1-e0d3-41d1-4d03-08d63d91a478", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:HE1PR0402MB3420; ", "x-ms-traffictypediagnostic": "HE1PR0402MB3420:", "x-microsoft-antispam-prvs": "<HE1PR0402MB3420FA7EA21F1E1AC3A6628EF1F30@HE1PR0402MB3420.eurprd04.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:(185117386973197);", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095);\n\tSRVR:HE1PR0402MB3420; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB3420; ", "x-forefront-prvs": "084080FC15", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(39860400002)(136003)(396003)(346002)(376002)(366004)(189003)(199004)(256004)(4326008)(6862004)(14454004)(476003)(186003)(25786009)(305945005)(105586002)(36756003)(106356001)(7736002)(2616005)(44832011)(2900100001)(486006)(66066001)(5250100002)(86362001)(97736004)(52116002)(99286004)(68736007)(81166006)(8676002)(81156014)(71190400001)(8936002)(71200400001)(53936002)(6636002)(26005)(6116002)(6486002)(316002)(5660300001)(3846002)(478600001)(37006003)(1076002)(54906003)(386003)(55236004)(6436002)(2906002)(6506007)(102836004)(6512007);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB3420;\n\tH:HE1PR0402MB3323.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "6MegSRAHrERCE34Rb9m/c8bPBCAEs3u3TbMk2Fvw+dMYr8f064JuzgUiGksJDpOLPwTC6aWgUQy7jMtA8coVl8FvTiVgWblfALwloZpXfdxNzbEyKJEQNFeIcb+o/EDOOw33zwlg6HxPUOFZqLLg18AKsRUKhvAt4yQ+EAk7a+i6KB/r7wNYR21o1yk28n4NspEtSlNRwq2Vn6SZ+9xNPRMtNL16CVXTEr1EyI2p76AmI5kBvChtPeaOv+nT0NTSyuIu7Jt/6X3pX/c5p8MNL8ofXEcg8iSE5Tlyxy6aME4p3P9C6wWtZeN7twRhSTK+8DtLsUGXL25p+1w0pSLoGCGhreSuu5DpXL7oZk6GPto=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5b4510e1-e0d3-41d1-4d03-08d63d91a478", "X-MS-Exchange-CrossTenant-originalarrivaltime": "29 Oct 2018 11:28:26.7680\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0402MB3420", "Cc": "\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>,\n\tSriram Dash <sriram.dash@nxp.com>, Wasim Khan <wasim.khan@nxp.com>,\n\tVarun Sethi <V.Sethi@nxp.com>", "Subject": "[U-Boot] [PATCH v2] armv8: fsl-layerscape: reorder rgmii dpmacs'\n\tenablement", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "some dpmacs in armv8a based freescale layerscape SOCs can be\nconfigured via both serdes(sgmii, xfi, xlaui etc) bits and via\nEC*_PMUX(rgmii) bits in RCW.\ne.g. dpmac 17 and 18 in LX2160A can be configured as SGMII from\nserdes bits and as RGMII via EC1_PMUX/EC2_PMUX bits\nNow if a dpmac is enabled by serdes bits then it takes precedence\nover EC*_PMUX bits. i.e. in LX2160A if we select serdes protocol\nthat configures dpmac17 as SGMII and set the EC1_PMUX as RGMII,\nthen the dpmac is SGMII and not RGMII.\n\nTherefore, move the fsl_rgmii_init after fsl_serdes_init. in\nfsl_rgmii_init function of SOC, we will check if the dpmac is enabled\nor not? if it is (fsl_serdes_init has already enabled the dpmac), then\ndon't enable it.\n\nSigned-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>\n---\n\nNotes:\n V2:\n - as per review comments, add commit message as inline comments.\n\n arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 22 ++++++++++++++++++----\n 1 file changed, 18 insertions(+), 4 deletions(-)", "diff": "diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c\nindex 052e0708d4..3fe7f885e8 100644\n--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c\n+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c\n@@ -553,15 +553,29 @@ int arch_early_init_r(void)\n \t\t\tprintf(\"Did not wake secondary cores\\n\");\n \t}\n \n-#ifdef CONFIG_SYS_FSL_HAS_RGMII\n-\tfsl_rgmii_init();\n-#endif\n-\n \tconfig_core_prefetch();\n \n #ifdef CONFIG_SYS_HAS_SERDES\n \tfsl_serdes_init();\n #endif\n+#ifdef CONFIG_SYS_FSL_HAS_RGMII\n+\t/* some dpmacs in armv8a based freescale layerscape SOCs can be\n+\t * configured via both serdes(sgmii, xfi, xlaui etc) bits and via\n+\t * EC*_PMUX(rgmii) bits in RCW.\n+\t * e.g. dpmac 17 and 18 in LX2160A can be configured as SGMII from\n+\t * serdes bits and as RGMII via EC1_PMUX/EC2_PMUX bits\n+\t * Now if a dpmac is enabled by serdes bits then it takes precedence\n+\t * over EC*_PMUX bits. i.e. in LX2160A if we select serdes protocol\n+\t * that configures dpmac17 as SGMII and set the EC1_PMUX as RGMII,\n+\t * then the dpmac is SGMII and not RGMII.\n+\t *\n+\t * Therefore, move the fsl_rgmii_init after fsl_serdes_init. in\n+\t * fsl_rgmii_init function of SOC, we will check if the dpmac is enabled\n+\t * or not? if it is (fsl_serdes_init has already enabled the dpmac),\n+\t * then don't enable it.\n+\t */\n+\tfsl_rgmii_init();\n+#endif\n #ifdef CONFIG_FMAN_ENET\n \tfman_enet_init();\n #endif\n", "prefixes": [ "U-Boot", "v2" ] }