Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989788/?format=api
{ "id": 989788, "url": "http://patchwork.ozlabs.org/api/patches/989788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-1-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026213333.51495-1-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-10-26T21:33:28", "name": "[next,S98,1/6] i40e: don't restart nway if autoneg not supported", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b8ade27b27f645ef7531274789f227256756f45c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-1-alice.michael@intel.com/mbox/", "series": [ { "id": 72818, "url": "http://patchwork.ozlabs.org/api/series/72818/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72818", "date": "2018-10-26T21:33:30", "name": "[next,S98,1/6] i40e: don't restart nway if autoneg not supported", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72818/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989788/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hchB68s7z9s8F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 08:34:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7E4AB88CCF;\n\tFri, 26 Oct 2018 21:34:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MjuHumnvNReB; Fri, 26 Oct 2018 21:34:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5911988C7B;\n\tFri, 26 Oct 2018 21:34:14 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6FEF41BF30B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6B86724D9D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c-3K1rSfVnEC for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:06 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8D2D522049\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:06 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 14:34:06 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 14:34:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,429,1534834800\"; d=\"scan'208\";a=\"81228147\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 14:33:28 -0700", "Message-Id": "<20181026213333.51495-1-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Intel-wired-lan] [next PATCH S98 1/6] i40e: don't restart nway if\n\tautoneg not supported", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nOn link types that do not support autoneg, we cannot attempt to restart\nnway negotiation. This results in a dead link that requires a power\ncycle to remedy.\n\nFix this by saving off the autoneg state and checking this value before\nwe try to restart nway.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 9f8464f..71db006 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1335,6 +1335,7 @@ static int i40e_set_pauseparam(struct net_device *netdev,\n \ti40e_status status;\n \tu8 aq_failures;\n \tint err = 0;\n+\tu32 is_an;\n \n \t/* Changing the port's flow control is not supported if this isn't the\n \t * port's controlling PF\n@@ -1347,15 +1348,14 @@ static int i40e_set_pauseparam(struct net_device *netdev,\n \tif (vsi != pf->vsi[pf->lan_vsi])\n \t\treturn -EOPNOTSUPP;\n \n-\tif (pause->autoneg != ((hw_link_info->an_info & I40E_AQ_AN_COMPLETED) ?\n-\t AUTONEG_ENABLE : AUTONEG_DISABLE)) {\n+\tis_an = hw_link_info->an_info & I40E_AQ_AN_COMPLETED;\n+\tif (pause->autoneg != is_an) {\n \t\tnetdev_info(netdev, \"To change autoneg please use: ethtool -s <dev> autoneg <on|off>\\n\");\n \t\treturn -EOPNOTSUPP;\n \t}\n \n \t/* If we have link and don't have autoneg */\n-\tif (!test_bit(__I40E_DOWN, pf->state) &&\n-\t !(hw_link_info->an_info & I40E_AQ_AN_COMPLETED)) {\n+\tif (!test_bit(__I40E_DOWN, pf->state) && !is_an) {\n \t\t/* Send message that it might not necessarily work*/\n \t\tnetdev_info(netdev, \"Autoneg did not complete so changing settings may not result in an actual change.\\n\");\n \t}\n@@ -1406,7 +1406,7 @@ static int i40e_set_pauseparam(struct net_device *netdev,\n \t\terr = -EAGAIN;\n \t}\n \n-\tif (!test_bit(__I40E_DOWN, pf->state)) {\n+\tif (!test_bit(__I40E_DOWN, pf->state) && is_an) {\n \t\t/* Give it a little more time to try to come back */\n \t\tmsleep(75);\n \t\tif (!test_bit(__I40E_DOWN, pf->state))\n", "prefixes": [ "next", "S98", "1/6" ] }