Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989785/?format=api
{ "id": 989785, "url": "http://patchwork.ozlabs.org/api/patches/989785/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-4-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026213333.51495-4-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-10-26T21:33:31", "name": "[next,S98,4/6] virtchnl: Fix off by one error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "997f8040384e8f27e33e648c38e2ead2ee419766", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-4-alice.michael@intel.com/mbox/", "series": [ { "id": 72818, "url": "http://patchwork.ozlabs.org/api/series/72818/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72818", "date": "2018-10-26T21:33:30", "name": "[next,S98,1/6] i40e: don't restart nway if autoneg not supported", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72818/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989785/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989785/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hch80FqVz9sDT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 08:34:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6296625CE1;\n\tFri, 26 Oct 2018 21:34:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rGljQshkxAc4; Fri, 26 Oct 2018 21:34:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id D988C23A18;\n\tFri, 26 Oct 2018 21:34:13 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id B8BEB1BF30B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B5E5125D30\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:10 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4lJeUTuXWtvY for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:06 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C3124259FF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:06 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 14:34:06 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 14:34:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,429,1534834800\"; d=\"scan'208\";a=\"81228156\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 14:33:31 -0700", "Message-Id": "<20181026213333.51495-4-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20181026213333.51495-1-alice.michael@intel.com>", "References": "<20181026213333.51495-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S98 4/6] virtchnl: Fix off by one\n\terror", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When calculating the valid length for a VIRTCHNL_OP_ENABLE_CHANNELS\nmessage, we accidentally allowed messages with one extra\nvirtchnl_channel_info structure on the end. This happened due\nto an off by one error, because we forgot that valid_len already\naccounted for one virtchnl_channel_info structure, so we need to\nsubtract one from the num_tc value.\n\nSigned-off-by: Alice Michael <alice.michael@intel.com>\n---\n include/linux/avf/virtchnl.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h\nindex 3130dec..7605b59 100644\n--- a/include/linux/avf/virtchnl.h\n+++ b/include/linux/avf/virtchnl.h\n@@ -819,8 +819,8 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,\n \t\tif (msglen >= valid_len) {\n \t\t\tstruct virtchnl_tc_info *vti =\n \t\t\t\t(struct virtchnl_tc_info *)msg;\n-\t\t\tvalid_len += vti->num_tc *\n-\t\t\t\tsizeof(struct virtchnl_channel_info);\n+\t\t\tvalid_len += (vti->num_tc - 1) *\n+\t\t\t\t sizeof(struct virtchnl_channel_info);\n \t\t\tif (vti->num_tc == 0)\n \t\t\t\terr_msg_format = true;\n \t\t}\n", "prefixes": [ "next", "S98", "4/6" ] }