Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989784/?format=api
{ "id": 989784, "url": "http://patchwork.ozlabs.org/api/patches/989784/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-6-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026213333.51495-6-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-10-26T21:33:33", "name": "[next,S98,6/6] i40e: suppress bogus error message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c55934e5d1ced43020cd21fe8609e9653e2db832", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026213333.51495-6-alice.michael@intel.com/mbox/", "series": [ { "id": 72818, "url": "http://patchwork.ozlabs.org/api/series/72818/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72818", "date": "2018-10-26T21:33:30", "name": "[next,S98,1/6] i40e: don't restart nway if autoneg not supported", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72818/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989784/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989784/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hch76Cs8z9sDK\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 08:34:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1DFEC876C5;\n\tFri, 26 Oct 2018 21:34:14 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1RyXsy5maT3r; Fri, 26 Oct 2018 21:34:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A3417870E3;\n\tFri, 26 Oct 2018 21:34:13 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5B51E1BF30B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 551D624D9D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:10 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qEbOQupYHipy for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:10 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F040225D10\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 21:34:06 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 14:34:06 -0700", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 14:34:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,429,1534834800\"; d=\"scan'208\";a=\"81228162\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 14:33:33 -0700", "Message-Id": "<20181026213333.51495-6-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20181026213333.51495-1-alice.michael@intel.com>", "References": "<20181026213333.51495-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S98 6/6] i40e: suppress bogus error\n\tmessage", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThe i40e driver complains about unprivileged VFs trying to configure\npromiscuous mode each time a VF reset occurs. This isn't the fault of\nthe poor VF driver - the PF driver itself is making the request.\n\nTo fix this, skip the privilege check if the request is to disable all\npromiscuous activity. This gets rid of the bogus message, but doesn't\naffect privilege checks, since we really only care if the unprivileged\nVF is trying to enable promiscuous mode.\n\nTesting Hints (required if no HSD): watch dmesg log while VF resets\noccur. You can trigger a VFR by unloading i40evf or shutting down the VM\nwith an assigned VF.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex ac5698e..c41e8ad 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1112,7 +1112,8 @@ static i40e_status i40e_config_vf_promiscuous_mode(struct i40e_vf *vf,\n \tif (!i40e_vc_isvalid_vsi_id(vf, vsi_id) || !vsi)\n \t\treturn I40E_ERR_PARAM;\n \n-\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) {\n+\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps) &&\n+\t (allmulti || alluni)) {\n \t\tdev_err(&pf->pdev->dev,\n \t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n \t\t\tvf->vf_id);\n", "prefixes": [ "next", "S98", "6/6" ] }