Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989741/?format=api
{ "id": 989741, "url": "http://patchwork.ozlabs.org/api/patches/989741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-16-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026184447.13547-16-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-10-26T18:44:47", "name": "[S9,15/15] ice: Use Tx|Rx in comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a76d380d0d13c2d4c9d197218b994ae2f4846f1b", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-16-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 72801, "url": "http://patchwork.ozlabs.org/api/series/72801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72801", "date": "2018-10-26T18:44:32", "name": "Bug fixes for ice, set 2/2", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72801/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hXws3HxSz9sDX\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 05:45:00 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9EB4686265;\n\tFri, 26 Oct 2018 18:44:59 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HKt6NIdJbJWC; Fri, 26 Oct 2018 18:44:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8FF198774C;\n\tFri, 26 Oct 2018 18:44:55 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 609051BF30E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5B49D88642\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LZbXzKp3zGME for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4F26588640\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 11:44:47 -0700", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Oct 2018 11:44:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,428,1534834800\"; d=\"scan'208\";a=\"269078864\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 11:44:47 -0700", "Message-Id": "<20181026184447.13547-16-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "References": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S9 15/15] ice: Use Tx|Rx in comments", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In code comments, use Tx|Rx instead of tx|rx\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice.h | 20 ++++++++++----------\n drivers/net/ethernet/intel/ice/ice_common.c | 6 +++---\n drivers/net/ethernet/intel/ice/ice_controlq.c | 1 -\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 12 ++++++------\n drivers/net/ethernet/intel/ice/ice_lib.c | 8 ++++----\n drivers/net/ethernet/intel/ice/ice_main.c | 2 +-\n drivers/net/ethernet/intel/ice/ice_sched.c | 6 +++---\n drivers/net/ethernet/intel/ice/ice_switch.c | 8 ++++----\n drivers/net/ethernet/intel/ice/ice_txrx.c | 21 +++++++++++----------\n 9 files changed, 42 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h\nindex 60b2e0c9faf5..a385575600f6 100644\n--- a/drivers/net/ethernet/intel/ice/ice.h\n+++ b/drivers/net/ethernet/intel/ice/ice.h\n@@ -96,14 +96,14 @@ extern const char ice_drv_ver[];\n #define ice_for_each_vsi(pf, i) \\\n \tfor ((i) = 0; (i) < (pf)->num_alloc_vsi; (i)++)\n \n-/* Macros for each tx/rx ring in a VSI */\n+/* Macros for each Tx/Rx ring in a VSI */\n #define ice_for_each_txq(vsi, i) \\\n \tfor ((i) = 0; (i) < (vsi)->num_txq; (i)++)\n \n #define ice_for_each_rxq(vsi, i) \\\n \tfor ((i) = 0; (i) < (vsi)->num_rxq; (i)++)\n \n-/* Macros for each allocated tx/rx ring whether used or not in a VSI */\n+/* Macros for each allocated Tx/Rx ring whether used or not in a VSI */\n #define ice_for_each_alloc_txq(vsi, i) \\\n \tfor ((i) = 0; (i) < (vsi)->alloc_txq; (i)++)\n \n@@ -183,8 +183,8 @@ struct ice_vsi {\n \tstruct ice_sw *vsw;\t\t /* switch this VSI is on */\n \tstruct ice_pf *back;\t\t /* back pointer to PF */\n \tstruct ice_port_info *port_info; /* back pointer to port_info */\n-\tstruct ice_ring **rx_rings;\t /* rx ring array */\n-\tstruct ice_ring **tx_rings;\t /* tx ring array */\n+\tstruct ice_ring **rx_rings;\t /* Rx ring array */\n+\tstruct ice_ring **tx_rings;\t /* Tx ring array */\n \tstruct ice_q_vector **q_vectors; /* q_vector array */\n \n \tirqreturn_t (*irq_handler)(int irq, void *data);\n@@ -255,8 +255,8 @@ struct ice_q_vector {\n \tstruct ice_ring_container tx;\n \tstruct irq_affinity_notify affinity_notify;\n \tu16 v_idx;\t\t\t/* index in the vsi->q_vector array. */\n-\tu8 num_ring_tx;\t\t\t/* total number of tx rings in vector */\n-\tu8 num_ring_rx;\t\t\t/* total number of rx rings in vector */\n+\tu8 num_ring_tx;\t\t\t/* total number of Tx rings in vector */\n+\tu8 num_ring_rx;\t\t\t/* total number of Rx rings in vector */\n \tchar name[ICE_INT_NAME_STR_LEN];\n \t/* in usecs, need to use ice_intrl_to_usecs_reg() before writing this\n \t * value to the device\n@@ -308,10 +308,10 @@ struct ice_pf {\n \tu32 hw_oicr_idx;\t/* Other interrupt cause vector HW index */\n \tu32 num_avail_hw_msix;\t/* remaining HW MSIX vectors left unclaimed */\n \tu32 num_lan_msix;\t/* Total MSIX vectors for base driver */\n-\tu16 num_lan_tx;\t\t/* num lan tx queues setup */\n-\tu16 num_lan_rx;\t\t/* num lan rx queues setup */\n-\tu16 q_left_tx;\t\t/* remaining num tx queues left unclaimed */\n-\tu16 q_left_rx;\t\t/* remaining num rx queues left unclaimed */\n+\tu16 num_lan_tx;\t\t/* num lan Tx queues setup */\n+\tu16 num_lan_rx;\t\t/* num lan Rx queues setup */\n+\tu16 q_left_tx;\t\t/* remaining num Tx queues left unclaimed */\n+\tu16 q_left_rx;\t\t/* remaining num Rx queues left unclaimed */\n \tu16 next_vsi;\t\t/* Next free slot in pf->vsi[] - 0-based! */\n \tu16 num_alloc_vsi;\n \tu16 corer_count;\t/* Core reset count */\ndiff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex b3d73be9f649..4c1d35da940d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -713,7 +713,7 @@ enum ice_status ice_init_hw(struct ice_hw *hw)\n \n \thw->evb_veb = true;\n \n-\t/* Query the allocated resources for tx scheduler */\n+\t/* Query the allocated resources for Tx scheduler */\n \tstatus = ice_sched_query_res_alloc(hw);\n \tif (status) {\n \t\tice_debug(hw, ICE_DBG_SCHED,\n@@ -956,7 +956,7 @@ enum ice_status ice_reset(struct ice_hw *hw, enum ice_reset_req req)\n * ice_copy_rxq_ctx_to_hw\n * @hw: pointer to the hardware structure\n * @ice_rxq_ctx: pointer to the rxq context\n- * @rxq_index: the index of the rx queue\n+ * @rxq_index: the index of the Rx queue\n *\n * Copies rxq context from dense structure to hw register space\n */\n@@ -1012,7 +1012,7 @@ static const struct ice_ctx_ele ice_rlan_ctx_info[] = {\n * ice_write_rxq_ctx\n * @hw: pointer to the hardware structure\n * @rlan_ctx: pointer to the rxq context\n- * @rxq_index: the index of the rx queue\n+ * @rxq_index: the index of the Rx queue\n *\n * Converts rxq context from sparse to dense structure and then writes\n * it to hw register space\ndiff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c\nindex 1831771a7969..2bf5e11f559a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_controlq.c\n+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c\n@@ -591,7 +591,6 @@ static enum ice_status ice_init_check_adminq(struct ice_hw *hw)\n * - cq->num_rq_entries\n * - cq->rq_buf_size\n * - cq->sq_buf_size\n- *\n */\n static enum ice_status ice_init_ctrlq(struct ice_hw *hw, enum ice_ctl_q q_type)\n {\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 990d660f527a..3b6e387f5440 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -260,10 +260,10 @@ static int ice_get_sset_count(struct net_device *netdev, int sset)\n \t\t * a private ethtool flag). This is due to the nature of the\n \t\t * ethtool stats API.\n \t\t *\n-\t\t * User space programs such as ethtool must make 3 separate\n+\t\t * Userspace programs such as ethtool must make 3 separate\n \t\t * ioctl requests, one for size, one for the strings, and\n \t\t * finally one for the stats. Since these cross into\n-\t\t * user space, changes to the number or size could result in\n+\t\t * userspace, changes to the number or size could result in\n \t\t * undefined memory access or incorrect string<->value\n \t\t * correlations for statistics.\n \t\t *\n@@ -1441,7 +1441,7 @@ ice_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n /**\n * ice_set_pauseparam - Set Flow Control parameter\n * @netdev: network interface device structure\n- * @pause: return tx/rx flow control status\n+ * @pause: return Tx/Rx flow control status\n */\n static int\n ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n@@ -1543,7 +1543,7 @@ static u32 ice_get_rxfh_key_size(struct net_device __always_unused *netdev)\n }\n \n /**\n- * ice_get_rxfh_indir_size - get the rx flow hash indirection table size\n+ * ice_get_rxfh_indir_size - get the Rx flow hash indirection table size\n * @netdev: network interface device structure\n *\n * Returns the table size.\n@@ -1556,7 +1556,7 @@ static u32 ice_get_rxfh_indir_size(struct net_device *netdev)\n }\n \n /**\n- * ice_get_rxfh - get the rx flow hash indirection table\n+ * ice_get_rxfh - get the Rx flow hash indirection table\n * @netdev: network interface device structure\n * @indir: indirection table\n * @key: hash key\n@@ -1603,7 +1603,7 @@ ice_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc)\n }\n \n /**\n- * ice_set_rxfh - set the rx flow hash indirection table\n+ * ice_set_rxfh - set the Rx flow hash indirection table\n * @netdev: network interface device structure\n * @indir: indirection table\n * @key: hash key\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 534221d80200..29b1dcfd4331 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -20,7 +20,7 @@ static int ice_setup_rx_ctx(struct ice_ring *ring)\n \tu16 pf_q;\n \tint err;\n \n-\t/* what is RX queue number in global space of 2K Rx queues */\n+\t/* what is Rx queue number in global space of 2K Rx queues */\n \tpf_q = vsi->rxq_map[ring->q_index];\n \n \t/* clear the context structure first */\n@@ -1200,7 +1200,7 @@ static int ice_vsi_alloc_rings(struct ice_vsi *vsi)\n \tstruct ice_pf *pf = vsi->back;\n \tint i;\n \n-\t/* Allocate tx_rings */\n+\t/* Allocate Tx rings */\n \tfor (i = 0; i < vsi->alloc_txq; i++) {\n \t\tstruct ice_ring *ring;\n \n@@ -1219,7 +1219,7 @@ static int ice_vsi_alloc_rings(struct ice_vsi *vsi)\n \t\tvsi->tx_rings[i] = ring;\n \t}\n \n-\t/* Allocate rx_rings */\n+\t/* Allocate Rx rings */\n \tfor (i = 0; i < vsi->alloc_rxq; i++) {\n \t\tstruct ice_ring *ring;\n \n@@ -2333,7 +2333,7 @@ static int ice_search_res(struct ice_res_tracker *res, u16 needed, u16 id)\n \tint start = res->search_hint;\n \tint end = start;\n \n-\tif ((start + needed) > res->num_entries)\n+\tif ((start + needed) > res->num_entries)\n \t\treturn -ENOMEM;\n \n \tid |= ICE_RES_VALID_BIT;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 9f85d6534520..e45e57499d91 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1786,7 +1786,7 @@ static void ice_determine_q_usage(struct ice_pf *pf)\n \n \tpf->num_lan_tx = min_t(int, q_left_tx, num_online_cpus());\n \n-\t/* only 1 rx queue unless RSS is enabled */\n+\t/* only 1 Rx queue unless RSS is enabled */\n \tif (!test_bit(ICE_FLAG_RSS_ENA, pf->flags))\n \t\tpf->num_lan_rx = 1;\n \telse\ndiff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c\nindex b39484da5a7d..a1266ee95df4 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sched.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sched.c\n@@ -1337,7 +1337,7 @@ ice_sched_rm_vsi_child_nodes(struct ice_port_info *pi,\n * @num_nodes: pointer to num nodes array\n *\n * This function calculates the number of supported nodes needed to add this\n- * VSI into tx tree including the VSI, parent and intermediate nodes in below\n+ * VSI into Tx tree including the VSI, parent and intermediate nodes in below\n * layers\n */\n static void\n@@ -1374,13 +1374,13 @@ ice_sched_calc_vsi_support_nodes(struct ice_hw *hw,\n }\n \n /**\n- * ice_sched_add_vsi_support_nodes - add VSI supported nodes into tx tree\n+ * ice_sched_add_vsi_support_nodes - add VSI supported nodes into Tx tree\n * @pi: port information structure\n * @vsi_handle: software VSI handle\n * @tc_node: pointer to TC node\n * @num_nodes: pointer to num nodes array\n *\n- * This function adds the VSI supported nodes into tx tree including the\n+ * This function adds the VSI supported nodes into Tx tree including the\n * VSI, its parent and intermediate nodes in below layers\n */\n static enum ice_status\ndiff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex 286a1a7afdc2..091047f7ac02 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -827,7 +827,7 @@ ice_add_marker_act(struct ice_hw *hw, struct ice_fltr_mgmt_list_entry *m_ent,\n \t/* Create two back-to-back switch rules and submit them to the HW using\n \t * one memory buffer:\n \t * 1. Large Action\n-\t * 2. Look up tx rx\n+\t * 2. Look up Tx Rx\n \t */\n \tlg_act_size = (u16)ICE_SW_RULE_LG_ACT_SIZE(num_lg_acts);\n \trules_size = lg_act_size + ICE_SW_RULE_RX_TX_ETH_HDR_SIZE;\n@@ -871,7 +871,7 @@ ice_add_marker_act(struct ice_hw *hw, struct ice_fltr_mgmt_list_entry *m_ent,\n \n \tlg_act->pdata.lg_act.act[2] = cpu_to_le32(act);\n \n-\t/* call the fill switch rule to fill the lookup tx rx structure */\n+\t/* call the fill switch rule to fill the lookup Tx Rx structure */\n \tice_fill_sw_rule(hw, &m_ent->fltr_info, rx_tx,\n \t\t\t ice_aqc_opc_update_sw_rules);\n \n@@ -1168,8 +1168,8 @@ enum ice_status ice_update_sw_rule_bridge_mode(struct ice_hw *hw)\n * Call AQ command to add or update previously created VSI list with new VSI.\n *\n * Helper function to do book keeping associated with adding filter information\n- * The algorithm to do the booking keeping is described below :\n- * When a VSI needs to subscribe to a given filter( MAC/VLAN/Ethtype etc.)\n+ * The algorithm to do the book keeping is described below :\n+ * When a VSI needs to subscribe to a given filter (MAC/VLAN/Ethtype etc.)\n *\tif only one VSI has been added till now\n *\t\tAllocate a new VSI list and add two VSIs\n *\t\tto this list using switch rule command\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c\nindex 939510b7e8f3..4b92863b3500 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c\n@@ -219,7 +219,7 @@ static bool ice_clean_tx_irq(struct ice_vsi *vsi, struct ice_ring *tx_ring,\n \n /**\n * ice_setup_tx_ring - Allocate the Tx descriptors\n- * @tx_ring: the tx ring to set up\n+ * @tx_ring: the Tx ring to set up\n *\n * Return 0 on success, negative on error\n */\n@@ -324,7 +324,7 @@ void ice_free_rx_ring(struct ice_ring *rx_ring)\n \n /**\n * ice_setup_rx_ring - Allocate the Rx descriptors\n- * @rx_ring: the rx ring to set up\n+ * @rx_ring: the Rx ring to set up\n *\n * Return 0 on success, negative on error\n */\n@@ -586,7 +586,7 @@ static bool ice_add_rx_frag(struct ice_rx_buf *rx_buf,\n \n /**\n * ice_reuse_rx_page - page flip buffer and store it back on the ring\n- * @rx_ring: rx descriptor ring to store buffers on\n+ * @rx_ring: Rx descriptor ring to store buffers on\n * @old_buf: donor buffer to have page reused\n *\n * Synchronizes page for reuse by the adapter\n@@ -609,7 +609,7 @@ static void ice_reuse_rx_page(struct ice_ring *rx_ring,\n \n /**\n * ice_fetch_rx_buf - Allocate skb and populate it\n- * @rx_ring: rx descriptor ring to transact packets on\n+ * @rx_ring: Rx descriptor ring to transact packets on\n * @rx_desc: descriptor containing info written by hardware\n *\n * This function allocates an skb on the fly, and populates it with the page\n@@ -904,7 +904,7 @@ static void ice_rx_csum(struct ice_vsi *vsi, struct sk_buff *skb,\n \n /**\n * ice_process_skb_fields - Populate skb header fields from Rx descriptor\n- * @rx_ring: rx descriptor ring packet is being transacted on\n+ * @rx_ring: Rx descriptor ring packet is being transacted on\n * @rx_desc: pointer to the EOP Rx descriptor\n * @skb: pointer to current skb being populated\n * @ptype: the packet type decoded by hardware\n@@ -927,7 +927,7 @@ static void ice_process_skb_fields(struct ice_ring *rx_ring,\n \n /**\n * ice_receive_skb - Send a completed packet up the stack\n- * @rx_ring: rx ring in play\n+ * @rx_ring: Rx ring in play\n * @skb: packet to send up\n * @vlan_tag: vlan tag for packet\n *\n@@ -946,7 +946,7 @@ static void ice_receive_skb(struct ice_ring *rx_ring, struct sk_buff *skb,\n \n /**\n * ice_clean_rx_irq - Clean completed descriptors from Rx ring - bounce buf\n- * @rx_ring: rx descriptor ring to transact packets on\n+ * @rx_ring: Rx descriptor ring to transact packets on\n * @budget: Total limit on number of packets to process\n *\n * This function provides a \"bounce buffer\" approach to Rx interrupt\n@@ -1123,7 +1123,7 @@ build_ctob(u64 td_cmd, u64 td_offset, unsigned int size, u64 td_tag)\n }\n \n /**\n- * __ice_maybe_stop_tx - 2nd level check for tx stop conditions\n+ * __ice_maybe_stop_tx - 2nd level check for Tx stop conditions\n * @tx_ring: the ring to be checked\n * @size: the size buffer we want to assure is available\n *\n@@ -1146,7 +1146,7 @@ static int __ice_maybe_stop_tx(struct ice_ring *tx_ring, unsigned int size)\n }\n \n /**\n- * ice_maybe_stop_tx - 1st level check for tx stop conditions\n+ * ice_maybe_stop_tx - 1st level check for Tx stop conditions\n * @tx_ring: the ring to be checked\n * @size: the size buffer we want to assure is available\n *\n@@ -1156,6 +1156,7 @@ static int ice_maybe_stop_tx(struct ice_ring *tx_ring, unsigned int size)\n {\n \tif (likely(ICE_DESC_UNUSED(tx_ring) >= size))\n \t\treturn 0;\n+\n \treturn __ice_maybe_stop_tx(tx_ring, size);\n }\n \n@@ -1569,7 +1570,7 @@ static unsigned int ice_txd_use_count(unsigned int size)\n }\n \n /**\n- * ice_xmit_desc_count - calculate number of tx descriptors needed\n+ * ice_xmit_desc_count - calculate number of Tx descriptors needed\n * @skb: send buffer\n *\n * Returns number of data descriptors needed for this skb.\n", "prefixes": [ "S9", "15/15" ] }