Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989740/?format=api
{ "id": 989740, "url": "http://patchwork.ozlabs.org/api/patches/989740/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-13-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026184447.13547-13-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-10-26T18:44:44", "name": "[S9,12/15] ice: Cleanup ice_tx_timeout()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2947948f745666253b4bd9f64ed479a252351bf9", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-13-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 72801, "url": "http://patchwork.ozlabs.org/api/series/72801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72801", "date": "2018-10-26T18:44:32", "name": "Bug fixes for ice, set 2/2", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72801/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989740/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hXwq2m2Bz9sMM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 05:44:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E0DBC8867E;\n\tFri, 26 Oct 2018 18:44:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MglHSZqO8Md9; Fri, 26 Oct 2018 18:44:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D9D0388681;\n\tFri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2D8BB1BF30E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2AA5988659\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kJrEQ1Tf+llu for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:49 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A7E7C88638\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:49 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 11:44:47 -0700", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Oct 2018 11:44:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,428,1534834800\"; d=\"scan'208\";a=\"269078861\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 11:44:44 -0700", "Message-Id": "<20181026184447.13547-13-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "References": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S9 12/15] ice: Cleanup ice_tx_timeout()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bruce Allan <bruce.w.allan@intel.com>\n\nClean up number of formatting issues and a comment that could use\nclarification.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n[Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> cleaned up commit message]\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 22 +++++++++-------------\n 1 file changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 292d19e65af0..54ded5d9ab4f 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3702,35 +3702,31 @@ static void ice_tx_timeout(struct net_device *netdev)\n \n \tpf->tx_timeout_count++;\n \n-\t/* find the stopped queue the same way the stack does */\n+\t/* find the stopped queue the same way dev_watchdog() does */\n \tfor (i = 0; i < netdev->num_tx_queues; i++) {\n-\t\tstruct netdev_queue *q;\n \t\tunsigned long trans_start;\n+\t\tstruct netdev_queue *q;\n \n \t\tq = netdev_get_tx_queue(netdev, i);\n \t\ttrans_start = q->trans_start;\n \t\tif (netif_xmit_stopped(q) &&\n \t\t time_after(jiffies,\n-\t\t\t (trans_start + netdev->watchdog_timeo))) {\n+\t\t\t trans_start + netdev->watchdog_timeo)) {\n \t\t\thung_queue = i;\n \t\t\tbreak;\n \t\t}\n \t}\n \n-\tif (i == netdev->num_tx_queues) {\n+\tif (i == netdev->num_tx_queues)\n \t\tnetdev_info(netdev, \"tx_timeout: no netdev hung queue found\\n\");\n-\t} else {\n+\telse\n \t\t/* now that we have an index, find the tx_ring struct */\n-\t\tfor (i = 0; i < vsi->num_txq; i++) {\n-\t\t\tif (vsi->tx_rings[i] && vsi->tx_rings[i]->desc) {\n-\t\t\t\tif (hung_queue ==\n-\t\t\t\t vsi->tx_rings[i]->q_index) {\n+\t\tfor (i = 0; i < vsi->num_txq; i++)\n+\t\t\tif (vsi->tx_rings[i] && vsi->tx_rings[i]->desc)\n+\t\t\t\tif (hung_queue == vsi->tx_rings[i]->q_index) {\n \t\t\t\t\ttx_ring = vsi->tx_rings[i];\n \t\t\t\t\tbreak;\n \t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\t}\n \n \t/* Reset recovery level if enough time has elapsed after last timeout.\n \t * Also ensure no new reset action happens before next timeout period.\n@@ -3751,7 +3747,7 @@ static void ice_tx_timeout(struct net_device *netdev)\n \t\tif (test_bit(ICE_FLAG_MSIX_ENA, pf->flags))\n \t\t\tval = rd32(hw,\n \t\t\t\t GLINT_DYN_CTL(tx_ring->q_vector->v_idx +\n-\t\t\t\t\ttx_ring->vsi->hw_base_vector));\n+\t\t\t\t\t\t tx_ring->vsi->hw_base_vector));\n \n \t\tnetdev_info(netdev, \"tx_timeout: VSI_num: %d, Q %d, NTC: 0x%x, HW_HEAD: 0x%x, NTU: 0x%x, INT: 0x%x\\n\",\n \t\t\t vsi->vsi_num, hung_queue, tx_ring->next_to_clean,\n", "prefixes": [ "S9", "12/15" ] }