Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989732/?format=api
{ "id": 989732, "url": "http://patchwork.ozlabs.org/api/patches/989732/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-3-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026184447.13547-3-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-10-26T18:44:34", "name": "[S9,02/15] ice: Call pci_disable_sriov before stopping queues for VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d15afb19998f8a6511a76fb65dcb877edec1b589", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-3-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 72801, "url": "http://patchwork.ozlabs.org/api/series/72801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72801", "date": "2018-10-26T18:44:32", "name": "Bug fixes for ice, set 2/2", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72801/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989732/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989732/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hXwl10fHz9sMp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 05:44:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8C9CD887DC;\n\tFri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YoNz1B-stZs0; Fri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 29D1488781;\n\tFri, 26 Oct 2018 18:44:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 75E141BF30E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 736B68867D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Srz+4Q9LRvct for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DD11688671\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:49 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 11:44:47 -0700", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Oct 2018 11:44:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,428,1534834800\"; d=\"scan'208\";a=\"269078851\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 11:44:34 -0700", "Message-Id": "<20181026184447.13547-3-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "References": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S9 02/15] ice: Call pci_disable_sriov\n\tbefore stopping queues for VF", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nPrevious to this commit the driver was immediately stopping Tx/Rx\nqueues when doing the following \"echo 0 > sriov_numvfs\" and then it was\ncalling pci_disable_sriov if the VFs are not assigned. This was causing\nthe VIRTCHNL_OP_DISABLE_QUEUES to fail because it was trying to stop\nthe queues for a second time.\n\nFix this by calling pci_disable_sriov before stopping the Tx/Rx queues.\nThis allows the VIRTCHNL_OP_DISABLE_QUEUES to get processed before the\ndriver tries to stop the Rx/Tx queues in ice_free_vfs.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex e71065f9d391..20b94dee0036 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -215,6 +215,15 @@ void ice_free_vfs(struct ice_pf *pf)\n \twhile (test_and_set_bit(__ICE_VF_DIS, pf->state))\n \t\tusleep_range(1000, 2000);\n \n+\t/* Disable IOV before freeing resources. This lets any VF drivers\n+\t * running in the host get themselves cleaned up before we yank\n+\t * the carpet out from underneath their feet.\n+\t */\n+\tif (!pci_vfs_assigned(pf->pdev))\n+\t\tpci_disable_sriov(pf->pdev);\n+\telse\n+\t\tdev_warn(&pf->pdev->dev, \"VFs are assigned - not disabling SR-IOV\\n\");\n+\n \t/* Avoid wait time by stopping all VFs at the same time */\n \tfor (i = 0; i < pf->num_alloc_vfs; i++) {\n \t\tif (!test_bit(ICE_VF_STATE_ENA, pf->vf[i].vf_states))\n@@ -228,15 +237,6 @@ void ice_free_vfs(struct ice_pf *pf)\n \t\tclear_bit(ICE_VF_STATE_ENA, pf->vf[i].vf_states);\n \t}\n \n-\t/* Disable IOV before freeing resources. This lets any VF drivers\n-\t * running in the host get themselves cleaned up before we yank\n-\t * the carpet out from underneath their feet.\n-\t */\n-\tif (!pci_vfs_assigned(pf->pdev))\n-\t\tpci_disable_sriov(pf->pdev);\n-\telse\n-\t\tdev_warn(&pf->pdev->dev, \"VFs are assigned - not disabling SR-IOV\\n\");\n-\n \ttmp = pf->num_alloc_vfs;\n \tpf->num_vf_qps = 0;\n \tpf->num_alloc_vfs = 0;\n", "prefixes": [ "S9", "02/15" ] }