Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989728/?format=api
{ "id": 989728, "url": "http://patchwork.ozlabs.org/api/patches/989728/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-10-anirudh.venkataramanan@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026184447.13547-10-anirudh.venkataramanan@intel.com>", "list_archive_url": null, "date": "2018-10-26T18:44:41", "name": "[S9,09/15] ice: Do not set LAN_EN for MAC-VLAN filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a7bfaa060284a6a16c4066a5e414d51ab363c9c7", "submitter": { "id": 73601, "url": "http://patchwork.ozlabs.org/api/people/73601/?format=api", "name": "Anirudh Venkataramanan", "email": "anirudh.venkataramanan@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026184447.13547-10-anirudh.venkataramanan@intel.com/mbox/", "series": [ { "id": 72801, "url": "http://patchwork.ozlabs.org/api/series/72801/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72801", "date": "2018-10-26T18:44:32", "name": "Bug fixes for ice, set 2/2", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72801/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989728/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989728/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hXwk3K9Bz9sDX\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 05:44:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 40B1B8765E;\n\tFri, 26 Oct 2018 18:44:52 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2xeDEBq4Gmn8; Fri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B1A9986211;\n\tFri, 26 Oct 2018 18:44:50 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 36D4B1BF30E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2FD5B88659\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L1gekYbW+bhj for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:48 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 635EB88638\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 18:44:48 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Oct 2018 11:44:47 -0700", "from shasta.jf.intel.com ([10.166.241.11])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Oct 2018 11:44:47 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,428,1534834800\"; d=\"scan'208\";a=\"269078858\"", "From": "Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Oct 2018 11:44:41 -0700", "Message-Id": "<20181026184447.13547-10-anirudh.venkataramanan@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "References": "<20181026184447.13547-1-anirudh.venkataramanan@intel.com>", "Subject": "[Intel-wired-lan] [PATCH S9 09/15] ice: Do not set LAN_EN for\n\tMAC-VLAN filters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Yashaswini Raghuram Prathivadi Bhayankaram <yashaswini.raghuram.prathivadi.bhayankaram@intel.com>\n\nIn the action fields for a MAC-VLAN filter, do not set the LAN_EN flag\nif the MAC in the MAC-VLAN is unicast MAC. The unicast packets that\nmatch should not be forwarded to the wire.\n\nSigned-off-by: Yashaswini Raghuram Prathivadi Bhayankaram <yashaswini.raghuram.prathivadi.bhayankaram@intel.com>\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_switch.c | 37 +++++++++++++++++++----------\n 1 file changed, 24 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex 40c9c6558956..107ca08899b6 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -629,25 +629,36 @@ enum ice_status ice_get_initial_sw_cfg(struct ice_hw *hw)\n /**\n * ice_fill_sw_info - Helper function to populate lb_en and lan_en\n * @hw: pointer to the hardware structure\n- * @f_info: filter info structure to fill/update\n+ * @fi: filter info structure to fill/update\n *\n * This helper function populates the lb_en and lan_en elements of the provided\n * ice_fltr_info struct using the switch's type and characteristics of the\n * switch rule being configured.\n */\n-static void ice_fill_sw_info(struct ice_hw *hw, struct ice_fltr_info *f_info)\n+static void ice_fill_sw_info(struct ice_hw *hw, struct ice_fltr_info *fi)\n {\n-\tf_info->lb_en = false;\n-\tf_info->lan_en = false;\n-\tif ((f_info->flag & ICE_FLTR_TX) &&\n-\t (f_info->fltr_act == ICE_FWD_TO_VSI ||\n-\t f_info->fltr_act == ICE_FWD_TO_VSI_LIST ||\n-\t f_info->fltr_act == ICE_FWD_TO_Q ||\n-\t f_info->fltr_act == ICE_FWD_TO_QGRP)) {\n-\t\tf_info->lb_en = true;\n-\t\tif (!(hw->evb_veb && f_info->lkup_type == ICE_SW_LKUP_MAC &&\n-\t\t is_unicast_ether_addr(f_info->l_data.mac.mac_addr)))\n-\t\t\tf_info->lan_en = true;\n+\tfi->lb_en = false;\n+\tfi->lan_en = false;\n+\tif ((fi->flag & ICE_FLTR_TX) &&\n+\t (fi->fltr_act == ICE_FWD_TO_VSI ||\n+\t fi->fltr_act == ICE_FWD_TO_VSI_LIST ||\n+\t fi->fltr_act == ICE_FWD_TO_Q ||\n+\t fi->fltr_act == ICE_FWD_TO_QGRP)) {\n+\t\tfi->lb_en = true;\n+\t\t/* Do not set lan_en to TRUE if\n+\t\t * 1. The switch is a VEB AND\n+\t\t * 2\n+\t\t * 2.1 The lookup is MAC with unicast addr for MAC, OR\n+\t\t * 2.2 The lookup is MAC_VLAN with unicast addr for MAC\n+\t\t *\n+\t\t * In all other cases, the LAN enable has to be set to true.\n+\t\t */\n+\t\tif (!(hw->evb_veb &&\n+\t\t ((fi->lkup_type == ICE_SW_LKUP_MAC &&\n+\t\t\tis_unicast_ether_addr(fi->l_data.mac.mac_addr)) ||\n+\t\t (fi->lkup_type == ICE_SW_LKUP_MAC_VLAN &&\n+\t\t\tis_unicast_ether_addr(fi->l_data.mac_vlan.mac_addr)))))\n+\t\t\tfi->lan_en = true;\n \t}\n }\n \n", "prefixes": [ "S9", "09/15" ] }