Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/989680/?format=api
{ "id": 989680, "url": "http://patchwork.ozlabs.org/api/patches/989680/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026171300.12720-1-mlichvar@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181026171300.12720-1-mlichvar@redhat.com>", "list_archive_url": null, "date": "2018-10-26T17:13:00", "name": "[v2,net] igb: shorten maximum PHC timecounter update interval", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ef4f9c98d3e948b2d42cbc25578fe9ea4d20d771", "submitter": { "id": 17040, "url": "http://patchwork.ozlabs.org/api/people/17040/?format=api", "name": "Miroslav Lichvar", "email": "mlichvar@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181026171300.12720-1-mlichvar@redhat.com/mbox/", "series": [ { "id": 72777, "url": "http://patchwork.ozlabs.org/api/series/72777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72777", "date": "2018-10-26T17:13:00", "name": "[v2,net] igb: shorten maximum PHC timecounter update interval", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/72777/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/989680/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/989680/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42hVts6YVvz9sDn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Oct 2018 04:13:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4A27A86FD0;\n\tFri, 26 Oct 2018 17:13:08 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LuWXP2k9QWYF; Fri, 26 Oct 2018 17:13:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6848881B25;\n\tFri, 26 Oct 2018 17:13:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0CBB01BF30F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 17:13:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 09C2822EE5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 17:13:04 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hNQilu6HJFq2 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 17:13:03 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9ABF022095\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Oct 2018 17:13:03 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1BC3CC0601F1;\n\tFri, 26 Oct 2018 17:13:03 +0000 (UTC)", "from holly.tpb.lab.eng.brq.redhat.com\n\t(holly.tpb.lab.eng.brq.redhat.com [10.43.134.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B15636146F;\n\tFri, 26 Oct 2018 17:13:01 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Fri, 26 Oct 2018 17:13:03 +0000 (UTC)" ], "From": "Miroslav Lichvar <mlichvar@redhat.com>", "To": "netdev@vger.kernel.org", "Date": "Fri, 26 Oct 2018 19:13:00 +0200", "Message-Id": "<20181026171300.12720-1-mlichvar@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Subject": "[Intel-wired-lan] [PATCH v2 net] igb: shorten maximum PHC\n\ttimecounter update interval", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org,\n\tRichard Cochran <richardcochran@gmail.com>,\n\tThomas Gleixner <tglx@linutronix.de>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The timecounter needs to be updated at least once per ~550 seconds in\norder to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old\ntimestamp.\n\nSince commit 500462a9de65 (\"timers: Switch to a non-cascading wheel\"),\nscheduling of delayed work seems to be less accurate and a requested\ndelay of 540 seconds may actually be longer than 550 seconds. Also, the\nPHC may be adjusted to run up to 6% faster than real time and the system\nclock up to 10% slower. Shorten the delay to 360 seconds to be sure the\ntimecounter is updated in time.\n\nThis fixes an issue with HW timestamps on 82580/I350/I354 being off by\n~1100 seconds for few seconds every ~9 minutes.\n\nCc: Jacob Keller <jacob.e.keller@intel.com>\nCc: Richard Cochran <richardcochran@gmail.com>\nCc: Thomas Gleixner <tglx@linutronix.de>\nSigned-off-by: Miroslav Lichvar <mlichvar@redhat.com>\n---\n drivers/net/ethernet/intel/igb/igb_ptp.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c\nindex 9f4d700e09df..2b95dc9c7a6a 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ptp.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ptp.c\n@@ -51,9 +51,17 @@\n *\n * The 40 bit 82580 SYSTIM overflows every\n * 2^40 * 10^-9 / 60 = 18.3 minutes.\n+ *\n+ * SYSTIM is converted to real time using a timecounter. As\n+ * timecounter_cyc2time() allows old timestamps, the timecounter needs\n+ * to be updated at least once per half of the SYSTIM interval.\n+ * Scheduling of delayed work is not very accurate, and also the NIC\n+ * clock can be adjusted to run up to 6% faster and the system clock\n+ * up to 10% slower, so we aim for 6 minutes to be sure the actual\n+ * interval in the NIC time is shorter than 9.16 minutes.\n */\n \n-#define IGB_SYSTIM_OVERFLOW_PERIOD\t(HZ * 60 * 9)\n+#define IGB_SYSTIM_OVERFLOW_PERIOD\t(HZ * 60 * 6)\n #define IGB_PTP_TX_TIMEOUT\t\t(HZ * 15)\n #define INCPERIOD_82576\t\t\tBIT(E1000_TIMINCA_16NS_SHIFT)\n #define INCVALUE_82576_MASK\t\tGENMASK(E1000_TIMINCA_16NS_SHIFT - 1, 0)\n", "prefixes": [ "v2", "net" ] }