Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/988929/?format=api
{ "id": 988929, "url": "http://patchwork.ozlabs.org/api/patches/988929/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181025070618.35667-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181025070618.35667-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2018-10-25T07:06:18", "name": "igc: Clean up code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "448bed580fdaa17c1581249846b34a27e1f8f3d4", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181025070618.35667-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 72523, "url": "http://patchwork.ozlabs.org/api/series/72523/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=72523", "date": "2018-10-25T07:06:18", "name": "igc: Clean up code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/72523/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/988929/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/988929/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42gdTH1Dzcz9sBk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 25 Oct 2018 18:06:25 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7BABF88091;\n\tThu, 25 Oct 2018 07:06:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Weg6y3Q7S-AX; Thu, 25 Oct 2018 07:06:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D9C1F8808F;\n\tThu, 25 Oct 2018 07:06:21 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A52041BF3ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Oct 2018 07:06:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A1887240C5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Oct 2018 07:06:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hBzyDjltDlwS for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Oct 2018 07:06:20 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 39FFB2200B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 25 Oct 2018 07:06:20 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2018 00:06:19 -0700", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Oct 2018 00:06:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,423,1534834800\"; d=\"scan'208\";a=\"268632283\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 25 Oct 2018 10:06:18 +0300", "Message-Id": "<20181025070618.35667-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH] igc: Clean up code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Address few community comments.\nRemove unused code, will be added per demand.\nRemove blank lines and unneeded includes.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc.h | 9 ---------\n drivers/net/ethernet/intel/igc/igc_main.c | 15 ---------------\n 2 files changed, 24 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h\nindex cdf18a5d9e08..3b00b109b34a 100644\n--- a/drivers/net/ethernet/intel/igc/igc.h\n+++ b/drivers/net/ethernet/intel/igc/igc.h\n@@ -5,23 +5,14 @@\n #define _IGC_H_\n \n #include <linux/kobject.h>\n-\n #include <linux/pci.h>\n #include <linux/netdevice.h>\n #include <linux/vmalloc.h>\n-\n #include <linux/ethtool.h>\n-\n #include <linux/sctp.h>\n \n #define IGC_ERR(args...) pr_err(\"igc: \" args)\n \n-#define PFX \"igc: \"\n-\n-#include <linux/timecounter.h>\n-#include <linux/net_tstamp.h>\n-#include <linux/ptp_clock_kernel.h>\n-\n #include \"igc_hw.h\"\n \n /* main */\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 9d85707e8a81..eb11e8dbf0b2 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -1700,20 +1700,6 @@ static bool igc_clean_tx_irq(struct igc_q_vector *q_vector, int napi_budget)\n }\n \n /**\n- * igc_ioctl - I/O control method\n- * @netdev: network interface device structure\n- * @ifreq: frequency\n- * @cmd: command\n- */\n-static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)\n-{\n-\tswitch (cmd) {\n-\tdefault:\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-}\n-\n-/**\n * igc_up - Open the interface and prepare it to handle traffic\n * @adapter: board private structure\n */\n@@ -3445,7 +3431,6 @@ static const struct net_device_ops igc_netdev_ops = {\n \t.ndo_set_mac_address\t= igc_set_mac,\n \t.ndo_change_mtu\t\t= igc_change_mtu,\n \t.ndo_get_stats\t\t= igc_get_stats,\n-\t.ndo_do_ioctl\t\t= igc_ioctl,\n };\n \n /* PCIe configuration access */\n", "prefixes": [] }