Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/986981/?format=api
{ "id": 986981, "url": "http://patchwork.ozlabs.org/api/patches/986981/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181019181615.27528-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181019181615.27528-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-10-19T18:16:15", "name": "[next] igc: fix error return handling from call to netif_set_real_num_tx_queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f3b112fac91d07b43745f534ae4e51e3bf9b83d4", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181019181615.27528-1-colin.king@canonical.com/mbox/", "series": [ { "id": 71790, "url": "http://patchwork.ozlabs.org/api/series/71790/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=71790", "date": "2018-10-19T18:16:15", "name": "[next] igc: fix error return handling from call to netif_set_real_num_tx_queues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/71790/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/986981/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/986981/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42cDd8382Bz9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 20 Oct 2018 05:16:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 52726885E5;\n\tFri, 19 Oct 2018 18:16:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5NWuK08wfv6D; Fri, 19 Oct 2018 18:16:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 01454885D3;\n\tFri, 19 Oct 2018 18:16:24 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7412F1BF3C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 18:16:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7065387F9A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 18:16:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Lw31qhCHs49U for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 18:16:21 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 2BAD787F49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 18:16:21 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1gDZJo-00021C-57; Fri, 19 Oct 2018 18:16:16 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Sasha Neftin <sasha.neftin@intel.com>,\n\tJeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 19 Oct 2018 19:16:15 +0100", "Message-Id": "<20181019181615.27528-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH][next] igc: fix error return handling from\n\tcall to netif_set_real_num_tx_queues", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, kernel-janitors@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe call to netif_set_real_num_tx_queues is not assigning the error\nreturn to variable err even though the next line checks err for an\nerror. Fix this by adding the missing err assignment.\n\nDetected by CoverityScan, CID#1474551 (\"Logically dead code\")\n\nFixes: 3df25e4c1e66 (\"igc: Add interrupt support\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 9d85707e8a81..80ddbd987764 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3358,7 +3358,7 @@ static int __igc_open(struct net_device *netdev, bool resuming)\n \t\tgoto err_req_irq;\n \n \t/* Notify the stack of the actual queue counts. */\n-\tnetif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);\n+\terr = netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);\n \tif (err)\n \t\tgoto err_set_queues;\n \n", "prefixes": [ "next" ] }