Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/986754/?format=api
{ "id": 986754, "url": "http://patchwork.ozlabs.org/api/patches/986754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1539953291-189201-1-git-send-email-yuehaibing@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1539953291-189201-1-git-send-email-yuehaibing@huawei.com>", "list_archive_url": null, "date": "2018-10-19T12:48:11", "name": "[net-next] igc: Remove set but not used variable 'pci_using_dac'", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cd807486c83a38cafdc8fbe2d672d47c28057255", "submitter": { "id": 70610, "url": "http://patchwork.ozlabs.org/api/people/70610/?format=api", "name": "Yue Haibing", "email": "yuehaibing@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1539953291-189201-1-git-send-email-yuehaibing@huawei.com/mbox/", "series": [ { "id": 71724, "url": "http://patchwork.ozlabs.org/api/series/71724/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=71724", "date": "2018-10-19T12:48:11", "name": "[net-next] igc: Remove set but not used variable 'pci_using_dac'", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/71724/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/986754/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/986754/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=huawei.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42c56K29pzz9s4Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 19 Oct 2018 23:37:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5F0B9885E8;\n\tFri, 19 Oct 2018 12:37:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mmR9qEtKReAo; Fri, 19 Oct 2018 12:37:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 05D00885E2;\n\tFri, 19 Oct 2018 12:37:43 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 91F3B1BF3D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:37:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8EDF12302D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:37:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gYmtMUmOdyzV for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:37:40 +0000 (UTC)", "from huawei.com (szxga06-in.huawei.com [45.249.212.32])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9BE012290E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:37:40 +0000 (UTC)", "from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id 0E5C23608F9DE;\n\tFri, 19 Oct 2018 20:37:33 +0800 (CST)", "from localhost.localdomain.localdomain (10.175.113.25) by\n\tDGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP\n\tServer id 14.3.399.0; Fri, 19 Oct 2018 20:37:24 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "YueHaibing <yuehaibing@huawei.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>, \"David S. Miller\"\n\t<davem@davemloft.net>, Sasha Neftin <sasha.neftin@intel.com>", "Date": "Fri, 19 Oct 2018 12:48:11 +0000", "Message-ID": "<1539953291-189201-1-git-send-email-yuehaibing@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.175.113.25]", "X-CFilter-Loop": "Reflected", "Subject": "[Intel-wired-lan] [PATCH net-next] igc: Remove set but not used\n\tvariable 'pci_using_dac'", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org, kernel-janitors@vger.kernel.org,\n\tYueHaibing <yuehaibing@huawei.com>, netdev@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Fixes gcc '-Wunused-but-set-variable' warning:\n\ndrivers/net/ethernet/intel/igc/igc_main.c: In function 'igc_probe':\ndrivers/net/ethernet/intel/igc/igc_main.c:3535:11: warning:\n variable 'pci_using_dac' set but not used [-Wunused-but-set-variable]\n\nIt never used since introduction in commit\nd89f88419f99 (\"igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller support\")\n\nSigned-off-by: YueHaibing <yuehaibing@huawei.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 9d85707..06a4afbe 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3532,19 +3532,16 @@ static int igc_probe(struct pci_dev *pdev,\n \tstruct net_device *netdev;\n \tstruct igc_hw *hw;\n \tconst struct igc_info *ei = igc_info_tbl[ent->driver_data];\n-\tint err, pci_using_dac;\n+\tint err;\n \n \terr = pci_enable_device_mem(pdev);\n \tif (err)\n \t\treturn err;\n \n-\tpci_using_dac = 0;\n \terr = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));\n \tif (!err) {\n \t\terr = dma_set_coherent_mask(&pdev->dev,\n \t\t\t\t\t DMA_BIT_MASK(64));\n-\t\tif (!err)\n-\t\t\tpci_using_dac = 1;\n \t} else {\n \t\terr = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));\n \t\tif (err) {\n", "prefixes": [ "net-next" ] }