Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/986735/?format=api
{ "id": 986735, "url": "http://patchwork.ozlabs.org/api/patches/986735/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1539952830-187358-1-git-send-email-yuehaibing@huawei.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1539952830-187358-1-git-send-email-yuehaibing@huawei.com>", "list_archive_url": null, "date": "2018-10-19T12:40:30", "name": "[net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a9036d39c50974479dcfda443387175dc4203836", "submitter": { "id": 70610, "url": "http://patchwork.ozlabs.org/api/people/70610/?format=api", "name": "Yue Haibing", "email": "yuehaibing@huawei.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1539952830-187358-1-git-send-email-yuehaibing@huawei.com/mbox/", "series": [ { "id": 71715, "url": "http://patchwork.ozlabs.org/api/series/71715/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=71715", "date": "2018-10-19T12:40:30", "name": "[net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/71715/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/986735/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/986735/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=huawei.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42c4xZ73HHzB2xZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 19 Oct 2018 23:30:10 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D605630034;\n\tFri, 19 Oct 2018 12:30:08 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DBDBpu5h-C8M; Fri, 19 Oct 2018 12:30:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AD2052290E;\n\tFri, 19 Oct 2018 12:30:07 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DFB1F1BF3D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:30:06 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DC508885E2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:30:06 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mQeuzkKnMNRc for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:30:04 +0000 (UTC)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 40ECB885DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 19 Oct 2018 12:30:03 +0000 (UTC)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60])\n\tby Forcepoint Email with ESMTP id 76AFF366C632A;\n\tFri, 19 Oct 2018 20:29:51 +0800 (CST)", "from localhost.localdomain.localdomain (10.175.113.25) by\n\tDGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP\n\tServer id 14.3.399.0; Fri, 19 Oct 2018 20:29:43 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "YueHaibing <yuehaibing@huawei.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>, Sasha Neftin\n\t<sasha.neftin@intel.com>", "Date": "Fri, 19 Oct 2018 12:40:30 +0000", "Message-ID": "<1539952830-187358-1-git-send-email-yuehaibing@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.175.113.25]", "X-CFilter-Loop": "Reflected", "Subject": "[Intel-wired-lan] [PATCH net-next] igc: Remove set but not used\n\tvariables 'ctrl_ext, link_mode'", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org, kernel-janitors@vger.kernel.org,\n\tYueHaibing <yuehaibing@huawei.com>, netdev@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Fixes gcc '-Wunused-but-set-variable' warning:\n\ndrivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_init_phy_params_base':\ndrivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:\n variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]\n u32 ctrl_ext;\n \ndrivers/net/ethernet/intel/igc/igc_base.c: In function 'igc_get_invariants_base':\ndrivers/net/ethernet/intel/igc/igc_base.c:290:6: warning:\n variable 'link_mode' set but not used [-Wunused-but-set-variable]\n u32 link_mode = 0;\n\nIt never used since introduction in\ncommit c0071c7aa5fe (\"igc: Add HW initialization code\")\n\nSigned-off-by: YueHaibing <yuehaibing@huawei.com>\n---\nI'm not sure that reading IGC_CTRL_EXT is necessary.\n---\n drivers/net/ethernet/intel/igc/igc_base.c | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c\nindex 832da609..df40af7 100644\n--- a/drivers/net/ethernet/intel/igc/igc_base.c\n+++ b/drivers/net/ethernet/intel/igc/igc_base.c\n@@ -237,7 +237,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)\n {\n \tstruct igc_phy_info *phy = &hw->phy;\n \ts32 ret_val = 0;\n-\tu32 ctrl_ext;\n \n \tif (hw->phy.media_type != igc_media_type_copper) {\n \t\tphy->type = igc_phy_none;\n@@ -247,8 +246,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)\n \tphy->autoneg_mask\t= AUTONEG_ADVERTISE_SPEED_DEFAULT_2500;\n \tphy->reset_delay_us\t= 100;\n \n-\tctrl_ext = rd32(IGC_CTRL_EXT);\n-\n \t/* set lan id */\n \thw->bus.func = (rd32(IGC_STATUS) & IGC_STATUS_FUNC_MASK) >>\n \t\t\tIGC_STATUS_FUNC_SHIFT;\n@@ -287,8 +284,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)\n static s32 igc_get_invariants_base(struct igc_hw *hw)\n {\n \tstruct igc_mac_info *mac = &hw->mac;\n-\tu32 link_mode = 0;\n-\tu32 ctrl_ext = 0;\n \ts32 ret_val = 0;\n \n \tswitch (hw->device_id) {\n@@ -302,9 +297,6 @@ static s32 igc_get_invariants_base(struct igc_hw *hw)\n \n \thw->phy.media_type = igc_media_type_copper;\n \n-\tctrl_ext = rd32(IGC_CTRL_EXT);\n-\tlink_mode = ctrl_ext & IGC_CTRL_EXT_LINK_MODE_MASK;\n-\n \t/* mac initialization and operations */\n \tret_val = igc_init_mac_params_base(hw);\n \tif (ret_val)\n", "prefixes": [ "net-next" ] }