Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985274/?format=api
{ "id": 985274, "url": "http://patchwork.ozlabs.org/api/patches/985274/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-29-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-29-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:52", "name": "[v4,28/38] numa: Clean up error reporting in parse_numa()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a2e483360b053240f45456daa9ed4ee22e24d5a", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-29-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985274/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZmPf34f4z9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 20:01:26 +1100 (AEDT)", "from localhost ([::1]:34685 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChhj-0003nf-Ix\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 05:01:23 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51217)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAo-0008H6-1A\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:23 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAd-00019g-RD\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:14 -0400", "from mx1.redhat.com ([209.132.183.28]:48060)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAd-00015U-7O\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8F10981F0D\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:09 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 49BF0BA92;\n\tWed, 17 Oct 2018 08:27:09 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 799AB1156355; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:52 +0200", "Message-Id": "<20181017082702.5581-29-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 17 Oct 2018 08:27:09 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 28/38] numa: Clean up error reporting in\n\tparse_numa()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Eduardo Habkost <ehabkost@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. parse_numa() does that, and then fails without setting\nan error. Its caller main(), via qemu_opts_foreach(), is fine with\nit, but clean it up anyway.\n\nWhile there, give parse_numa() internal linkage.\n\nCc: Eduardo Habkost <ehabkost@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Eduardo Habkost <ehabkost@redhat.com>\n---\n include/sysemu/numa.h | 1 -\n numa.c | 8 +++-----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h\nindex 7a0ae751aa..21713b7e2f 100644\n--- a/include/sysemu/numa.h\n+++ b/include/sysemu/numa.h\n@@ -22,7 +22,6 @@ struct NumaNodeMem {\n };\n \n extern NodeInfo numa_info[MAX_NODES];\n-int parse_numa(void *opaque, QemuOpts *opts, Error **errp);\n void parse_numa_opts(MachineState *ms);\n void numa_complete_configuration(MachineState *ms);\n void query_numa_node_mem(NumaNodeMem node_mem[]);\ndiff --git a/numa.c b/numa.c\nindex 1d7c49ad43..50ec016013 100644\n--- a/numa.c\n+++ b/numa.c\n@@ -215,7 +215,7 @@ end:\n error_propagate(errp, err);\n }\n \n-int parse_numa(void *opaque, QemuOpts *opts, Error **errp)\n+static int parse_numa(void *opaque, QemuOpts *opts, Error **errp)\n {\n NumaOptions *object = NULL;\n MachineState *ms = MACHINE(opaque);\n@@ -239,7 +239,7 @@ int parse_numa(void *opaque, QemuOpts *opts, Error **errp)\n end:\n qapi_free_NumaOptions(object);\n if (err) {\n- error_report_err(err);\n+ error_propagate(errp, err);\n return -1;\n }\n \n@@ -444,9 +444,7 @@ void numa_complete_configuration(MachineState *ms)\n \n void parse_numa_opts(MachineState *ms)\n {\n- if (qemu_opts_foreach(qemu_find_opts(\"numa\"), parse_numa, ms, NULL)) {\n- exit(1);\n- }\n+ qemu_opts_foreach(qemu_find_opts(\"numa\"), parse_numa, ms, &error_fatal);\n }\n \n void qmp_set_numa_node(NumaOptions *cmd, Error **errp)\n", "prefixes": [ "v4", "28/38" ] }