Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985271/?format=api
{ "id": 985271, "url": "http://patchwork.ozlabs.org/api/patches/985271/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-24-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-24-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:47", "name": "[v4,23/38] vl: Clean up error reporting in parse_fw_cfg()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ca5e790b781630108d7dba59ce6ddc0534042837", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-24-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985271/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZmLH4hjyz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:58:31 +1100 (AEDT)", "from localhost ([::1]:34662 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChev-00015J-4r\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:58:29 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51214)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAo-0008H3-12\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:23 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAd-00018x-Eg\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:14 -0400", "from mx1.redhat.com ([209.132.183.28]:41209)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAc-00014q-S9\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5E80230C9EE8\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:09 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 286C65DD95\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:09 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 6804F1153BCB; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:47 +0200", "Message-Id": "<20181017082702.5581-24-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.42]);\n\tWed, 17 Oct 2018 08:27:09 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 23/38] vl: Clean up error reporting in\n\tparse_fw_cfg()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. parse_fw_cfg() does that, and then fails without\nsetting an error. Its caller main(), via qemu_opts_foreach(), is fine\nwith it, but clean it up anyway.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n vl.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/vl.c b/vl.c\nindex cd8e8a6586..c5bc54f72b 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -2174,7 +2174,7 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp)\n FWCfgState *fw_cfg = (FWCfgState *) opaque;\n \n if (fw_cfg == NULL) {\n- error_report(\"fw_cfg device not available\");\n+ error_setg(errp, \"fw_cfg device not available\");\n return -1;\n }\n name = qemu_opt_get(opts, \"name\");\n@@ -2183,15 +2183,16 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp)\n \n /* we need name and either a file or the content string */\n if (!(nonempty_str(name) && (nonempty_str(file) || nonempty_str(str)))) {\n- error_report(\"invalid argument(s)\");\n+ error_setg(errp, \"invalid argument(s)\");\n return -1;\n }\n if (nonempty_str(file) && nonempty_str(str)) {\n- error_report(\"file and string are mutually exclusive\");\n+ error_setg(errp, \"file and string are mutually exclusive\");\n return -1;\n }\n if (strlen(name) > FW_CFG_MAX_FILE_PATH - 1) {\n- error_report(\"name too long (max. %d char)\", FW_CFG_MAX_FILE_PATH - 1);\n+ error_setg(errp, \"name too long (max. %d char)\",\n+ FW_CFG_MAX_FILE_PATH - 1);\n return -1;\n }\n if (strncmp(name, \"opt/\", 4) != 0) {\n@@ -2203,7 +2204,7 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp)\n buf = g_memdup(str, size);\n } else {\n if (!g_file_get_contents(file, &buf, &size, NULL)) {\n- error_report(\"can't load %s\", file);\n+ error_setg(errp, \"can't load %s\", file);\n return -1;\n }\n }\n@@ -4476,10 +4477,8 @@ int main(int argc, char **argv, char **envp)\n hax_sync_vcpus();\n }\n \n- if (qemu_opts_foreach(qemu_find_opts(\"fw_cfg\"),\n- parse_fw_cfg, fw_cfg_find(), NULL) != 0) {\n- exit(1);\n- }\n+ qemu_opts_foreach(qemu_find_opts(\"fw_cfg\"),\n+ parse_fw_cfg, fw_cfg_find(), &error_fatal);\n \n /* init USB devices */\n if (machine_usb(current_machine)) {\n", "prefixes": [ "v4", "23/38" ] }