Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985268/?format=api
{ "id": 985268, "url": "http://patchwork.ozlabs.org/api/patches/985268/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-39-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-39-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:27:02", "name": "[v4,38/38] vpc: Fail open on bad header checksum", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "798c4f35f8c1f00d5e683f8aa6b2d4eca42ce000", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-39-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985268/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZmH352Smz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:55:43 +1100 (AEDT)", "from localhost ([::1]:34645 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChcD-0006hB-1P\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:55:41 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52890)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChFo-0004TS-Uk\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:32:33 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChFk-00077B-DN\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:32:32 -0400", "from mx1.redhat.com ([209.132.183.28]:43494)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChFk-000767-6c\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:32:28 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 902B767EC2\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:32:27 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5C1B05DDFF;\n\tWed, 17 Oct 2018 08:32:27 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 9E9F51162B63; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:27:02 +0200", "Message-Id": "<20181017082702.5581-39-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 17 Oct 2018 08:32:27 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "vpc_open() merely prints a warning when it finds a bad header\nchecksum. Turn that into a hard error.\n\nCc: Kevin Wolf <kwolf@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\n---\n block/vpc.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/block/vpc.c b/block/vpc.c\nindex bf294abfa7..1729c0cb44 100644\n--- a/block/vpc.c\n+++ b/block/vpc.c\n@@ -284,9 +284,11 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,\n \n checksum = be32_to_cpu(footer->checksum);\n footer->checksum = 0;\n- if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum)\n- fprintf(stderr, \"block-vpc: The header checksum of '%s' is \"\n- \"incorrect.\\n\", bs->filename);\n+ if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum) {\n+ error_setg(errp, \"incorrect header checksum\");\n+ ret = -EINVAL;\n+ goto fail;\n+ }\n \n /* Write 'checksum' back to footer, or else will leave it with zero. */\n footer->checksum = cpu_to_be32(checksum);\n", "prefixes": [ "v4", "38/38" ] }