Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985241/?format=api
{ "id": 985241, "url": "http://patchwork.ozlabs.org/api/patches/985241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-37-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-37-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:27:00", "name": "[v4,36/38] block: Clean up bdrv_img_create()'s error reporting", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "767cb8b973b0245a490559b7f7df0e783f88545f", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-37-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985241/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zm8D1KR6z9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:49:48 +1100 (AEDT)", "from localhost ([::1]:34610 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChWT-0001dx-87\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:49:45 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51354)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChB1-0000Gb-Fd\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:38 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAx-0001qc-Q8\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:33 -0400", "from mx1.redhat.com ([209.132.183.28]:30559)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAx-0001Fi-CD\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:31 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 25A7467EC2\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:14 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 7E7E35C22E;\n\tWed, 17 Oct 2018 08:27:10 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 975DA1162B5E; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:27:00 +0200", "Message-Id": "<20181017082702.5581-37-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 17 Oct 2018 08:27:14 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 36/38] block: Clean up bdrv_img_create()'s\n\terror reporting", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "bdrv_img_create() takes an Error ** argument and uses it in the\nconventional way, except for one place: when qemu_opts_do_parse()\nfails, it first reports its error to stderr or the HMP monitor with\nerror_report_err(), then error_setg()'s a generic error.\n\nWhen the caller reports that second error similarly, this produces two\nconsecutive error messages on stderr or the HMP monitor.\n\nWhen the caller does something else with it, such as send it via QMP,\nthe first error still goes to stderr or the HMP monitor. Fortunately,\nno such caller exists.\n\nSimply use the first error as is. Update expected output of\nqemu-iotest 049 accordingly.\n\nCc: Kevin Wolf <kwolf@redhat.com>\nCc: Max Reitz <mreitz@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\n---\n block.c | 3 ---\n tests/qemu-iotests/049.out | 12 ++++--------\n 2 files changed, 4 insertions(+), 11 deletions(-)", "diff": "diff --git a/block.c b/block.c\nindex 5d51419d21..08d64cdc61 100644\n--- a/block.c\n+++ b/block.c\n@@ -4803,9 +4803,6 @@ void bdrv_img_create(const char *filename, const char *fmt,\n if (options) {\n qemu_opts_do_parse(opts, options, NULL, &local_err);\n if (local_err) {\n- error_report_err(local_err);\n- local_err = NULL;\n- error_setg(errp, \"Invalid options for file format '%s'\", fmt);\n goto out;\n }\n }\ndiff --git a/tests/qemu-iotests/049.out b/tests/qemu-iotests/049.out\nindex 0871bff564..6b505408dd 100644\n--- a/tests/qemu-iotests/049.out\n+++ b/tests/qemu-iotests/049.out\n@@ -95,35 +95,31 @@ qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- -1024\n qemu-img: Image size must be less than 8 EiB!\n \n qemu-img create -f qcow2 -o size=-1024 TEST_DIR/t.qcow2\n-qemu-img: Value '-1024' is out of range for parameter 'size'\n-qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'\n+qemu-img: TEST_DIR/t.qcow2: Value '-1024' is out of range for parameter 'size'\n \n qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- -1k\n qemu-img: Image size must be less than 8 EiB!\n \n qemu-img create -f qcow2 -o size=-1k TEST_DIR/t.qcow2\n-qemu-img: Value '-1k' is out of range for parameter 'size'\n-qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'\n+qemu-img: TEST_DIR/t.qcow2: Value '-1k' is out of range for parameter 'size'\n \n qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1kilobyte\n qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for\n qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes.\n \n qemu-img create -f qcow2 -o size=1kilobyte TEST_DIR/t.qcow2\n-qemu-img: Parameter 'size' expects a non-negative number below 2^64\n+qemu-img: TEST_DIR/t.qcow2: Parameter 'size' expects a non-negative number below 2^64\n Optional suffix k, M, G, T, P or E means kilo-, mega-, giga-, tera-, peta-\n and exabytes, respectively.\n-qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'\n \n qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- foobar\n qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for\n qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes.\n \n qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2\n-qemu-img: Parameter 'size' expects a non-negative number below 2^64\n+qemu-img: TEST_DIR/t.qcow2: Parameter 'size' expects a non-negative number below 2^64\n Optional suffix k, M, G, T, P or E means kilo-, mega-, giga-, tera-, peta-\n and exabytes, respectively.\n-qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'\n \n == Check correct interpretation of suffixes for cluster size ==\n \n", "prefixes": [ "v4", "36/38" ] }