Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985232/?format=api
{ "id": 985232, "url": "http://patchwork.ozlabs.org/api/patches/985232/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-8-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-8-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:31", "name": "[v4,07/38] char: Use error_printf() to print help and such", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d3155f8360610b18abfd680f559e1ac80eb81141", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-8-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985232/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985232/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zm1149v1z9s47\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:43:33 +1100 (AEDT)", "from localhost ([::1]:34579 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChQR-0005G0-2y\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:43:31 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51314)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAx-00006H-DW\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:32 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAr-0001eP-R9\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:29 -0400", "from mx1.redhat.com ([209.132.183.28]:54393)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAh-00017B-L8\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:17 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9D7F846202\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:10 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 24C375DDFE;\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 2EB221132D3E; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:31 +0200", "Message-Id": "<20181017082702.5581-8-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 17 Oct 2018 08:27:10 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 07/38] char: Use error_printf() to print\n\thelp and such", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t<marcandre.lureau@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. Convert a few that are actually help and such to\nerror_printf().\n\nImproves output of -chardev help from\n\n qemu-system-x86_64: -chardev help: Available chardev backend types:\n serial\n ...\n\nto\n\n Available chardev backend types:\n serial\n ...\n\nCc: Paolo Bonzini <pbonzini@redhat.com>\nCc: \"Marc-André Lureau\" <marcandre.lureau@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>\n---\n chardev/char-pty.c | 2 +-\n chardev/char.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/chardev/char-pty.c b/chardev/char-pty.c\nindex e8d9a53476..f681d637c1 100644\n--- a/chardev/char-pty.c\n+++ b/chardev/char-pty.c\n@@ -259,7 +259,7 @@ static void char_pty_open(Chardev *chr,\n qemu_set_nonblock(master_fd);\n \n chr->filename = g_strdup_printf(\"pty:%s\", pty_name);\n- error_report(\"char device redirected to %s (label %s)\",\n+ error_printf(\"char device redirected to %s (label %s)\\n\",\n pty_name, chr->label);\n \n s = PTY_CHARDEV(chr);\ndiff --git a/chardev/char.c b/chardev/char.c\nindex e115166995..7f07a1bfbd 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -634,7 +634,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts, Error **errp)\n \n chardev_name_foreach(help_string_append, str);\n \n- error_report(\"Available chardev backend types: %s\", str->str);\n+ error_printf(\"Available chardev backend types: %s\\n\", str->str);\n g_string_free(str, true);\n return NULL;\n }\n", "prefixes": [ "v4", "07/38" ] }