Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985226/?format=api
{ "id": 985226, "url": "http://patchwork.ozlabs.org/api/patches/985226/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-31-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-31-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:54", "name": "[v4,30/38] spice: Clean up error reporting in add_channel()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f3311f3c3b2d535aa2e33dc94a084d7993fe6e42", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-31-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985226/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985226/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zlww208Kz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:40:00 +1100 (AEDT)", "from localhost ([::1]:34559 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChMz-0001vq-PP\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:39:57 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51210)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAo-0008Gz-0m\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:22 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAe-00019s-0f\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:14 -0400", "from mx1.redhat.com ([209.132.183.28]:37600)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAd-00016L-H1\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 152E93086258\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:10 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CBA4D5F7C5;\n\tWed, 17 Oct 2018 08:27:09 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 8162111564DC; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:54 +0200", "Message-Id": "<20181017082702.5581-31-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]);\n\tWed, 17 Oct 2018 08:27:10 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 30/38] spice: Clean up error reporting in\n\tadd_channel()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Gerd Hoffmann <kraxel@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. add_channel() does that, and then exit()s. Its caller\nmain(), via qemu_opts_foreach(), is fine with it, but clean it up\nanyway.\n\nCc: Gerd Hoffmann <kraxel@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/spice-core.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/ui/spice-core.c b/ui/spice-core.c\nindex a4fbbc3898..ebaae24643 100644\n--- a/ui/spice-core.c\n+++ b/ui/spice-core.c\n@@ -597,9 +597,9 @@ static int add_channel(void *opaque, const char *name, const char *value,\n if (strcmp(name, \"tls-channel\") == 0) {\n int *tls_port = opaque;\n if (!*tls_port) {\n- error_report(\"spice: tried to setup tls-channel\"\n- \" without specifying a TLS port\");\n- exit(1);\n+ error_setg(errp, \"spice: tried to setup tls-channel\"\n+ \" without specifying a TLS port\");\n+ return -1;\n }\n security = SPICE_CHANNEL_SECURITY_SSL;\n }\n@@ -615,8 +615,9 @@ static int add_channel(void *opaque, const char *name, const char *value,\n rc = spice_server_set_channel_security(spice_server, value, security);\n }\n if (rc != 0) {\n- error_report(\"spice: failed to set channel security for %s\", value);\n- exit(1);\n+ error_setg(errp, \"spice: failed to set channel security for %s\",\n+ value);\n+ return -1;\n }\n return 0;\n }\n@@ -787,7 +788,7 @@ void qemu_spice_init(void)\n spice_server_set_playback_compression\n (spice_server, qemu_opt_get_bool(opts, \"playback-compression\", 1));\n \n- qemu_opt_foreach(opts, add_channel, &tls_port, NULL);\n+ qemu_opt_foreach(opts, add_channel, &tls_port, &error_fatal);\n \n spice_server_set_name(spice_server, qemu_name);\n spice_server_set_uuid(spice_server, (unsigned char *)&qemu_uuid);\n", "prefixes": [ "v4", "30/38" ] }