Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985223/?format=api
{ "id": 985223, "url": "http://patchwork.ozlabs.org/api/patches/985223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-3-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-3-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:26", "name": "[v4,02/38] Use error_fatal to simplify obvious fatal errors (again)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a4ff8149178adf93130106087c933b5cd6dbcc71", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-3-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985223/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZltC6PjCz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:37:39 +1100 (AEDT)", "from localhost ([::1]:34551 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChKj-0008A7-EH\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:37:37 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51045)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAb-00085M-Qc\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAY-0000zl-8S\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from mx1.redhat.com ([209.132.183.28]:52510)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAX-0000xW-TA\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:06 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 562EF30024EC;\n\tWed, 17 Oct 2018 08:27:04 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E0AED5DD95;\n\tWed, 17 Oct 2018 08:27:03 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 1CCD01132D75; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:26 +0200", "Message-Id": "<20181017082702.5581-3-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]);\n\tWed, 17 Oct 2018 08:27:04 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 02/38] Use error_fatal to simplify obvious\n\tfatal errors (again)", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>,\n\tDavid Gibson <david@gibson.dropbear.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Add a slight improvement of the Coccinelle semantic patch from commit\n007b06578ab, and use it to clean up. It leaves dead Error * variables\nbehind, cleaned up manually.\n\nCc: David Gibson <david@gibson.dropbear.id.au>\nCc: Alexander Graf <agraf@suse.de>\nCc: Eric Blake <eblake@redhat.com>\nCc: Paolo Bonzini <pbonzini@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\nAcked-by: David Gibson <david@gibson.dropbear.id.au>\n---\n hw/intc/xics_kvm.c | 7 +------\n qemu-nbd.c | 6 +-----\n scripts/coccinelle/use-error_fatal.cocci | 20 ++++++++++++++++++++\n vl.c | 7 +------\n 4 files changed, 23 insertions(+), 17 deletions(-)\n create mode 100644 scripts/coccinelle/use-error_fatal.cocci", "diff": "diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c\nindex 30c3769a20..e8fa9a53ae 100644\n--- a/hw/intc/xics_kvm.c\n+++ b/hw/intc/xics_kvm.c\n@@ -198,17 +198,12 @@ static void ics_get_kvm_state(ICSState *ics)\n {\n uint64_t state;\n int i;\n- Error *local_err = NULL;\n \n for (i = 0; i < ics->nr_irqs; i++) {\n ICSIRQState *irq = &ics->irqs[i];\n \n kvm_device_access(kernel_xics_fd, KVM_DEV_XICS_GRP_SOURCES,\n- i + ics->offset, &state, false, &local_err);\n- if (local_err) {\n- error_report_err(local_err);\n- exit(1);\n- }\n+ i + ics->offset, &state, false, &error_fatal);\n \n irq->server = state & KVM_XICS_DESTINATION_MASK;\n irq->saved_priority = (state >> KVM_XICS_PRIORITY_SHIFT)\ndiff --git a/qemu-nbd.c b/qemu-nbd.c\nindex e76fe3082a..7874bc973c 100644\n--- a/qemu-nbd.c\n+++ b/qemu-nbd.c\n@@ -1002,11 +1002,7 @@ int main(int argc, char **argv)\n }\n \n exp = nbd_export_new(bs, dev_offset, fd_size, nbdflags, nbd_export_closed,\n- writethrough, NULL, &local_err);\n- if (!exp) {\n- error_report_err(local_err);\n- exit(EXIT_FAILURE);\n- }\n+ writethrough, NULL, &error_fatal);\n nbd_export_set_name(exp, export_name);\n nbd_export_set_description(exp, export_description);\n \ndiff --git a/scripts/coccinelle/use-error_fatal.cocci b/scripts/coccinelle/use-error_fatal.cocci\nnew file mode 100644\nindex 0000000000..10fff0aec4\n--- /dev/null\n+++ b/scripts/coccinelle/use-error_fatal.cocci\n@@ -0,0 +1,20 @@\n+@@\n+type T;\n+identifier FUN, RET;\n+expression list ARGS;\n+expression ERR, EC, FAIL;\n+@@\n+(\n+- T RET = FUN(ARGS, &ERR);\n++ T RET = FUN(ARGS, &error_fatal);\n+|\n+- RET = FUN(ARGS, &ERR);\n++ RET = FUN(ARGS, &error_fatal);\n+|\n+- FUN(ARGS, &ERR);\n++ FUN(ARGS, &error_fatal);\n+)\n+- if (FAIL) {\n+- error_report_err(ERR);\n+- exit(EC);\n+- }\ndiff --git a/vl.c b/vl.c\nindex 4e25c78bff..ff50199e64 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -2002,15 +2002,10 @@ static void select_vgahw(const char *p)\n \n static void parse_display_qapi(const char *optarg)\n {\n- Error *err = NULL;\n DisplayOptions *opts;\n Visitor *v;\n \n- v = qobject_input_visitor_new_str(optarg, \"type\", &err);\n- if (!v) {\n- error_report_err(err);\n- exit(1);\n- }\n+ v = qobject_input_visitor_new_str(optarg, \"type\", &error_fatal);\n \n visit_type_DisplayOptions(v, NULL, &opts, &error_fatal);\n QAPI_CLONE_MEMBERS(DisplayOptions, &dpy, opts);\n", "prefixes": [ "v4", "02/38" ] }