Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985222/?format=api
{ "id": 985222, "url": "http://patchwork.ozlabs.org/api/patches/985222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-22-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-22-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:45", "name": "[v4,21/38] vl: Clean up error reporting in machine_set_property()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b7ade034a1a30f99700659f0c4d7189cfd265d9f", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-22-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985222/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zlt76LsDz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:37:35 +1100 (AEDT)", "from localhost ([::1]:34550 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChKf-00087q-G5\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:37:33 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51220)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAo-0008H7-1E\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:22 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAc-00017L-Vs\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:14 -0400", "from mx1.redhat.com ([209.132.183.28]:37594)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAc-00014i-HD\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:10 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 40B0F30001EA\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:09 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0701580FD1\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:09 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 60F1911420CE; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:45 +0200", "Message-Id": "<20181017082702.5581-22-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]);\n\tWed, 17 Oct 2018 08:27:09 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 21/38] vl: Clean up error reporting in\n\tmachine_set_property()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. machine_set_property() does that, and then fails without\nsetting an error. Its caller main(), via qemu_opts_foreach(), is fine\nwith it, but clean it up anyway.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n vl.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/vl.c b/vl.c\nindex aa03192019..c3c17106bf 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -2676,7 +2676,7 @@ static int machine_set_property(void *opaque,\n g_free(qom_name);\n \n if (local_err) {\n- error_report_err(local_err);\n+ error_propagate(errp, local_err);\n return -1;\n }\n \n@@ -4248,11 +4248,8 @@ int main(int argc, char **argv, char **envp)\n }\n \n machine_opts = qemu_get_machine_opts();\n- if (qemu_opt_foreach(machine_opts, machine_set_property, current_machine,\n- NULL)) {\n- object_unref(OBJECT(current_machine));\n- exit(1);\n- }\n+ qemu_opt_foreach(machine_opts, machine_set_property, current_machine,\n+ &error_fatal);\n \n configure_accelerator(current_machine);\n \n", "prefixes": [ "v4", "21/38" ] }