Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985220/?format=api
{ "id": 985220, "url": "http://patchwork.ozlabs.org/api/patches/985220/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-7-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-7-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:30", "name": "[v4,06/38] vfio: Clean up error reporting after previous commit", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "68b74d47c785ac7429a55a3b954945a1dff7daa2", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-7-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985220/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zlrn3HMXz9sCW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:36:25 +1100 (AEDT)", "from localhost ([::1]:34545 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChJW-0007EE-Mr\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:36:22 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51184)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAh-0008B2-QF\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAc-000160-2P\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:12 -0400", "from mx1.redhat.com ([209.132.183.28]:53294)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAb-00011y-BA\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1098ACECB\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:08 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2214E17557;\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 2B2E01132D3B; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:30 +0200", "Message-Id": "<20181017082702.5581-7-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 17 Oct 2018 08:27:08 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 06/38] vfio: Clean up error reporting after\n\tprevious commit", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alex Williamson <alex.williamson@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The previous commit changed vfio's warning messages from\n\n vfio warning: DEV-NAME: Could not frobnicate\n\nto\n\n warning: vfio DEV-NAME: Could not frobnicate\n\nTo match this change, change error messages from\n\n vfio error: DEV-NAME: On fire\n\nto\n\n vfio DEV-NAME: On fire\n\nNote the loss of \"error\". If we think marking error messages that way\nis a good idea, we should mark *all* error messages, i.e. make\nerror_report() print it.\n\nCc: Alex Williamson <alex.williamson@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nAcked-by: Alex Williamson <alex.williamson@redhat.com>\n---\n hw/vfio/pci-quirks.c | 4 ++--\n hw/vfio/pci.c | 8 ++++----\n hw/vfio/platform.c | 2 +-\n include/hw/vfio/vfio-common.h | 1 -\n 4 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c\nindex 481fd08df7..eae31c74d6 100644\n--- a/hw/vfio/pci-quirks.c\n+++ b/hw/vfio/pci-quirks.c\n@@ -1670,7 +1670,7 @@ static void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)\n * but also no point in us enabling VGA if disabled in hardware.\n */\n if (!(gmch & 0x2) && !vdev->vga && vfio_populate_vga(vdev, &err)) {\n- error_reportf_err(err, ERR_PREFIX, vdev->vbasedev.name);\n+ error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n error_report(\"IGD device %s failed to enable VGA access, \"\n \"legacy mode disabled\", vdev->vbasedev.name);\n goto out;\n@@ -1696,7 +1696,7 @@ static void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)\n ret = vfio_pci_igd_opregion_init(vdev, opregion, &err);\n if (ret) {\n error_append_hint(&err, \"IGD legacy mode disabled\\n\");\n- error_reportf_err(err, ERR_PREFIX, vdev->vbasedev.name);\n+ error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n goto out;\n }\n \ndiff --git a/hw/vfio/pci.c b/hw/vfio/pci.c\nindex 0c3d245932..5c7bd96984 100644\n--- a/hw/vfio/pci.c\n+++ b/hw/vfio/pci.c\n@@ -745,7 +745,7 @@ static void vfio_msi_disable_common(VFIOPCIDevice *vdev)\n \n vfio_intx_enable(vdev, &err);\n if (err) {\n- error_reportf_err(err, ERR_PREFIX, vdev->vbasedev.name);\n+ error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n }\n \n@@ -2196,7 +2196,7 @@ static void vfio_pci_post_reset(VFIOPCIDevice *vdev)\n \n vfio_intx_enable(vdev, &err);\n if (err) {\n- error_reportf_err(err, ERR_PREFIX, vdev->vbasedev.name);\n+ error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n \n for (nr = 0; nr < PCI_NUM_REGIONS - 1; ++nr) {\n@@ -2830,7 +2830,7 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)\n \n if (stat(vdev->vbasedev.sysfsdev, &st) < 0) {\n error_setg_errno(errp, errno, \"no such host device\");\n- error_prepend(errp, ERR_PREFIX, vdev->vbasedev.sysfsdev);\n+ error_prepend(errp, VFIO_MSG_PREFIX, vdev->vbasedev.sysfsdev);\n return;\n }\n \n@@ -3085,7 +3085,7 @@ out_teardown:\n vfio_teardown_msi(vdev);\n vfio_bars_exit(vdev);\n error:\n- error_prepend(errp, ERR_PREFIX, vdev->vbasedev.name);\n+ error_prepend(errp, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n \n static void vfio_instance_finalize(Object *obj)\ndiff --git a/hw/vfio/platform.c b/hw/vfio/platform.c\nindex baf236ae79..398db38f14 100644\n--- a/hw/vfio/platform.c\n+++ b/hw/vfio/platform.c\n@@ -690,7 +690,7 @@ out:\n }\n \n if (vdev->vbasedev.name) {\n- error_prepend(errp, ERR_PREFIX, vdev->vbasedev.name);\n+ error_prepend(errp, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n } else {\n error_prepend(errp, \"vfio error: \");\n }\ndiff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h\nindex 1d7630345b..1b434d02f6 100644\n--- a/include/hw/vfio/vfio-common.h\n+++ b/include/hw/vfio/vfio-common.h\n@@ -31,7 +31,6 @@\n #include <linux/vfio.h>\n #endif\n \n-#define ERR_PREFIX \"vfio error: %s: \"\n #define VFIO_MSG_PREFIX \"vfio %s: \"\n \n enum {\n", "prefixes": [ "v4", "06/38" ] }