Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985216/?format=api
{ "id": 985216, "url": "http://patchwork.ozlabs.org/api/patches/985216/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-19-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-19-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:42", "name": "[v4,18/38] vl: Clean up error reporting in parse_add_fd()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4f13aa6aca345127cdde9fd8bda8b50f96162c4f", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-19-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985216/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zln70Dzbz9sCW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:33:15 +1100 (AEDT)", "from localhost ([::1]:34526 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChGR-0004R6-RZ\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:33:12 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51095)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAd-000860-8U\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:12 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAb-00015a-RF\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:10 -0400", "from mx1.redhat.com ([209.132.183.28]:48020)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAb-00011h-At\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E280A80F6D\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:07 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id ADD981057054\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:07 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 560EE114168F; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:42 +0200", "Message-Id": "<20181017082702.5581-19-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 17 Oct 2018 08:27:07 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 18/38] vl: Clean up error reporting in\n\tparse_add_fd()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. parse_add_fd() does that, and then fails without\nsetting an error. Its caller main(), via qemu_opts_foreach(), is fine\nwith it, but clean it up anyway.\n\nAlso change call of cleanup_add_fd(), which can't fail, for symmetry.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n vl.c | 22 +++++++++-------------\n 1 file changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/vl.c b/vl.c\nindex 643121e5d4..2ef066ad61 100644\n--- a/vl.c\n+++ b/vl.c\n@@ -1059,12 +1059,12 @@ static int parse_add_fd(void *opaque, QemuOpts *opts, Error **errp)\n fd_opaque = qemu_opt_get(opts, \"opaque\");\n \n if (fd < 0) {\n- error_report(\"fd option is required and must be non-negative\");\n+ error_setg(errp, \"fd option is required and must be non-negative\");\n return -1;\n }\n \n if (fd <= STDERR_FILENO) {\n- error_report(\"fd cannot be a standard I/O stream\");\n+ error_setg(errp, \"fd cannot be a standard I/O stream\");\n return -1;\n }\n \n@@ -1074,12 +1074,12 @@ static int parse_add_fd(void *opaque, QemuOpts *opts, Error **errp)\n */\n flags = fcntl(fd, F_GETFD);\n if (flags == -1 || (flags & FD_CLOEXEC)) {\n- error_report(\"fd is not valid or already in use\");\n+ error_setg(errp, \"fd is not valid or already in use\");\n return -1;\n }\n \n if (fdset_id < 0) {\n- error_report(\"set option is required and must be non-negative\");\n+ error_setg(errp, \"set option is required and must be non-negative\");\n return -1;\n }\n \n@@ -1092,7 +1092,7 @@ static int parse_add_fd(void *opaque, QemuOpts *opts, Error **errp)\n }\n #endif\n if (dupfd == -1) {\n- error_report(\"error duplicating fd: %s\", strerror(errno));\n+ error_setg(errp, \"error duplicating fd: %s\", strerror(errno));\n return -1;\n }\n \n@@ -3983,15 +3983,11 @@ int main(int argc, char **argv, char **envp)\n }\n \n #ifndef _WIN32\n- if (qemu_opts_foreach(qemu_find_opts(\"add-fd\"),\n- parse_add_fd, NULL, NULL)) {\n- exit(1);\n- }\n+ qemu_opts_foreach(qemu_find_opts(\"add-fd\"),\n+ parse_add_fd, NULL, &error_fatal);\n \n- if (qemu_opts_foreach(qemu_find_opts(\"add-fd\"),\n- cleanup_add_fd, NULL, NULL)) {\n- exit(1);\n- }\n+ qemu_opts_foreach(qemu_find_opts(\"add-fd\"),\n+ cleanup_add_fd, NULL, &error_fatal);\n #endif\n \n current_machine = MACHINE(object_new(object_class_get_name(\n", "prefixes": [ "v4", "18/38" ] }