Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985215/?format=api
{ "id": 985215, "url": "http://patchwork.ozlabs.org/api/patches/985215/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-9-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-9-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:32", "name": "[v4,08/38] 9pfs: Fix CLI parsing crash on error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4521fe211d8a211fd13843a58c99abd566e28b64", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-9-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985215/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zlkz3w2Lz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:31:23 +1100 (AEDT)", "from localhost ([::1]:34518 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChEe-00032t-KH\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:31:20 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51034)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAb-000859-KO\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAY-000102-Eu\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from mx1.redhat.com ([209.132.183.28]:35520)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAY-0000y4-6J\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:06 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 60F0E3082DCF;\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 266E45F7C6;\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 326181132D3F; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:32 +0200", "Message-Id": "<20181017082702.5581-9-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.46]);\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 08/38] 9pfs: Fix CLI parsing crash on error", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Greg Kurz <groug@kaod.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. 9p-handle.c's handle_parse_opts() does that, and then\nfails without setting an error. Wrong. Its caller crashes when it\ntries to report the error:\n\n $ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=handle\n qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: warning: handle backend is deprecated\n qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: fsdev: No path specified\n Segmentation fault (core dumped)\n\nScrewed up when commit 91cda4e8f37 (v2.12.0) converted the function to\nError. Fix by calling error_setg() instead of error_report().\n\nFixes: 91cda4e8f372602795e3a2f4bd2e3adaf9f82255\nCc: Greg Kurz <groug@kaod.org>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nAcked-by: Greg Kurz <groug@kaod.org>\nReviewed-by: Eric Blake <eblake@redhat.com>\n---\n hw/9pfs/9p-handle.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c\nindex f3641dbe4a..3465b1ef30 100644\n--- a/hw/9pfs/9p-handle.c\n+++ b/hw/9pfs/9p-handle.c\n@@ -19,6 +19,7 @@\n #include <grp.h>\n #include <sys/socket.h>\n #include <sys/un.h>\n+#include \"qapi/error.h\"\n #include \"qemu/xattr.h\"\n #include \"qemu/cutils.h\"\n #include \"qemu/error-report.h\"\n@@ -655,12 +656,13 @@ static int handle_parse_opts(QemuOpts *opts, FsDriverEntry *fse, Error **errp)\n warn_report(\"handle backend is deprecated\");\n \n if (sec_model) {\n- error_report(\"Invalid argument security_model specified with handle fsdriver\");\n+ error_setg(errp,\n+ \"Invalid argument security_model specified with handle fsdriver\");\n return -1;\n }\n \n if (!path) {\n- error_report(\"fsdev: No path specified\");\n+ error_setg(errp, \"fsdev: No path specified\");\n return -1;\n }\n fse->path = g_strdup(path);\n", "prefixes": [ "v4", "08/38" ] }