Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985211/?format=api
{ "id": 985211, "url": "http://patchwork.ozlabs.org/api/patches/985211/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-4-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-4-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:27", "name": "[v4,03/38] block: Use warn_report() & friends to report warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2f056dda65fdf53989cf08fdda96e3d68eff0034", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-4-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985211/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985211/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42Zlgf3qfgz9sCW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:28:30 +1100 (AEDT)", "from localhost ([::1]:34499 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChBs-0000Te-1H\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:28:28 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51038)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAb-00085D-L6\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAY-0000zr-94\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from mx1.redhat.com ([209.132.183.28]:60806)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAX-0000xY-Te\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:06 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8677F30034A1;\n\tWed, 17 Oct 2018 08:27:04 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 895B95DD79;\n\tWed, 17 Oct 2018 08:27:03 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 206981132D7F; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:27 +0200", "Message-Id": "<20181017082702.5581-4-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.47]);\n\tWed, 17 Oct 2018 08:27:04 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 03/38] block: Use warn_report() & friends to\n\treport warnings", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>,\n\tHitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>,\n\tPeter Lieven <pl@kamp.de>, Ronnie Sahlberg <ronniesahlberg@gmail.com>,\n\tLiu Yuan <namei.unix@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() in a function that takes an Error ** argument\nis suspicious. Convert a few that are actually warnings to\nwarn_report().\n\nWhile there, split warnings consisting of multiple sentences to\nconform to conventions spelled out in warn_report()'s contract, and\nimprove a rather useless warning in sheepdog.c.\n\nCc: Kevin Wolf <kwolf@redhat.com>\nCc: Ronnie Sahlberg <ronniesahlberg@gmail.com>\nCc: Paolo Bonzini <pbonzini@redhat.com>\nCc: Peter Lieven <pl@kamp.de>\nCc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>\nCc: Liu Yuan <namei.unix@gmail.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\n---\n block/bochs.c | 8 ++++----\n block/cloop.c | 8 ++++----\n block/dmg.c | 8 ++++----\n block/iscsi.c | 2 +-\n block/rbd.c | 12 ++++++------\n block/sheepdog.c | 2 +-\n block/vvfat.c | 8 ++++----\n 7 files changed, 24 insertions(+), 24 deletions(-)", "diff": "diff --git a/block/bochs.c b/block/bochs.c\nindex 50c630047b..36c1b45bd2 100644\n--- a/block/bochs.c\n+++ b/block/bochs.c\n@@ -112,10 +112,10 @@ static int bochs_open(BlockDriverState *bs, QDict *options, int flags,\n }\n \n if (!bdrv_is_read_only(bs)) {\n- error_report(\"Opening bochs images without an explicit read-only=on \"\n- \"option is deprecated. Future versions will refuse to \"\n- \"open the image instead of automatically marking the \"\n- \"image read-only.\");\n+ warn_report(\"Opening bochs images without an explicit read-only=on \"\n+ \"option is deprecated\");\n+ error_printf(\"Future versions may refuse to open the image \"\n+ \"instead of automatically marking it read-only.\\n\");\n ret = bdrv_set_read_only(bs, true, errp); /* no write support yet */\n if (ret < 0) {\n return ret;\ndiff --git a/block/cloop.c b/block/cloop.c\nindex 2be68987bd..a558e67cb0 100644\n--- a/block/cloop.c\n+++ b/block/cloop.c\n@@ -74,10 +74,10 @@ static int cloop_open(BlockDriverState *bs, QDict *options, int flags,\n }\n \n if (!bdrv_is_read_only(bs)) {\n- error_report(\"Opening cloop images without an explicit read-only=on \"\n- \"option is deprecated. Future versions will refuse to \"\n- \"open the image instead of automatically marking the \"\n- \"image read-only.\");\n+ warn_report(\"Opening cloop images without an explicit read-only=on \"\n+ \"option is deprecated\");\n+ error_printf(\"Future versions may refuse to open the image \"\n+ \"instead of automatically marking it read-only.\\n\");\n ret = bdrv_set_read_only(bs, true, errp);\n if (ret < 0) {\n return ret;\ndiff --git a/block/dmg.c b/block/dmg.c\nindex c9b3c519c4..9fb814460d 100644\n--- a/block/dmg.c\n+++ b/block/dmg.c\n@@ -420,10 +420,10 @@ static int dmg_open(BlockDriverState *bs, QDict *options, int flags,\n }\n \n if (!bdrv_is_read_only(bs)) {\n- error_report(\"Opening dmg images without an explicit read-only=on \"\n- \"option is deprecated. Future versions will refuse to \"\n- \"open the image instead of automatically marking the \"\n- \"image read-only.\");\n+ warn_report(\"Opening dmg images without an explicit read-only=on \"\n+ \"option is deprecated\");\n+ error_printf(\"Future versions may refuse to open the image \"\n+ \"instead of automatically marking it read-only.\\n\");\n ret = bdrv_set_read_only(bs, true, errp);\n if (ret < 0) {\n return ret;\ndiff --git a/block/iscsi.c b/block/iscsi.c\nindex bb69faf34a..73998c2860 100644\n--- a/block/iscsi.c\n+++ b/block/iscsi.c\n@@ -1844,7 +1844,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,\n iscsi_set_timeout(iscsi, timeout);\n #else\n if (timeout) {\n- error_report(\"iSCSI: ignoring timeout value for libiscsi <1.15.0\");\n+ warn_report(\"iSCSI: ignoring timeout value for libiscsi <1.15.0\");\n }\n #endif\n \ndiff --git a/block/rbd.c b/block/rbd.c\nindex 014c68d629..6e26bac170 100644\n--- a/block/rbd.c\n+++ b/block/rbd.c\n@@ -750,8 +750,8 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,\n /* Take care whenever deciding to actually deprecate; once this ability\n * is removed, we will not be able to open any images with legacy-styled\n * backing image strings. */\n- error_report(\"RBD options encoded in the filename as keyvalue pairs \"\n- \"is deprecated\");\n+ warn_report(\"RBD options encoded in the filename as keyvalue pairs \"\n+ \"is deprecated\");\n }\n \n /* Remove the processed options from the QDict (the visitor processes\n@@ -781,10 +781,10 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,\n * leave as-is */\n if (s->snap != NULL) {\n if (!bdrv_is_read_only(bs)) {\n- error_report(\"Opening rbd snapshots without an explicit \"\n- \"read-only=on option is deprecated. Future versions \"\n- \"will refuse to open the image instead of \"\n- \"automatically marking the image read-only.\");\n+ warn_report(\"Opening rbd snapshots without an explicit \"\n+ \"read-only=on option is deprecated\");\n+ error_printf(\"Future versions may refuse to open the image \"\n+ \"instead of automatically marking it read-only.\\n\");\n r = bdrv_set_read_only(bs, true, &local_err);\n if (r < 0) {\n error_propagate(errp, local_err);\ndiff --git a/block/sheepdog.c b/block/sheepdog.c\nindex b229a664d9..0125df9d49 100644\n--- a/block/sheepdog.c\n+++ b/block/sheepdog.c\n@@ -572,7 +572,7 @@ static int connect_to_sdog(BDRVSheepdogState *s, Error **errp)\n if (s->addr->type == SOCKET_ADDRESS_TYPE_INET && fd >= 0) {\n int ret = socket_set_nodelay(fd);\n if (ret < 0) {\n- error_report(\"%s\", strerror(errno));\n+ warn_report(\"can't set TCP_NODELAY: %s\", strerror(errno));\n }\n }\n \ndiff --git a/block/vvfat.c b/block/vvfat.c\nindex fc41841a5c..8f3f9e9a93 100644\n--- a/block/vvfat.c\n+++ b/block/vvfat.c\n@@ -1263,10 +1263,10 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,\n goto fail;\n }\n } else if (!bdrv_is_read_only(bs)) {\n- error_report(\"Opening non-rw vvfat images without an explicit \"\n- \"read-only=on option is deprecated. Future versions \"\n- \"will refuse to open the image instead of \"\n- \"automatically marking the image read-only.\");\n+ warn_report(\"Opening non-rw vvfat images without an explicit \"\n+ \"read-only=on option is deprecated\");\n+ error_printf(\"Future versions may refuse to open the image \"\n+ \"instead of automatically marking it read-only.\\n\");\n /* read only is the default for safety */\n ret = bdrv_set_read_only(bs, true, &local_err);\n if (ret < 0) {\n", "prefixes": [ "v4", "03/38" ] }