Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/984342/?format=api
{ "id": 984342, "url": "http://patchwork.ozlabs.org/api/patches/984342/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181015191829.17115-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181015191829.17115-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2018-10-15T19:18:27", "name": "[net-next,1/3] fm10k: fix SM mailbox full condition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e145deff718901c103bff7780efd4f1b110d1edd", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181015191829.17115-2-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 70890, "url": "http://patchwork.ozlabs.org/api/series/70890/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=70890", "date": "2018-10-15T19:18:27", "name": "fm10k: driver updates", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/70890/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/984342/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/984342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42YpBj0J2vz9s1x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Oct 2018 06:18:36 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 880FD85F6D;\n\tMon, 15 Oct 2018 19:18:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xp_ZJ5dnmxrY; Mon, 15 Oct 2018 19:18:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A390185F33;\n\tMon, 15 Oct 2018 19:18:34 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B92621BFAB2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Oct 2018 19:18:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B5FAF8708A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Oct 2018 19:18:33 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KgnV4z9nqYRg for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Oct 2018 19:18:33 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DE5AC8690F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Oct 2018 19:18:32 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Oct 2018 12:18:32 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([10.166.244.182])\n\tby fmsmga004.fm.intel.com with ESMTP; 15 Oct 2018 12:18:31 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,385,1534834800\"; d=\"scan'208\";a=\"97665785\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 15 Oct 2018 12:18:27 -0700", "Message-Id": "<20181015191829.17115-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.18.0.219.gaf81d287a9da", "In-Reply-To": "<20181015191829.17115-1-jacob.e.keller@intel.com>", "References": "<20181015191829.17115-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [net-next 1/3] fm10k: fix SM mailbox full\n\tcondition", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Ngai-Mint Kwan <ngai-mint.kwan@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>\n\nCurrent condition will always incorrectly report a full SM mailbox if an\nIES API application is not running. Due to this, the\n\"fm10k_service_task\" will be infinitely queued into the driver's\nworkqueue. This, in turn, will cause a \"kworker\" thread to report 100%\nCPU utilization and might cause \"soft lockup\" events or system crashes.\n\nTo fix this issue, a new condition is added to determine if the SM\nmailbox is in the correct state of FM10K_STATE_OPEN before proceeding.\nIn other words, an instance of the IES API must be running. If there is,\nthe remainder of the flow stays the same which is to determine if the SM\nmailbox capacity has been exceeded or not and take appropriate action.\n\nSigned-off-by: Ngai-Mint Kwan <ngai-mint.kwan@intel.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\nindex e707d717012f..74160c2095ee 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n@@ -244,7 +244,8 @@ s32 fm10k_iov_mbx(struct fm10k_intfc *interface)\n \t\t}\n \n \t\t/* guarantee we have free space in the SM mailbox */\n-\t\tif (!hw->mbx.ops.tx_ready(&hw->mbx, FM10K_VFMBX_MSG_MTU)) {\n+\t\tif (hw->mbx.state == FM10K_STATE_OPEN &&\n+\t\t !hw->mbx.ops.tx_ready(&hw->mbx, FM10K_VFMBX_MSG_MTU)) {\n \t\t\t/* keep track of how many times this occurs */\n \t\t\tinterface->hw_sm_mbx_full++;\n \n", "prefixes": [ "net-next", "1/3" ] }