Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/982988/?format=api
{ "id": 982988, "url": "http://patchwork.ozlabs.org/api/patches/982988/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181012111339.1361-1-mlichvar@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181012111339.1361-1-mlichvar@redhat.com>", "list_archive_url": null, "date": "2018-10-12T11:13:39", "name": "igb: shorten maximum PHC timecounter update interval", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e6dabd43005ac62aa84693f1d4b1a3b8681c54fb", "submitter": { "id": 17040, "url": "http://patchwork.ozlabs.org/api/people/17040/?format=api", "name": "Miroslav Lichvar", "email": "mlichvar@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181012111339.1361-1-mlichvar@redhat.com/mbox/", "series": [ { "id": 70457, "url": "http://patchwork.ozlabs.org/api/series/70457/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=70457", "date": "2018-10-12T11:13:39", "name": "igb: shorten maximum PHC timecounter update interval", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/70457/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/982988/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/982988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42WlZj0Bffz9s1c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 12 Oct 2018 22:13:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 99D7787BBF;\n\tFri, 12 Oct 2018 11:13:46 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pWl-pgDk9jbQ; Fri, 12 Oct 2018 11:13:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DB66687B46;\n\tFri, 12 Oct 2018 11:13:44 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 819701BF41F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 11:13:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7E38E226AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 11:13:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NlisuxasLC85 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 11:13:42 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D04FE226A9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 11:13:42 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 08ABD307D986;\n\tFri, 12 Oct 2018 11:13:42 +0000 (UTC)", "from holly.tpb.lab.eng.brq.redhat.com\n\t(holly.tpb.lab.eng.brq.redhat.com [10.43.134.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B05C710027D8;\n\tFri, 12 Oct 2018 11:13:40 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.48]); Fri, 12 Oct 2018 11:13:42 +0000 (UTC)" ], "From": "Miroslav Lichvar <mlichvar@redhat.com>", "To": "intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org", "Date": "Fri, 12 Oct 2018 13:13:39 +0200", "Message-Id": "<20181012111339.1361-1-mlichvar@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Subject": "[Intel-wired-lan] [PATCH] igb: shorten maximum PHC timecounter\n\tupdate interval", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Thomas Gleixner <tglx@linutronix.de>,\n\tRichard Cochran <richardcochran@gmail.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The timecounter needs to be updated at least once per ~550 seconds in\norder to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old\ntimestamp.\n\nSince commit 500462a9d (\"timers: Switch to a non-cascading wheel\"),\nscheduling of delayed work seems to be less accurate and a requested\ndelay of 540 seconds may actually be longer than 550 seconds. Shorten\nthe delay to 480 seconds to be sure the timecounter is updated in time.\n\nThis fixes an issue with HW timestamps on 82580/I350/I354 being off by\n~1100 seconds for few seconds every ~9 minutes.\n\nCc: Jacob Keller <jacob.e.keller@intel.com>\nCc: Richard Cochran <richardcochran@gmail.com>\nCc: Thomas Gleixner <tglx@linutronix.de>\nSigned-off-by: Miroslav Lichvar <mlichvar@redhat.com>\n---\n drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c\nindex 9f4d700e09df..29ced6b74d36 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ptp.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ptp.c\n@@ -51,9 +51,15 @@\n *\n * The 40 bit 82580 SYSTIM overflows every\n * 2^40 * 10^-9 / 60 = 18.3 minutes.\n+ *\n+ * SYSTIM is converted to real time using a timecounter. As\n+ * timecounter_cyc2time() allows old timestamps, the timecounter\n+ * needs to be updated at least once per half of the SYSTIM interval.\n+ * Scheduling of delayed work is not very accurate, so we aim for 8\n+ * minutes to be sure the actual interval is shorter than 9.16 minutes.\n */\n \n-#define IGB_SYSTIM_OVERFLOW_PERIOD\t(HZ * 60 * 9)\n+#define IGB_SYSTIM_OVERFLOW_PERIOD\t(HZ * 60 * 8)\n #define IGB_PTP_TX_TIMEOUT\t\t(HZ * 15)\n #define INCPERIOD_82576\t\t\tBIT(E1000_TIMINCA_16NS_SHIFT)\n #define INCVALUE_82576_MASK\t\tGENMASK(E1000_TIMINCA_16NS_SHIFT - 1, 0)\n", "prefixes": [] }