Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/982885/?format=api
{ "id": 982885, "url": "http://patchwork.ozlabs.org/api/patches/982885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181012071709.GA10212@mwanda/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181012071709.GA10212@mwanda>", "list_archive_url": null, "date": "2018-10-12T07:17:09", "name": "ice: remove an unneeded NULL check", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "895e996c0ff234ec62062cc87c076213043104dd", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181012071709.GA10212@mwanda/mbox/", "series": [ { "id": 70418, "url": "http://patchwork.ozlabs.org/api/series/70418/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=70418", "date": "2018-10-12T07:17:09", "name": "ice: remove an unneeded NULL check", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/70418/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/982885/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/982885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.b=\"ZaWCxYFy\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42WfKv6kPkz9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 12 Oct 2018 18:17:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 04F0086EE4;\n\tFri, 12 Oct 2018 07:17:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TX-9FSteYdSe; Fri, 12 Oct 2018 07:17:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B1FC486EDC;\n\tFri, 12 Oct 2018 07:17:20 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 06B681BFDB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 07:17:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 02A838795A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 07:17:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1TOCVHPmzOU6 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 07:17:18 +0000 (UTC)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id B1A848700E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 12 Oct 2018 07:17:18 +0000 (UTC)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n\tby userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id\n\tw9C7EBq9188913; Fri, 12 Oct 2018 07:17:17 GMT", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp2120.oracle.com with ESMTP id 2mxnprgnat-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 12 Oct 2018 07:17:17 +0000", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tw9C7HGvg016543\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 12 Oct 2018 07:17:16 GMT", "from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9C7HGGv031000; \n\tFri, 12 Oct 2018 07:17:16 GMT", "from mwanda (/197.232.248.111)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Fri, 12 Oct 2018 07:17:15 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=date : from : to : cc\n\t: subject : message-id : mime-version : content-type;\n\ts=corp-2018-07-02; \n\tbh=m996+FQkONUwF93J9UVWS2VW/0b+x+5+5/+KDfCN8Rc=;\n\tb=ZaWCxYFyLJwCEusfnMXC50NY2n/3HWIHOv4DITwJn00XNWy/GyZtvsvkA4Hka99e0uIo\n\tTbnNnQqi67U464qK85u1xxHoZb4eB5oEwNCH7lhpgdkAJv+4sqb6gnr937XdxVfoyPLe\n\tgeIO+cnj4cLHQ9RqphuGXh0nbasw4pm0v45EcESS1jG2qEQLRrIQr8Aea69AGqSkW3sg\n\t+1bCIJwshnlCTpmC5Wsh0xFy2QIJSNyRNACPW2y4DAFec/nmhWrQf1ohwdqlcrxX/gTg\n\tgaOJJf+qZ8dobWB+03swktgMJmlMk14ye/lcFP754GSEPBb+CnCMya7kxoKpeJwGcq4D\n\tHA== ", "Date": "Fri, 12 Oct 2018 10:17:09 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tDave Ertman <david.m.ertman@intel.com>", "Message-ID": "<20181012071709.GA10212@mwanda>", "MIME-Version": "1.0", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "Mutt/1.10.1 (2018-07-13)", "X-Proofpoint-Virus-Version": "vendor=nai engine=5900 definitions=9043\n\tsignatures=668706", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 suspectscore=0\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1807170000 definitions=main-1810120073", "Subject": "[Intel-wired-lan] [PATCH] ice: remove an unneeded NULL check", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We added a NULL check in commit 072f0c3db9da (\"ice: Fix potential null\npointer issues\") but it causes static checker warnings.\n\n drivers/net/ethernet/intel/ice/ice_switch.c:2145 ice_add_to_vsi_fltr_list()\n warn: address of 'fm_entry->fltr_info' is non-NULL\n\nWe can just remove it.\n\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c\nindex 33403f39f1b3..a9ef19da6e61 100644\n--- a/drivers/net/ethernet/intel/ice/ice_switch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_switch.c\n@@ -2142,7 +2142,7 @@ ice_add_to_vsi_fltr_list(struct ice_hw *hw, u16 vsi_handle,\n \t\tstruct ice_fltr_info *fi;\n \n \t\tfi = &fm_entry->fltr_info;\n-\t\tif (!fi || !ice_vsi_uses_fltr(fm_entry, vsi_handle))\n+\t\tif (!ice_vsi_uses_fltr(fm_entry, vsi_handle))\n \t\t\tcontinue;\n \n \t\tstatus = ice_add_entry_to_vsi_fltr_list(hw, vsi_handle,\n", "prefixes": [] }