Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 980275,
    "url": "http://patchwork.ozlabs.org/api/patches/980275/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-2-dsahern@kernel.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20181008031644.15989-2-dsahern@kernel.org>",
    "list_archive_url": null,
    "date": "2018-10-08T03:16:22",
    "name": "[v2,net-next,01/23] netlink: Pass extack to dump handlers",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "76a204be6bf4b5d67d9578de954395694266c7a2",
    "submitter": {
        "id": 74101,
        "url": "http://patchwork.ozlabs.org/api/people/74101/?format=api",
        "name": "David Ahern",
        "email": "dsahern@kernel.org"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-2-dsahern@kernel.org/mbox/",
    "series": [
        {
            "id": 69470,
            "url": "http://patchwork.ozlabs.org/api/series/69470/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=69470",
            "date": "2018-10-08T03:16:21",
            "name": "rtnetlink: Add support for rigid checking of data in dump request",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/69470/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/980275/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/980275/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming-netdev@ozlabs.org",
        "Delivered-To": "patchwork-incoming-netdev@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=kernel.org",
            "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"vh6OrMOY\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 42T5Bz29vlz9sCV\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon,  8 Oct 2018 14:17:31 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1726883AbeJHK0R (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tMon, 8 Oct 2018 06:26:17 -0400",
            "from mail.kernel.org ([198.145.29.99]:42534 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726113AbeJHK0R (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 8 Oct 2018 06:26:17 -0400",
            "from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com\n\t[216.129.126.126])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 0C7192087D;\n\tMon,  8 Oct 2018 03:16:47 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1538968607;\n\tbh=disE0VR1w+0Rl1A7akdzyfaPWXOEkiLSF9SOoPSsvbA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vh6OrMOYOj+uEMk2Xgg3aKebn7bRNit/pM1ARVOlNT8703cwelTW4S2aMh4AHhD2P\n\tqGXckApln23rrbmXEGh9f8WelvsfYUdOhBXBIj6wz/JdW44UV/JGaEkruWTJpFUZMY\n\t4bE6gL4PPwzkipsPS526ur6fM2xKQQVzqxW6Lldc=",
        "From": "David Ahern <dsahern@kernel.org>",
        "To": "netdev@vger.kernel.org, davem@davemloft.net",
        "Cc": "christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org,\n\tDavid Ahern <dsahern@gmail.com>",
        "Subject": "[PATCH v2 net-next 01/23] netlink: Pass extack to dump handlers",
        "Date": "Sun,  7 Oct 2018 20:16:22 -0700",
        "Message-Id": "<20181008031644.15989-2-dsahern@kernel.org>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20181008031644.15989-1-dsahern@kernel.org>",
        "References": "<20181008031644.15989-1-dsahern@kernel.org>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: David Ahern <dsahern@gmail.com>\n\nDeclare extack in netlink_dump and pass to dump handlers via\nnetlink_callback. Add any extack message after the dump_done_errno\nallowing error messages to be returned. This will be useful when\nstrict checking is done on dump requests, returning why the dump\nfails EINVAL.\n\nSigned-off-by: David Ahern <dsahern@gmail.com>\nAcked-by: Christian Brauner <christian@brauner.io>\n---\n include/linux/netlink.h  |  1 +\n net/netlink/af_netlink.c | 12 +++++++++++-\n 2 files changed, 12 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/include/linux/netlink.h b/include/linux/netlink.h\nindex 71f121b66ca8..88c8a2d83eb3 100644\n--- a/include/linux/netlink.h\n+++ b/include/linux/netlink.h\n@@ -176,6 +176,7 @@ struct netlink_callback {\n \tvoid\t\t\t*data;\n \t/* the module that dump function belong to */\n \tstruct module\t\t*module;\n+\tstruct netlink_ext_ack\t*extack;\n \tu16\t\t\tfamily;\n \tu16\t\t\tmin_dump_alloc;\n \tunsigned int\t\tprev_seq, seq;\ndiff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c\nindex e3a0538ec0be..7ac585f33a9e 100644\n--- a/net/netlink/af_netlink.c\n+++ b/net/netlink/af_netlink.c\n@@ -2171,6 +2171,7 @@ EXPORT_SYMBOL(__nlmsg_put);\n static int netlink_dump(struct sock *sk)\n {\n \tstruct netlink_sock *nlk = nlk_sk(sk);\n+\tstruct netlink_ext_ack extack = {};\n \tstruct netlink_callback *cb;\n \tstruct sk_buff *skb = NULL;\n \tstruct nlmsghdr *nlh;\n@@ -2222,8 +2223,11 @@ static int netlink_dump(struct sock *sk)\n \tskb_reserve(skb, skb_tailroom(skb) - alloc_size);\n \tnetlink_skb_set_owner_r(skb, sk);\n \n-\tif (nlk->dump_done_errno > 0)\n+\tif (nlk->dump_done_errno > 0) {\n+\t\tcb->extack = &extack;\n \t\tnlk->dump_done_errno = cb->dump(skb, cb);\n+\t\tcb->extack = NULL;\n+\t}\n \n \tif (nlk->dump_done_errno > 0 ||\n \t    skb_tailroom(skb) < nlmsg_total_size(sizeof(nlk->dump_done_errno))) {\n@@ -2246,6 +2250,12 @@ static int netlink_dump(struct sock *sk)\n \tmemcpy(nlmsg_data(nlh), &nlk->dump_done_errno,\n \t       sizeof(nlk->dump_done_errno));\n \n+\tif (extack._msg && nlk->flags & NETLINK_F_EXT_ACK) {\n+\t\tnlh->nlmsg_flags |= NLM_F_ACK_TLVS;\n+\t\tif (!nla_put_string(skb, NLMSGERR_ATTR_MSG, extack._msg))\n+\t\t\tnlmsg_end(skb, nlh);\n+\t}\n+\n \tif (sk_filter(sk, skb))\n \t\tkfree_skb(skb);\n \telse\n",
    "prefixes": [
        "v2",
        "net-next",
        "01/23"
    ]
}