Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/980269/?format=api
{ "id": 980269, "url": "http://patchwork.ozlabs.org/api/patches/980269/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-14-dsahern@kernel.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181008031644.15989-14-dsahern@kernel.org>", "list_archive_url": null, "date": "2018-10-08T03:16:34", "name": "[v2,net-next,13/23] rtnetlink: Update ipmr_rtm_dumplink for strict data checking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b2d4ea46ba2128af2b8d438fc9888fe51285e5be", "submitter": { "id": 74101, "url": "http://patchwork.ozlabs.org/api/people/74101/?format=api", "name": "David Ahern", "email": "dsahern@kernel.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-14-dsahern@kernel.org/mbox/", "series": [ { "id": 69470, "url": "http://patchwork.ozlabs.org/api/series/69470/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=69470", "date": "2018-10-08T03:16:21", "name": "rtnetlink: Add support for rigid checking of data in dump request", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/69470/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/980269/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/980269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=kernel.org", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"IQyi9S4W\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 42T5Bh6YV9z9sCr\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon, 8 Oct 2018 14:17:16 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727040AbeJHK0p (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tMon, 8 Oct 2018 06:26:45 -0400", "from mail.kernel.org ([198.145.29.99]:42578 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726113AbeJHK0U (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 8 Oct 2018 06:26:20 -0400", "from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com\n\t[216.129.126.126])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5F6B62089D;\n\tMon, 8 Oct 2018 03:16:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1538968610;\n\tbh=Cov6Trg691JRIpvCbNQH43/RN76m/eDIcM3eU/ZzV/U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IQyi9S4WB4EUxLbTgAdXOmT9jXho325Pzp3NUfUqjMWedUnzcISlNOrEYd3OFBnLw\n\tRc0e9et2JJ3gh0RkxZRkL3xAqd+S3zJOzy3Zv8HMrxn8on+cMLF029sDY3bnCcDUbi\n\tmP/Nr3vFzfmPTRkoT8Zfuo45ynW12cZRIAjeuSso=", "From": "David Ahern <dsahern@kernel.org>", "To": "netdev@vger.kernel.org, davem@davemloft.net", "Cc": "christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org,\n\tDavid Ahern <dsahern@gmail.com>", "Subject": "[PATCH v2 net-next 13/23] rtnetlink: Update ipmr_rtm_dumplink for\n\tstrict data checking", "Date": "Sun, 7 Oct 2018 20:16:34 -0700", "Message-Id": "<20181008031644.15989-14-dsahern@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20181008031644.15989-1-dsahern@kernel.org>", "References": "<20181008031644.15989-1-dsahern@kernel.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: David Ahern <dsahern@gmail.com>\n\nUpdate ipmr_rtm_dumplink for strict data checking. If the flag is set,\nthe dump request is expected to have an ifinfomsg struct as the header.\nAll elements of the struct are expected to be 0 and no attributes can\nbe appended.\n\nSigned-off-by: David Ahern <dsahern@gmail.com>\n---\n net/ipv4/ipmr.c | 32 ++++++++++++++++++++++++++++++++\n 1 file changed, 32 insertions(+)", "diff": "diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c\nindex 5660adcf7a04..e7322e407bb4 100644\n--- a/net/ipv4/ipmr.c\n+++ b/net/ipv4/ipmr.c\n@@ -2710,6 +2710,31 @@ static bool ipmr_fill_vif(struct mr_table *mrt, u32 vifid, struct sk_buff *skb)\n \treturn true;\n }\n \n+static int ipmr_valid_dumplink(const struct nlmsghdr *nlh,\n+\t\t\t struct netlink_ext_ack *extack)\n+{\n+\tstruct ifinfomsg *ifm;\n+\n+\tif (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) {\n+\t\tNL_SET_ERR_MSG(extack, \"ipv4: Invalid header for ipmr link dump\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (nlmsg_attrlen(nlh, sizeof(*ifm))) {\n+\t\tNL_SET_ERR_MSG(extack, \"Invalid data after header in ipmr link dump\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tifm = nlmsg_data(nlh);\n+\tif (ifm->__ifi_pad || ifm->ifi_type || ifm->ifi_flags ||\n+\t ifm->ifi_change || ifm->ifi_index) {\n+\t\tNL_SET_ERR_MSG(extack, \"Invalid values in header for ipmr link dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int ipmr_rtm_dumplink(struct sk_buff *skb, struct netlink_callback *cb)\n {\n \tstruct net *net = sock_net(skb->sk);\n@@ -2718,6 +2743,13 @@ static int ipmr_rtm_dumplink(struct sk_buff *skb, struct netlink_callback *cb)\n \tunsigned int e = 0, s_e;\n \tstruct mr_table *mrt;\n \n+\tif (cb->strict_check) {\n+\t\tint err = ipmr_valid_dumplink(cb->nlh, cb->extack);\n+\n+\t\tif (err < 0)\n+\t\t\treturn err;\n+\t}\n+\n \ts_t = cb->args[0];\n \ts_e = cb->args[1];\n \n", "prefixes": [ "v2", "net-next", "13/23" ] }