Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/980267/?format=api
{ "id": 980267, "url": "http://patchwork.ozlabs.org/api/patches/980267/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-13-dsahern@kernel.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181008031644.15989-13-dsahern@kernel.org>", "list_archive_url": null, "date": "2018-10-08T03:16:33", "name": "[v2,net-next,12/23] rtnetlink: Update inet6_dump_ifinfo for strict data checking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3418978fe9d5ad48586bfc4c958753514b5974e0", "submitter": { "id": 74101, "url": "http://patchwork.ozlabs.org/api/people/74101/?format=api", "name": "David Ahern", "email": "dsahern@kernel.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-13-dsahern@kernel.org/mbox/", "series": [ { "id": 69470, "url": "http://patchwork.ozlabs.org/api/series/69470/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=69470", "date": "2018-10-08T03:16:21", "name": "rtnetlink: Add support for rigid checking of data in dump request", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/69470/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/980267/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/980267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=kernel.org", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"x6oBGBCR\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 42T5Bf6tcCz9sCV\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon, 8 Oct 2018 14:17:14 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1726793AbeJHK0n (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tMon, 8 Oct 2018 06:26:43 -0400", "from mail.kernel.org ([198.145.29.99]:42562 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726923AbeJHK0U (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 8 Oct 2018 06:26:20 -0400", "from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com\n\t[216.129.126.126])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 1C0A92145D;\n\tMon, 8 Oct 2018 03:16:50 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1538968610;\n\tbh=Blh4t3TrBxbwxPAT1/Rb5nEsWuVHCAo0Ob3blTYMw2I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=x6oBGBCRvLctha5S+a+J2xBt9syQGXzxOy2UGioM6qsjwo15sN1ZJ9PcQZxP09iYH\n\tqlXhRDtDjU15yixSRJM4srGrUEau8FNrBvp18nACdM5NMn5//e+w6l/CJqSDbu229+\n\tcylbqzOB2K7SDXs+jtJS4m1rS+Flp4U3bCHISMLg=", "From": "David Ahern <dsahern@kernel.org>", "To": "netdev@vger.kernel.org, davem@davemloft.net", "Cc": "christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org,\n\tDavid Ahern <dsahern@gmail.com>", "Subject": "[PATCH v2 net-next 12/23] rtnetlink: Update inet6_dump_ifinfo for\n\tstrict data checking", "Date": "Sun, 7 Oct 2018 20:16:33 -0700", "Message-Id": "<20181008031644.15989-13-dsahern@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20181008031644.15989-1-dsahern@kernel.org>", "References": "<20181008031644.15989-1-dsahern@kernel.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: David Ahern <dsahern@gmail.com>\n\nUpdate inet6_dump_ifinfo for strict data checking. If the flag is\nset, the dump request is expected to have an ifinfomsg struct as\nthe header. All elements of the struct are expected to be 0 and no\nattributes can be appended.\n\nSigned-off-by: David Ahern <dsahern@gmail.com>\n---\n net/ipv6/addrconf.c | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)", "diff": "diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c\nindex 095d3f56f0a9..ce071d85ad00 100644\n--- a/net/ipv6/addrconf.c\n+++ b/net/ipv6/addrconf.c\n@@ -5644,6 +5644,31 @@ static int inet6_fill_ifinfo(struct sk_buff *skb, struct inet6_dev *idev,\n \treturn -EMSGSIZE;\n }\n \n+static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh,\n+\t\t\t\t struct netlink_ext_ack *extack)\n+{\n+\tstruct ifinfomsg *ifm;\n+\n+\tif (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Invalid header for link dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (nlmsg_attrlen(nlh, sizeof(*ifm))) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Invalid data after header\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tifm = nlmsg_data(nlh);\n+\tif (ifm->__ifi_pad || ifm->ifi_type || ifm->ifi_flags ||\n+\t ifm->ifi_change || ifm->ifi_index) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Invalid values in header for dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int inet6_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)\n {\n \tstruct net *net = sock_net(skb->sk);\n@@ -5653,6 +5678,16 @@ static int inet6_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)\n \tstruct inet6_dev *idev;\n \tstruct hlist_head *head;\n \n+\t/* only requests using strict checking can pass data to\n+\t * influence the dump\n+\t */\n+\tif (cb->strict_check) {\n+\t\tint err = inet6_valid_dump_ifinfo(cb->nlh, cb->extack);\n+\n+\t\tif (err < 0)\n+\t\t\treturn err;\n+\t}\n+\n \ts_h = cb->args[0];\n \ts_idx = cb->args[1];\n \n", "prefixes": [ "v2", "net-next", "12/23" ] }