Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 980259,
    "url": "http://patchwork.ozlabs.org/api/patches/980259/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-22-dsahern@kernel.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20181008031644.15989-22-dsahern@kernel.org>",
    "list_archive_url": null,
    "date": "2018-10-08T03:16:42",
    "name": "[v2,net-next,21/23] net/bridge: Update br_mdb_dump for strict data checking",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f725ccfde5d505992c78ca0c9b892deda8d5b2d1",
    "submitter": {
        "id": 74101,
        "url": "http://patchwork.ozlabs.org/api/people/74101/?format=api",
        "name": "David Ahern",
        "email": "dsahern@kernel.org"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-22-dsahern@kernel.org/mbox/",
    "series": [
        {
            "id": 69470,
            "url": "http://patchwork.ozlabs.org/api/series/69470/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=69470",
            "date": "2018-10-08T03:16:21",
            "name": "rtnetlink: Add support for rigid checking of data in dump request",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/69470/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/980259/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/980259/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming-netdev@ozlabs.org",
        "Delivered-To": "patchwork-incoming-netdev@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=kernel.org",
            "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"DthkH5ZY\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 42T5BH1h7tz9sCV\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon,  8 Oct 2018 14:16:55 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727078AbeJHK0X (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tMon, 8 Oct 2018 06:26:23 -0400",
            "from mail.kernel.org ([198.145.29.99]:42626 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727028AbeJHK0W (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 8 Oct 2018 06:26:22 -0400",
            "from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com\n\t[216.129.126.126])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 9212520841;\n\tMon,  8 Oct 2018 03:16:52 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1538968612;\n\tbh=1Gp0BqKSK1Hja4GZ97+TtZMm6hN2YlWS+oG1NgrJG/I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DthkH5ZY+EBdTeuFcqUY4BRnB9gHnbklThzoD8nlHUkoZ0AySwf4q+ws4nyL8mAVv\n\tWlyAeuuT1UKdggKFW7/k8hyBwGMvRUlxL/9uXNMO95DKBumgnWRVX7XNlBBrDutsqV\n\tXV+c0gJFacMnVsVkHKaXcQKh/by7DC02ve9+x8+Q=",
        "From": "David Ahern <dsahern@kernel.org>",
        "To": "netdev@vger.kernel.org, davem@davemloft.net",
        "Cc": "christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org,\n\tDavid Ahern <dsahern@gmail.com>",
        "Subject": "[PATCH v2 net-next 21/23] net/bridge: Update br_mdb_dump for strict\n\tdata checking",
        "Date": "Sun,  7 Oct 2018 20:16:42 -0700",
        "Message-Id": "<20181008031644.15989-22-dsahern@kernel.org>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20181008031644.15989-1-dsahern@kernel.org>",
        "References": "<20181008031644.15989-1-dsahern@kernel.org>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: David Ahern <dsahern@gmail.com>\n\nUpdate br_mdb_dump for strict data checking. If the flag is set,\nthe dump request is expected to have a br_port_msg struct as the\nheader. All elements of the struct are expected to be 0 and no\nattributes can be appended.\n\nSigned-off-by: David Ahern <dsahern@gmail.com>\n---\n net/bridge/br_mdb.c | 30 ++++++++++++++++++++++++++++++\n 1 file changed, 30 insertions(+)",
    "diff": "diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c\nindex a4a848bf827b..a7ea2d431714 100644\n--- a/net/bridge/br_mdb.c\n+++ b/net/bridge/br_mdb.c\n@@ -162,6 +162,29 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,\n \treturn err;\n }\n \n+static int br_mdb_valid_dump_req(const struct nlmsghdr *nlh,\n+\t\t\t\t struct netlink_ext_ack *extack)\n+{\n+\tstruct br_port_msg *bpm;\n+\n+\tif (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bpm))) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Invalid header for mdb dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tbpm = nlmsg_data(nlh);\n+\tif (bpm->ifindex) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Filtering by device index is not supported for mdb dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\tif (nlmsg_attrlen(nlh, sizeof(*bpm))) {\n+\t\tNL_SET_ERR_MSG(extack, \"Invalid data after header in mdb dump request\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int br_mdb_dump(struct sk_buff *skb, struct netlink_callback *cb)\n {\n \tstruct net_device *dev;\n@@ -169,6 +192,13 @@ static int br_mdb_dump(struct sk_buff *skb, struct netlink_callback *cb)\n \tstruct nlmsghdr *nlh = NULL;\n \tint idx = 0, s_idx;\n \n+\tif (cb->strict_check) {\n+\t\tint err = br_mdb_valid_dump_req(cb->nlh, cb->extack);\n+\n+\t\tif (err < 0)\n+\t\t\treturn err;\n+\t}\n+\n \ts_idx = cb->args[0];\n \n \trcu_read_lock();\n",
    "prefixes": [
        "v2",
        "net-next",
        "21/23"
    ]
}