Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/980254/?format=api
{ "id": 980254, "url": "http://patchwork.ozlabs.org/api/patches/980254/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-4-dsahern@kernel.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181008031644.15989-4-dsahern@kernel.org>", "list_archive_url": null, "date": "2018-10-08T03:16:24", "name": "[v2,net-next,03/23] net: Add extack to nlmsg_parse", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6c43dc7f19a8b16fc3feb3fb717566221d23b7f4", "submitter": { "id": 74101, "url": "http://patchwork.ozlabs.org/api/people/74101/?format=api", "name": "David Ahern", "email": "dsahern@kernel.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20181008031644.15989-4-dsahern@kernel.org/mbox/", "series": [ { "id": 69470, "url": "http://patchwork.ozlabs.org/api/series/69470/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=69470", "date": "2018-10-08T03:16:21", "name": "rtnetlink: Add support for rigid checking of data in dump request", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/69470/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/980254/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/980254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=pass (p=none dis=none) header.from=kernel.org", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"DyTuFG44\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 42T5BC14spz9sCr\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon, 8 Oct 2018 14:16:51 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1726911AbeJHK0S (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tMon, 8 Oct 2018 06:26:18 -0400", "from mail.kernel.org ([198.145.29.99]:42550 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726113AbeJHK0R (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 8 Oct 2018 06:26:17 -0400", "from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com\n\t[216.129.126.126])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 933D02088F;\n\tMon, 8 Oct 2018 03:16:47 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=default; t=1538968607;\n\tbh=g7Yqj66PVX5CZEpQpjEU5oEiHhtVa2kYvn2d9MxS16E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DyTuFG44Sh3ogHRJvo0OIc2vPuUG3efybS18jUgoluf2/yoHqj7YsBKAjBkDFJYNj\n\tlM1lZjVPAwOxyWRSXAYdnb0xpbTGbJtXCypQVfSJeqkZ1POr5W1iEv4O91GbSSzrUE\n\tPsneO0HxuvhKNJUOI0pLK/P2ETSlZ+aApFgIkpqg=", "From": "David Ahern <dsahern@kernel.org>", "To": "netdev@vger.kernel.org, davem@davemloft.net", "Cc": "christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org,\n\tDavid Ahern <dsahern@gmail.com>", "Subject": "[PATCH v2 net-next 03/23] net: Add extack to nlmsg_parse", "Date": "Sun, 7 Oct 2018 20:16:24 -0700", "Message-Id": "<20181008031644.15989-4-dsahern@kernel.org>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20181008031644.15989-1-dsahern@kernel.org>", "References": "<20181008031644.15989-1-dsahern@kernel.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: David Ahern <dsahern@gmail.com>\n\nMake sure extack is passed to nlmsg_parse where easy to do so.\nMost of these are dump handlers and leveraging the extack in\nthe netlink_callback.\n\nSigned-off-by: David Ahern <dsahern@gmail.com>\nAcked-by: Christian Brauner <christian@brauner.io>\n---\n net/core/devlink.c | 2 +-\n net/core/neighbour.c | 3 ++-\n net/core/rtnetlink.c | 4 ++--\n net/ipv4/devinet.c | 9 +++++----\n net/ipv6/addrconf.c | 2 +-\n net/ipv6/route.c | 2 +-\n net/mpls/af_mpls.c | 2 +-\n net/netfilter/ipvs/ip_vs_ctl.c | 2 +-\n net/sched/act_api.c | 2 +-\n net/sched/cls_api.c | 6 ++++--\n net/sched/sch_api.c | 2 +-\n net/xfrm/xfrm_user.c | 2 +-\n 12 files changed, 21 insertions(+), 17 deletions(-)", "diff": "diff --git a/net/core/devlink.c b/net/core/devlink.c\nindex 938f68ee92f0..6dae81d65d5c 100644\n--- a/net/core/devlink.c\n+++ b/net/core/devlink.c\n@@ -3504,7 +3504,7 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,\n \tstart_offset = *((u64 *)&cb->args[0]);\n \n \terr = nlmsg_parse(cb->nlh, GENL_HDRLEN + devlink_nl_family.hdrsize,\n-\t\t\t attrs, DEVLINK_ATTR_MAX, ops->policy, NULL);\n+\t\t\t attrs, DEVLINK_ATTR_MAX, ops->policy, cb->extack);\n \tif (err)\n \t\tgoto out;\n \ndiff --git a/net/core/neighbour.c b/net/core/neighbour.c\nindex fb023df48b83..b06f794bf91e 100644\n--- a/net/core/neighbour.c\n+++ b/net/core/neighbour.c\n@@ -2445,7 +2445,8 @@ static int neigh_dump_info(struct sk_buff *skb, struct netlink_callback *cb)\n \t ((struct ndmsg *)nlmsg_data(nlh))->ndm_flags == NTF_PROXY)\n \t\tproxy = 1;\n \n-\terr = nlmsg_parse(nlh, sizeof(struct ndmsg), tb, NDA_MAX, NULL, NULL);\n+\terr = nlmsg_parse(nlh, sizeof(struct ndmsg), tb, NDA_MAX, NULL,\n+\t\t\t cb->extack);\n \tif (!err) {\n \t\tif (tb[NDA_IFINDEX]) {\n \t\t\tif (nla_len(tb[NDA_IFINDEX]) != sizeof(u32))\ndiff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c\nindex 5564eee1e980..4486e8b7d9d0 100644\n--- a/net/core/rtnetlink.c\n+++ b/net/core/rtnetlink.c\n@@ -1909,7 +1909,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)\n \t\t sizeof(struct rtgenmsg) : sizeof(struct ifinfomsg);\n \n \tif (nlmsg_parse(cb->nlh, hdrlen, tb, IFLA_MAX,\n-\t\t\tifla_policy, NULL) >= 0) {\n+\t\t\tifla_policy, cb->extack) >= 0) {\n \t\tif (tb[IFLA_TARGET_NETNSID]) {\n \t\t\tnetnsid = nla_get_s32(tb[IFLA_TARGET_NETNSID]);\n \t\t\ttgt_net = rtnl_get_net_ns_capable(skb->sk, netnsid);\n@@ -3774,7 +3774,7 @@ static int rtnl_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb)\n \t (nlmsg_len(cb->nlh) != sizeof(struct ndmsg) +\n \t nla_attr_size(sizeof(u32)))) {\n \t\terr = nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb,\n-\t\t\t\t IFLA_MAX, ifla_policy, NULL);\n+\t\t\t\t IFLA_MAX, ifla_policy, cb->extack);\n \t\tif (err < 0) {\n \t\t\treturn -EINVAL;\n \t\t} else if (err == 0) {\ndiff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c\nindex 44d931a3cd50..ab2b11df5ea4 100644\n--- a/net/ipv4/devinet.c\n+++ b/net/ipv4/devinet.c\n@@ -782,7 +782,8 @@ static void set_ifa_lifetime(struct in_ifaddr *ifa, __u32 valid_lft,\n }\n \n static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,\n-\t\t\t\t __u32 *pvalid_lft, __u32 *pprefered_lft)\n+\t\t\t\t __u32 *pvalid_lft, __u32 *pprefered_lft,\n+\t\t\t\t struct netlink_ext_ack *extack)\n {\n \tstruct nlattr *tb[IFA_MAX+1];\n \tstruct in_ifaddr *ifa;\n@@ -792,7 +793,7 @@ static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,\n \tint err;\n \n \terr = nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, ifa_ipv4_policy,\n-\t\t\t NULL);\n+\t\t\t extack);\n \tif (err < 0)\n \t\tgoto errout;\n \n@@ -897,7 +898,7 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,\n \n \tASSERT_RTNL();\n \n-\tifa = rtm_to_ifaddr(net, nlh, &valid_lft, &prefered_lft);\n+\tifa = rtm_to_ifaddr(net, nlh, &valid_lft, &prefered_lft, extack);\n \tif (IS_ERR(ifa))\n \t\treturn PTR_ERR(ifa);\n \n@@ -1684,7 +1685,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)\n \ts_ip_idx = ip_idx = cb->args[2];\n \n \tif (nlmsg_parse(cb->nlh, sizeof(struct ifaddrmsg), tb, IFA_MAX,\n-\t\t\tifa_ipv4_policy, NULL) >= 0) {\n+\t\t\tifa_ipv4_policy, cb->extack) >= 0) {\n \t\tif (tb[IFA_TARGET_NETNSID]) {\n \t\t\tfillargs.netnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);\n \ndiff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c\nindex a9a317322388..2f8aa4fd5e55 100644\n--- a/net/ipv6/addrconf.c\n+++ b/net/ipv6/addrconf.c\n@@ -5021,7 +5021,7 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,\n \ts_ip_idx = ip_idx = cb->args[2];\n \n \tif (nlmsg_parse(cb->nlh, sizeof(struct ifaddrmsg), tb, IFA_MAX,\n-\t\t\tifa_ipv6_policy, NULL) >= 0) {\n+\t\t\tifa_ipv6_policy, cb->extack) >= 0) {\n \t\tif (tb[IFA_TARGET_NETNSID]) {\n \t\t\tnetnsid = nla_get_s32(tb[IFA_TARGET_NETNSID]);\n \ndiff --git a/net/ipv6/route.c b/net/ipv6/route.c\nindex 74d97addf1af..7c38e0e058ae 100644\n--- a/net/ipv6/route.c\n+++ b/net/ipv6/route.c\n@@ -4117,7 +4117,7 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,\n \tint err;\n \n \terr = nlmsg_parse(nlh, sizeof(*rtm), tb, RTA_MAX, rtm_ipv6_policy,\n-\t\t\t NULL);\n+\t\t\t extack);\n \tif (err < 0)\n \t\tgoto errout;\n \ndiff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c\nindex 8fbe6cdbe255..55a30ee3d820 100644\n--- a/net/mpls/af_mpls.c\n+++ b/net/mpls/af_mpls.c\n@@ -1223,7 +1223,7 @@ static int mpls_netconf_get_devconf(struct sk_buff *in_skb,\n \tint err;\n \n \terr = nlmsg_parse(nlh, sizeof(*ncm), tb, NETCONFA_MAX,\n-\t\t\t devconf_mpls_policy, NULL);\n+\t\t\t devconf_mpls_policy, extack);\n \tif (err < 0)\n \t\tgoto errout;\n \ndiff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c\nindex 62eefea48973..83395bf6dc35 100644\n--- a/net/netfilter/ipvs/ip_vs_ctl.c\n+++ b/net/netfilter/ipvs/ip_vs_ctl.c\n@@ -3234,7 +3234,7 @@ static int ip_vs_genl_dump_dests(struct sk_buff *skb,\n \n \t/* Try to find the service for which to dump destinations */\n \tif (nlmsg_parse(cb->nlh, GENL_HDRLEN, attrs, IPVS_CMD_ATTR_MAX,\n-\t\t\tip_vs_cmd_policy, NULL))\n+\t\t\tip_vs_cmd_policy, cb->extack))\n \t\tgoto out_err;\n \n \ndiff --git a/net/sched/act_api.c b/net/sched/act_api.c\nindex 55153da00278..9c1b0729aebf 100644\n--- a/net/sched/act_api.c\n+++ b/net/sched/act_api.c\n@@ -1452,7 +1452,7 @@ static int tc_dump_action(struct sk_buff *skb, struct netlink_callback *cb)\n \tu32 act_count = 0;\n \n \tret = nlmsg_parse(cb->nlh, sizeof(struct tcamsg), tb, TCA_ROOT_MAX,\n-\t\t\t tcaa_policy, NULL);\n+\t\t\t tcaa_policy, cb->extack);\n \tif (ret < 0)\n \t\treturn ret;\n \ndiff --git a/net/sched/cls_api.c b/net/sched/cls_api.c\nindex d670d3066ebd..43c8559aca56 100644\n--- a/net/sched/cls_api.c\n+++ b/net/sched/cls_api.c\n@@ -1727,7 +1727,8 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb)\n \tif (nlmsg_len(cb->nlh) < sizeof(*tcm))\n \t\treturn skb->len;\n \n-\terr = nlmsg_parse(cb->nlh, sizeof(*tcm), tca, TCA_MAX, NULL, NULL);\n+\terr = nlmsg_parse(cb->nlh, sizeof(*tcm), tca, TCA_MAX, NULL,\n+\t\t\t cb->extack);\n \tif (err)\n \t\treturn err;\n \n@@ -2054,7 +2055,8 @@ static int tc_dump_chain(struct sk_buff *skb, struct netlink_callback *cb)\n \tif (nlmsg_len(cb->nlh) < sizeof(*tcm))\n \t\treturn skb->len;\n \n-\terr = nlmsg_parse(cb->nlh, sizeof(*tcm), tca, TCA_MAX, NULL, NULL);\n+\terr = nlmsg_parse(cb->nlh, sizeof(*tcm), tca, TCA_MAX, NULL,\n+\t\t\t cb->extack);\n \tif (err)\n \t\treturn err;\n \ndiff --git a/net/sched/sch_api.c b/net/sched/sch_api.c\nindex da1963b19dec..cf5c714ae786 100644\n--- a/net/sched/sch_api.c\n+++ b/net/sched/sch_api.c\n@@ -1671,7 +1671,7 @@ static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb)\n \tASSERT_RTNL();\n \n \terr = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX,\n-\t\t\t rtm_tca_policy, NULL);\n+\t\t\t rtm_tca_policy, cb->extack);\n \tif (err < 0)\n \t\treturn err;\n \ndiff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c\nindex df7ca2dabc48..ca7a207b81a9 100644\n--- a/net/xfrm/xfrm_user.c\n+++ b/net/xfrm/xfrm_user.c\n@@ -1007,7 +1007,7 @@ static int xfrm_dump_sa(struct sk_buff *skb, struct netlink_callback *cb)\n \t\tint err;\n \n \t\terr = nlmsg_parse(cb->nlh, 0, attrs, XFRMA_MAX, xfrma_policy,\n-\t\t\t\t NULL);\n+\t\t\t\t cb->extack);\n \t\tif (err < 0)\n \t\t\treturn err;\n \n", "prefixes": [ "v2", "net-next", "03/23" ] }