Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/979092/?format=api
{ "id": 979092, "url": "http://patchwork.ozlabs.org/api/patches/979092/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181004175732.28329-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181004175732.28329-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2018-10-04T17:57:32", "name": "[-next] ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2a09e90da08de44c6a0c0d0fa3602567c5486a14", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181004175732.28329-1-colin.king@canonical.com/mbox/", "series": [ { "id": 69089, "url": "http://patchwork.ozlabs.org/api/series/69089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=69089", "date": "2018-10-04T17:57:32", "name": "[-next] ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/69089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/979092/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/979092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42R0wV6G87z9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Oct 2018 03:57:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A5C3185EFD;\n\tThu, 4 Oct 2018 17:57:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4UjJBwnoBSmt; Thu, 4 Oct 2018 17:57:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1B94C85F05;\n\tThu, 4 Oct 2018 17:57:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4D5B91BF572\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Oct 2018 17:57:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F399B87042\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Oct 2018 17:57:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HknWN6MNq4PR for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Oct 2018 17:57:37 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 2A6F586F92\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Oct 2018 17:57:37 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1g87sS-0000le-KB; Thu, 04 Oct 2018 17:57:32 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 4 Oct 2018 18:57:32 +0100", "Message-Id": "<20181004175732.28329-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH][-next] ixgbe: don't clear_bit on\n\txdp_ring->state if xdp_ring is null", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThere is an earlier check to see if xdp_ring is null when configuring\nthe tx ring, so assuming that it can still be null, the clearing of\nthe xdp_ring->state currently could end up with a null pointer\ndereference. Fix this by only clearing the bit if xdp_ring is not null.\n\nDetected by CoverityScan, CID#1473795 (\"Dereference after null check\")\n\nFixes: 024aa5800f32 (\"ixgbe: added Rx/Tx ring disable/enable functions\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 0049a2becd7e..8e4756247324 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -10517,7 +10517,8 @@ void ixgbe_txrx_ring_enable(struct ixgbe_adapter *adapter, int ring)\n \tixgbe_configure_rx_ring(adapter, rx_ring);\n \n \tclear_bit(__IXGBE_TX_DISABLED, &tx_ring->state);\n-\tclear_bit(__IXGBE_TX_DISABLED, &xdp_ring->state);\n+\tif (xdp_ring)\n+\t\tclear_bit(__IXGBE_TX_DISABLED, &xdp_ring->state);\n }\n \n /**\n", "prefixes": [ "-next" ] }