Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/978369/?format=api
{ "id": 978369, "url": "http://patchwork.ozlabs.org/api/patches/978369/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181003053902.6910-6-ldr709@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181003053902.6910-6-ldr709@gmail.com>", "list_archive_url": null, "date": "2018-10-03T05:38:51", "name": "[05/16] igbvf: Replace spin_is_locked() with lockdep", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "857eba7c5286d9f86722386f293ac4987fd531f8", "submitter": { "id": 75040, "url": "http://patchwork.ozlabs.org/api/people/75040/?format=api", "name": "Lance Roy", "email": "ldr709@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181003053902.6910-6-ldr709@gmail.com/mbox/", "series": [ { "id": 68820, "url": "http://patchwork.ozlabs.org/api/series/68820/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=68820", "date": "2018-10-03T05:38:51", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/68820/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/978369/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/978369/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jUDXfxVd\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42QJYP6Lx9zB2xk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Oct 2018 00:38:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E6BE4872D3;\n\tWed, 3 Oct 2018 14:38:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LmuCCEiKXpNl; Wed, 3 Oct 2018 14:38:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BAE3E87251;\n\tWed, 3 Oct 2018 14:38:46 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9BA121C0CE2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 98B85884ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y9cS0lsnsJix for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:55 +0000 (UTC)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 371C6884D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:55 +0000 (UTC)", "by mail-pf1-f195.google.com with SMTP id m77-v6so1098473pfi.8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 02 Oct 2018 22:39:55 -0700 (PDT)", "from E570.localdomain (c-24-21-68-121.hsd1.or.comcast.net.\n\t[24.21.68.121]) by smtp.gmail.com with ESMTPSA id\n\tx69-v6sm499091pff.175.2018.10.02.22.39.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Oct 2018 22:39:54 -0700 (PDT)", "by E570.localdomain (Postfix, from userid 1000)\n\tid 9EEA61643D0; Tue, 2 Oct 2018 22:39:53 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to\n\t:mime-version:content-transfer-encoding;\n\tbh=rSXE1F6VacTevCbA7egalmTDNA0MErWNqJnY+ifDMwQ=;\n\tb=jUDXfxVdqUFnZtdJAEhM4hzwXAEGFrcxsY6v+9x2o4ijs85qMDop7/69XgOYDFdpVn\n\teKfshoQT4EG4LZQyx443xvkcu61gba0PrvfiN7y13E7BMyDo3aBBsjNpF/BqDwuYqamG\n\tQ2C/w4/wKArA5VhGoDxOp5V3N3MpepFyEWbzrcPMjGdLKtDNxG/e3H9T9a3Qa8WY/XfQ\n\t6urXryjZ4fUXgNPvmFtDhmvkEms6rKoazZZQKwt0TljJfUOocSoCFDGxcoiQd2ZekjtV\n\tMhR+XXj8j0s0TgoREKHJwZNWmnKLfj1gZRuQ6BVQLqfQsjL3rkjZhsPVB9UaglRwZ+k8\n\txq0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:reply-to:mime-version:content-transfer-encoding;\n\tbh=rSXE1F6VacTevCbA7egalmTDNA0MErWNqJnY+ifDMwQ=;\n\tb=N7hPmc5a9DkMxXwzem7SIpRBSRd7OSuqMCP9/zZRAZ0LhRAA5K6SXT4B4VsO8Qc3vO\n\tvo8ZFPevZal72c5eGx7bq/nLxEoRq1CmWA7zBlA0elRJYpZ3ks3pEh/KwQEkU0pgxht1\n\tR7PqjAJSM30Obo5AZOB2fDm5WVGp4HuaZm/CI/K3piTA3SEjaWqyLAeEg9D8jKLzOMMc\n\th9lY/7dj9s7K8U/tbFObjDNKz9g0nG+RAdoEhIs6lTWcuc4dbzR5WTxEiNVIJopTNm+S\n\tRi4C5erprdV4ROCOFeZVSczmB++/JxHKfYldjPrclxFNhYjumxOYQubbxlb+BmEMP2Vi\n\t92YQ==", "X-Gm-Message-State": "ABuFfoiJYuI1SvOWElwjhCnPIW/E8Ujb7miJD/DQc81KCA8k5VkrG6YG\n\tpUwBG5GRRyX45qI6dNpIbpo=", "X-Google-Smtp-Source": "ACcGV63B529bQti4/dQpF5WT4ee8bJ6QnNse28ZOnylttGqDYxJ/L76jzbvbkIqohfW1mY4plx2IXw==", "X-Received": "by 2002:a62:8145:: with SMTP id\n\tt66-v6mr19285852pfd.192.1538545194832; \n\tTue, 02 Oct 2018 22:39:54 -0700 (PDT)", "From": "Lance Roy <ldr709@gmail.com>", "To": "linux-kernel@vger.kernel.org", "Date": "Tue, 2 Oct 2018 22:38:51 -0700", "Message-Id": "<20181003053902.6910-6-ldr709@gmail.com>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181003053902.6910-1-ldr709@gmail.com>", "References": "<20181003053902.6910-1-ldr709@gmail.com>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Wed, 03 Oct 2018 14:38:45 +0000", "Subject": "[Intel-wired-lan] [PATCH 05/16] igbvf: Replace spin_is_locked()\n\twith lockdep", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Reply-To": "Lance Roy <ldr709@gmail.com>", "Cc": "netdev@vger.kernel.org, Lance Roy <ldr709@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org,\n\t\"Paul E. McKenney\" <paulmck@linux.ibm.com>, \n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "lockdep_assert_held() is better suited to checking locking requirements,\nsince it won't get confused when someone else holds the lock. This is\nalso a step towards possibly removing spin_is_locked().\n\nSigned-off-by: Lance Roy <ldr709@gmail.com>\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: intel-wired-lan@lists.osuosl.org\nCc: <netdev@vger.kernel.org>\n---\n drivers/net/ethernet/intel/igbvf/mbx.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igbvf/mbx.c b/drivers/net/ethernet/intel/igbvf/mbx.c\nindex 163e5838f7c2..a3cd7ac48d4b 100644\n--- a/drivers/net/ethernet/intel/igbvf/mbx.c\n+++ b/drivers/net/ethernet/intel/igbvf/mbx.c\n@@ -241,7 +241,7 @@ static s32 e1000_write_mbx_vf(struct e1000_hw *hw, u32 *msg, u16 size)\n \ts32 err;\n \tu16 i;\n \n-\tWARN_ON_ONCE(!spin_is_locked(&hw->mbx_lock));\n+\tlockdep_assert_held(&hw->mbx_lock);\n \n \t/* lock the mailbox to prevent pf/vf race condition */\n \terr = e1000_obtain_mbx_lock_vf(hw);\n@@ -279,7 +279,7 @@ static s32 e1000_read_mbx_vf(struct e1000_hw *hw, u32 *msg, u16 size)\n \ts32 err;\n \tu16 i;\n \n-\tWARN_ON_ONCE(!spin_is_locked(&hw->mbx_lock));\n+\tlockdep_assert_held(&hw->mbx_lock);\n \n \t/* lock the mailbox to prevent pf/vf race condition */\n \terr = e1000_obtain_mbx_lock_vf(hw);\n", "prefixes": [ "05/16" ] }