Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/978368/?format=api
{ "id": 978368, "url": "http://patchwork.ozlabs.org/api/patches/978368/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181003053902.6910-5-ldr709@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181003053902.6910-5-ldr709@gmail.com>", "list_archive_url": null, "date": "2018-10-03T05:38:50", "name": "[04/16] i40e: Replace spin_is_locked() with lockdep", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a85d9d1c2e85dcc6515a0563b8d5364d7b1b6f6a", "submitter": { "id": 75040, "url": "http://patchwork.ozlabs.org/api/people/75040/?format=api", "name": "Lance Roy", "email": "ldr709@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181003053902.6910-5-ldr709@gmail.com/mbox/", "series": [ { "id": 68819, "url": "http://patchwork.ozlabs.org/api/series/68819/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=68819", "date": "2018-10-03T05:38:50", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/68819/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/978368/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/978368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VhDoom+T\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42QJYP6LvszB2xb\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Oct 2018 00:38:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 123D987270;\n\tWed, 3 Oct 2018 14:38:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mMVBO7Gx_gv2; Wed, 3 Oct 2018 14:38:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 84DD887234;\n\tWed, 3 Oct 2018 14:38:46 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A20E21C0CE2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9163226536\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:53 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YvjSiUZEwbtH for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:52 +0000 (UTC)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 6B0BF2626E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Oct 2018 05:39:52 +0000 (UTC)", "by mail-pg1-f196.google.com with SMTP id n31-v6so1018097pgm.7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 02 Oct 2018 22:39:52 -0700 (PDT)", "from E570.localdomain (c-24-21-68-121.hsd1.or.comcast.net.\n\t[24.21.68.121]) by smtp.gmail.com with ESMTPSA id\n\tw23-v6sm363481pgi.18.2018.10.02.22.39.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 02 Oct 2018 22:39:51 -0700 (PDT)", "by E570.localdomain (Postfix, from userid 1000)\n\tid BAF131643D0; Tue, 2 Oct 2018 22:39:50 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to\n\t:mime-version:content-transfer-encoding;\n\tbh=5L6Z4aW4+1t2LE/MND/iINCiEdG9eaFMJEfCbvDLBaQ=;\n\tb=VhDoom+TY1K77b9/Qh+vlNgbAUyKBqHN74GHpYz7GAFqydYOaKD9cc7x9P2HLvJgVq\n\tvHPbLvZCxfNFff+tmizReKcLb+vIE/2LKf6vsRzY/a3SJl26c0+QaCvImgSslRE6kZdc\n\tTgc72eC+38Sojg0tfUa27CwNHqLk9zxRG4uuR3MblN39ogHvq/s0vKSTyvMLQG47+LbV\n\t4mzfWukTnRP+eQq52vnoeeD85IDsBnPmVrpgsJWWC8LjyUT8DGtb7qPbTz2bOKUCPVXr\n\t1pdeK9VDZKq0f7eKuEHQWgoJEM9iNmZSNqYan2t6PdpV5MJw1h3ax+jhcLk+dI41LWWM\n\tKc+w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:reply-to:mime-version:content-transfer-encoding;\n\tbh=5L6Z4aW4+1t2LE/MND/iINCiEdG9eaFMJEfCbvDLBaQ=;\n\tb=kgN1fe2lAzloGcYnL6DtUvov92EcQkZDzd0tGSvWv6xNZy6FNGQG3f1DIT0SM4O9hh\n\tIf5y5rJ5INJ6kT4l9uP2j5lXSNMSnbQuy3AAWjVJg2XHll+4ysAYkWWGTmPh5b15g1JH\n\tW63FNv1CMM37cpFuKoPc14GjJ1qNQUJZ5LfLmi1wCEEWX8rQT2iQqqFJnriXn0HkkIUf\n\tLiNbAM2GO9yZ0NDc6pnd8plRJupKM70h7dlgtJ3EUTK5mG+GyRX/fBeDgrt2TSPX5Lc+\n\tli12/bAat2ujALYYd2rb8cn5SFV8H6LobiovnX9noGTxW+ooSZQlF7flrqFI1c9s4O06\n\tVfbg==", "X-Gm-Message-State": "ABuFfoi/5pA2/S6w1pUEMKlp/carvLfQ2X+zAhK8oa4qkoRSJikrz5LL\n\tcFCBfc+M/590aDDt8R1xY1E=", "X-Google-Smtp-Source": "ACcGV60WvxLiMsH35V+1rzrINgt5FwS72CIvI4rivm2nYxtxFcPmuEu2cpUg3gQ2PO8XYuwUo4vCOA==", "X-Received": "by 2002:aa7:8598:: with SMTP id\n\tw24-v6mr3587383pfn.77.1538545192026; \n\tTue, 02 Oct 2018 22:39:52 -0700 (PDT)", "From": "Lance Roy <ldr709@gmail.com>", "To": "linux-kernel@vger.kernel.org", "Date": "Tue, 2 Oct 2018 22:38:50 -0700", "Message-Id": "<20181003053902.6910-5-ldr709@gmail.com>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181003053902.6910-1-ldr709@gmail.com>", "References": "<20181003053902.6910-1-ldr709@gmail.com>", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Wed, 03 Oct 2018 14:38:45 +0000", "Subject": "[Intel-wired-lan] [PATCH 04/16] i40e: Replace spin_is_locked() with\n\tlockdep", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Reply-To": "Lance Roy <ldr709@gmail.com>", "Cc": "netdev@vger.kernel.org, Lance Roy <ldr709@gmail.com>,\n\tintel-wired-lan@lists.osuosl.org,\n\t\"Paul E. McKenney\" <paulmck@linux.ibm.com>, \n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "lockdep_assert_held() is better suited to checking locking requirements,\nsince it won't get confused when someone else holds the lock. This is\nalso a step towards possibly removing spin_is_locked().\n\nSigned-off-by: Lance Roy <ldr709@gmail.com>\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: intel-wired-lan@lists.osuosl.org\nCc: <netdev@vger.kernel.org>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex ac685ad4d877..8ce3471723d3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1489,8 +1489,7 @@ int i40e_del_mac_filter(struct i40e_vsi *vsi, const u8 *macaddr)\n \tbool found = false;\n \tint bkt;\n \n-\tWARN(!spin_is_locked(&vsi->mac_filter_hash_lock),\n-\t \"Missing mac_filter_hash_lock\\n\");\n+\tlockdep_assert_held(&vsi->mac_filter_hash_lock);\n \thash_for_each_safe(vsi->mac_filter_hash, bkt, h, f, hlist) {\n \t\tif (ether_addr_equal(macaddr, f->macaddr)) {\n \t\t\t__i40e_del_filter(vsi, f);\n", "prefixes": [ "04/16" ] }