Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/977669/?format=api
{ "id": 977669, "url": "http://patchwork.ozlabs.org/api/patches/977669/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181002080034.11754-3-bjorn.topel@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181002080034.11754-3-bjorn.topel@gmail.com>", "list_archive_url": null, "date": "2018-10-02T08:00:31", "name": "[v2,2/5] ixgbe: move common Rx functions to ixgbe_txrx_common.h", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "32644c1118e4f344a0551ab7f545ac69c143a673", "submitter": { "id": 70569, "url": "http://patchwork.ozlabs.org/api/people/70569/?format=api", "name": "Björn Töpel", "email": "bjorn.topel@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181002080034.11754-3-bjorn.topel@gmail.com/mbox/", "series": [ { "id": 68583, "url": "http://patchwork.ozlabs.org/api/series/68583/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=68583", "date": "2018-10-02T08:00:30", "name": "Introducing ixgbe AF_XDP ZC support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/68583/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/977669/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/977669/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42PWnN1s3Yz9sj1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 2 Oct 2018 18:01:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D26A886DAA;\n\tTue, 2 Oct 2018 08:01:26 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fl88h0QzhN_l; Tue, 2 Oct 2018 08:01:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A43CD86D9E;\n\tTue, 2 Oct 2018 08:01:25 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9A8A51BF479\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 95C6E87DC7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9vZUfbMXIxzJ for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:17 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 48BAB877A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:17 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2018 01:01:17 -0700", "from pvenkata-mobl.amr.corp.intel.com (HELO\n\tbtopel-mobl1.ger.corp.intel.com) ([10.252.35.165])\n\tby orsmga003.jf.intel.com with ESMTP; 02 Oct 2018 01:01:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,331,1534834800\"; d=\"scan'208\";a=\"88439264\"", "From": "=?utf-8?b?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 2 Oct 2018 10:00:31 +0200", "Message-Id": "<20181002080034.11754-3-bjorn.topel@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20181002080034.11754-1-bjorn.topel@gmail.com>", "References": "<20181002080034.11754-1-bjorn.topel@gmail.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2 2/5] ixgbe: move common Rx functions to\n\tixgbe_txrx_common.h", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "jakub.kicinski@netronome.com, daniel@iogearbox.net,\n\tnetdev@vger.kernel.org, ast@kernel.org, tuc@vmware.com,\n\tu9012063@gmail.com, brouer@redhat.com, =?utf-8?b?QmrDtnJuIFTDtnBlbA==?=\n\t<bjorn.topel@intel.com>, magnus.karlsson@gmail.com,\n\tmagnus.karlsson@intel.com", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Björn Töpel <bjorn.topel@intel.com>\n\nThis patch prepares for the upcoming zero-copy Rx functionality, by\nmoving/changing linkage of common functions, used both by the regular\npath and zero-copy path.\n\nSigned-off-by: Björn Töpel <bjorn.topel@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 29 +++++++------------\n .../ethernet/intel/ixgbe/ixgbe_txrx_common.h | 26 +++++++++++++++++\n 2 files changed, 37 insertions(+), 18 deletions(-)\n create mode 100644 drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 6ff886498882..cc655c4e24fd 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -40,6 +40,7 @@\n #include \"ixgbe_dcb_82599.h\"\n #include \"ixgbe_sriov.h\"\n #include \"ixgbe_model.h\"\n+#include \"ixgbe_txrx_common.h\"\n \n char ixgbe_driver_name[] = \"ixgbe\";\n static const char ixgbe_driver_string[] =\n@@ -1673,9 +1674,9 @@ static void ixgbe_update_rsc_stats(struct ixgbe_ring *rx_ring,\n * order to populate the hash, checksum, VLAN, timestamp, protocol, and\n * other fields within the skb.\n **/\n-static void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring,\n-\t\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n-\t\t\t\t struct sk_buff *skb)\n+void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring,\n+\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n+\t\t\t struct sk_buff *skb)\n {\n \tstruct net_device *dev = rx_ring->netdev;\n \tu32 flags = rx_ring->q_vector->adapter->flags;\n@@ -1708,8 +1709,8 @@ static void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring,\n \tskb->protocol = eth_type_trans(skb, dev);\n }\n \n-static void ixgbe_rx_skb(struct ixgbe_q_vector *q_vector,\n-\t\t\t struct sk_buff *skb)\n+void ixgbe_rx_skb(struct ixgbe_q_vector *q_vector,\n+\t\t struct sk_buff *skb)\n {\n \tnapi_gro_receive(&q_vector->napi, skb);\n }\n@@ -1868,9 +1869,9 @@ static void ixgbe_dma_sync_frag(struct ixgbe_ring *rx_ring,\n *\n * Returns true if an error was encountered and skb was freed.\n **/\n-static bool ixgbe_cleanup_headers(struct ixgbe_ring *rx_ring,\n-\t\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n-\t\t\t\t struct sk_buff *skb)\n+bool ixgbe_cleanup_headers(struct ixgbe_ring *rx_ring,\n+\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n+\t\t\t struct sk_buff *skb)\n {\n \tstruct net_device *netdev = rx_ring->netdev;\n \n@@ -2186,14 +2187,6 @@ static struct sk_buff *ixgbe_build_skb(struct ixgbe_ring *rx_ring,\n \treturn skb;\n }\n \n-#define IXGBE_XDP_PASS\t\t0\n-#define IXGBE_XDP_CONSUMED\tBIT(0)\n-#define IXGBE_XDP_TX\t\tBIT(1)\n-#define IXGBE_XDP_REDIR\t\tBIT(2)\n-\n-static int ixgbe_xmit_xdp_ring(struct ixgbe_adapter *adapter,\n-\t\t\t struct xdp_frame *xdpf);\n-\n static struct sk_buff *ixgbe_run_xdp(struct ixgbe_adapter *adapter,\n \t\t\t\t struct ixgbe_ring *rx_ring,\n \t\t\t\t struct xdp_buff *xdp)\n@@ -8471,8 +8464,8 @@ static u16 ixgbe_select_queue(struct net_device *dev, struct sk_buff *skb,\n }\n \n #endif\n-static int ixgbe_xmit_xdp_ring(struct ixgbe_adapter *adapter,\n-\t\t\t struct xdp_frame *xdpf)\n+int ixgbe_xmit_xdp_ring(struct ixgbe_adapter *adapter,\n+\t\t\tstruct xdp_frame *xdpf)\n {\n \tstruct ixgbe_ring *ring = adapter->xdp_ring[smp_processor_id()];\n \tstruct ixgbe_tx_buffer *tx_buffer;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h\nnew file mode 100644\nindex 000000000000..3780d315b991\n--- /dev/null\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h\n@@ -0,0 +1,26 @@\n+/* SPDX-License-Identifier: GPL-2.0 */\n+/* Copyright(c) 2018 Intel Corporation. */\n+\n+#ifndef _IXGBE_TXRX_COMMON_H_\n+#define _IXGBE_TXRX_COMMON_H_\n+\n+#define IXGBE_XDP_PASS\t\t0\n+#define IXGBE_XDP_CONSUMED\tBIT(0)\n+#define IXGBE_XDP_TX\t\tBIT(1)\n+#define IXGBE_XDP_REDIR\t\tBIT(2)\n+\n+int ixgbe_xmit_xdp_ring(struct ixgbe_adapter *adapter,\n+\t\t\tstruct xdp_frame *xdpf);\n+bool ixgbe_cleanup_headers(struct ixgbe_ring *rx_ring,\n+\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n+\t\t\t struct sk_buff *skb);\n+void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring,\n+\t\t\t union ixgbe_adv_rx_desc *rx_desc,\n+\t\t\t struct sk_buff *skb);\n+void ixgbe_rx_skb(struct ixgbe_q_vector *q_vector,\n+\t\t struct sk_buff *skb);\n+\n+void ixgbe_txrx_ring_disable(struct ixgbe_adapter *adapter, int ring);\n+void ixgbe_txrx_ring_enable(struct ixgbe_adapter *adapter, int ring);\n+\n+#endif /* #define _IXGBE_TXRX_COMMON_H_ */\n", "prefixes": [ "v2", "2/5" ] }