Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/973848/?format=api
{ "id": 973848, "url": "http://patchwork.ozlabs.org/api/patches/973848/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1537773860-42997-1-git-send-email-radoslawx.tyl@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1537773860-42997-1-git-send-email-radoslawx.tyl@intel.com>", "list_archive_url": null, "date": "2018-09-24T07:24:20", "name": "ixgbe: Fix crash with VFs and flow director on interface flap", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9828e9e069c56fd1f6172f178a177b5a3d3433d7", "submitter": { "id": 74872, "url": "http://patchwork.ozlabs.org/api/people/74872/?format=api", "name": "Radoslaw Tyl", "email": "radoslawx.tyl@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1537773860-42997-1-git-send-email-radoslawx.tyl@intel.com/mbox/", "series": [ { "id": 67150, "url": "http://patchwork.ozlabs.org/api/series/67150/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=67150", "date": "2018-09-24T07:24:20", "name": "ixgbe: Fix crash with VFs and flow director on interface flap", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/67150/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/973848/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/973848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42JbWZ4Jvyz9s8F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 24 Sep 2018 17:32:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AC69588D38;\n\tMon, 24 Sep 2018 07:32:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id HQtgYVL5OLuK; Mon, 24 Sep 2018 07:32:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8646D88D30;\n\tMon, 24 Sep 2018 07:32:21 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 587C61C2D4E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 24 Sep 2018 07:32:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 510D089BD6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 24 Sep 2018 07:32:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GExzAKicA6lb for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 24 Sep 2018 07:32:19 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D412C89BD2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 24 Sep 2018 07:32:19 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 00:32:18 -0700", "from gklab-246-010.igk.intel.com (HELO s215.localdomain)\n\t([10.217.246.10])\n\tby orsmga003.jf.intel.com with ESMTP; 24 Sep 2018 00:27:19 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,296,1534834800\"; d=\"scan'208\";a=\"86018990\"", "From": "Radoslaw Tyl <radoslawx.tyl@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 24 Sep 2018 09:24:20 +0200", "Message-Id": "<1537773860-42997-1-git-send-email-radoslawx.tyl@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix crash with VFs and flow\n\tdirector on interface flap", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Radoslaw Tyl <radoslawx.tyl@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch fix crash when we have restore flow director filters after reset\nadapter. In ixgbe_fdir_filter_restore() filter->action is outside of the\nrx_ring array, as it has a VF identifier in the upper 32 bits.\n\nSigned-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 604282f..88181c5 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -5173,6 +5173,7 @@ static void ixgbe_fdir_filter_restore(struct ixgbe_adapter *adapter)\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \tstruct hlist_node *node2;\n \tstruct ixgbe_fdir_filter *filter;\n+\tu64 action;\n \n \tspin_lock(&adapter->fdir_perfect_lock);\n \n@@ -5181,12 +5182,17 @@ static void ixgbe_fdir_filter_restore(struct ixgbe_adapter *adapter)\n \n \thlist_for_each_entry_safe(filter, node2,\n \t\t\t\t &adapter->fdir_filter_list, fdir_node) {\n+\t\taction = filter->action;\n+\t\tif (action != IXGBE_FDIR_DROP_QUEUE && action != 0)\n+\t\t\taction =\n+\t\t\t(action >> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF) - 1;\n+\n \t\tixgbe_fdir_write_perfect_filter_82599(hw,\n \t\t\t\t&filter->filter,\n \t\t\t\tfilter->sw_idx,\n-\t\t\t\t(filter->action == IXGBE_FDIR_DROP_QUEUE) ?\n+\t\t\t\t(action == IXGBE_FDIR_DROP_QUEUE) ?\n \t\t\t\tIXGBE_FDIR_DROP_QUEUE :\n-\t\t\t\tadapter->rx_ring[filter->action]->reg_idx);\n+\t\t\t\tadapter->rx_ring[action]->reg_idx);\n \t}\n \n \tspin_unlock(&adapter->fdir_perfect_lock);\n", "prefixes": [] }